Patchwork buildhistory: change default BUILDHISTORY_DIR to TOPDIR

login
register
mail settings
Submitter Martin Jansa
Date April 27, 2013, 3:15 p.m.
Message ID <1367075749-6702-1-git-send-email-Martin.Jansa@gmail.com>
Download mbox | patch
Permalink /patch/48987/
State Accepted
Commit d3ad9a4c573fec08b5606a4c3e86f93cb95e8718
Headers show

Comments

Martin Jansa - April 27, 2013, 3:15 p.m.
* like PERSISTENT_DIR I find BUILDHISTORY_DIR more persistent
  then tmp-eglibc directory
* WARN: people with existing checkouts in TMPDIR/buildhistory
  need to move it to new location first (in order to save history)

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/classes/buildhistory.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - April 27, 2013, 11:27 p.m.
On Sat, Apr 27, 2013 at 12:15 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
> * like PERSISTENT_DIR I find BUILDHISTORY_DIR more persistent
>   then tmp-eglibc directory
> * WARN: people with existing checkouts in TMPDIR/buildhistory
>   need to move it to new location first (in order to save history)
>
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>

I've been doing it locally all the time; thanks by sending this :-)

Acked-by: Otavio Salvador <otavio@ossystems.com.br>

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Koen Kooi - April 28, 2013, 8:37 a.m.
Op 28 apr. 2013, om 01:27 heeft Otavio Salvador <otavio@ossystems.com.br> het volgende geschreven:

> On Sat, Apr 27, 2013 at 12:15 PM, Martin Jansa <martin.jansa@gmail.com> wrote:
>> * like PERSISTENT_DIR I find BUILDHISTORY_DIR more persistent
>>  then tmp-eglibc directory
>> * WARN: people with existing checkouts in TMPDIR/buildhistory
>>  need to move it to new location first (in order to save history)
>> 
>> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> I've been doing it locally all the time; thanks by sending this :-)
> 
> Acked-by: Otavio Salvador <otavio@ossystems.com.br>

Same here :)

Acked-by: Koen Kooi <koen@dominion.thruhere.net>

Patch

diff --git a/meta/classes/buildhistory.bbclass b/meta/classes/buildhistory.bbclass
index 1ac1a8b..8efd41c 100644
--- a/meta/classes/buildhistory.bbclass
+++ b/meta/classes/buildhistory.bbclass
@@ -8,7 +8,7 @@ 
 #
 
 BUILDHISTORY_FEATURES ?= "image package sdk"
-BUILDHISTORY_DIR ?= "${TMPDIR}/buildhistory"
+BUILDHISTORY_DIR ?= "${TOPDIR}/buildhistory"
 BUILDHISTORY_DIR_IMAGE = "${BUILDHISTORY_DIR}/images/${MACHINE_ARCH}/${TCLIBC}/${IMAGE_BASENAME}"
 BUILDHISTORY_DIR_PACKAGE = "${BUILDHISTORY_DIR}/packages/${MULTIMACH_TARGET_SYS}/${PN}"
 BUILDHISTORY_DIR_SDK = "${BUILDHISTORY_DIR}/sdk/${SDK_NAME}"