Patchwork [fsl-community-bsp-platform] linux-imx (2.6.35.3): Update UEVENT helper path

login
register
mail settings
Submitter Mahesh Mahadevan
Date April 26, 2013, 5:46 p.m.
Message ID <1366998385-5929-1-git-send-email-Mahesh.Mahadevan@freescale.com>
Download mbox | patch
Permalink /patch/48959/
State Rejected
Delegated to: Otavio Salvador
Headers show

Comments

Mahesh Mahadevan - April 26, 2013, 5:46 p.m.
Update to match the defconfig included in the kernel

Signed-off-by: Mahesh Mahadevan <Mahesh.Mahadevan@freescale.com>
---
 recipes-kernel/linux/linux-imx-2.6.35.3/imx28evk/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Otavio Salvador - April 26, 2013, 6:20 p.m.
On Fri, Apr 26, 2013 at 2:46 PM, Mahesh Mahadevan
<Mahesh.Mahadevan@freescale.com> wrote:
> Update to match the defconfig included in the kernel
>
> Signed-off-by: Mahesh Mahadevan <Mahesh.Mahadevan@freescale.com>

This is not the used binary since long time. All today use udev (or
cold devices nodes) so I see no reason to make this. It'd be better to
update it in the kernel GIT, not add an unused value.

What do you think?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Mahadevan Mahesh-R9AADQ - April 26, 2013, 6:27 p.m.
Sure.

-----Original Message-----
From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On Behalf Of Otavio Salvador
Sent: Friday, April 26, 2013 1:21 PM
To: Mahadevan Mahesh-R9AADQ
Cc: meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [fsl-community-bsp-platform][PATCH] linux-imx (2.6.35.3): Update UEVENT helper path

On Fri, Apr 26, 2013 at 2:46 PM, Mahesh Mahadevan
<Mahesh.Mahadevan@freescale.com> wrote:
> Update to match the defconfig included in the kernel
>
> Signed-off-by: Mahesh Mahadevan <Mahesh.Mahadevan@freescale.com>

This is not the used binary since long time. All today use udev (or
cold devices nodes) so I see no reason to make this. It'd be better to
update it in the kernel GIT, not add an unused value.

What do you think?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-kernel/linux/linux-imx-2.6.35.3/imx28evk/defconfig b/recipes-kernel/linux/linux-imx-2.6.35.3/imx28evk/defconfig
index dbb4eaa..3370e1d 100644
--- a/recipes-kernel/linux/linux-imx-2.6.35.3/imx28evk/defconfig
+++ b/recipes-kernel/linux/linux-imx-2.6.35.3/imx28evk/defconfig
@@ -531,7 +531,7 @@  CONFIG_RFKILL_INPUT=y
 #
 # Generic Driver Options
 #
-CONFIG_UEVENT_HELPER_PATH=""
+CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_STANDALONE=y