Patchwork [bitbake-devel] goggle: fix invalid error check

login
register
mail settings
Submitter Martin Donnelly
Date April 25, 2013, 4:41 p.m.
Message ID <1366908066-8493-1-git-send-email-martin.donnelly@ge.com>
Download mbox | patch
Permalink /patch/48909/
State Accepted
Commit 263aa44ed47e0cb03e1a97e7ed4a50bd9f828c78
Headers show

Comments

Martin Donnelly - April 25, 2013, 4:41 p.m.
runCommand was returning 'error' but checking for 'err'
resulting in an exception.

Signed-off-by: Martin Donnelly <martin.donnelly@ge.com>
---
 lib/bb/ui/goggle.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/lib/bb/ui/goggle.py b/lib/bb/ui/goggle.py
index c0785b7..e8a54ab 100644
--- a/lib/bb/ui/goggle.py
+++ b/lib/bb/ui/goggle.py
@@ -81,7 +81,7 @@  def main (server, eventHandler):
 
     try:
         cmdline, error = server.runCommand(["getCmdLineAction"])
-        if err:
+        if error:
             print("Error getting bitbake commandline: %s" % error)
             return 1
         elif not cmdline: