Patchwork gdb: Disable hard-coding of library rpaths

login
register
mail settings
Submitter Phil Blundell
Date April 25, 2013, 10:26 a.m.
Message ID <1366885598.14512.71.camel@phil-desktop.brightsign>
Download mbox | patch
Permalink /patch/48865/
State New
Headers show

Comments

Phil Blundell - April 25, 2013, 10:26 a.m.
GDB's configury has a tendency to hard-code the path where it found
libexpat using "-Wl,--rpath".  This is undesirable and leads to QA warnings.

Fortunately, the helpful GDB maintainers have provided a "--disable-rpath"
switch to turn this behaviour off.  Let's use it and profit.

Signed-off-by: Phil Blundell <philb@gnu.org>
---
 meta/recipes-devtools/gdb/gdb-common.inc |    1 +
 1 file changed, 1 insertion(+)
Martin Jansa - April 25, 2013, 10:50 a.m.
On Thu, Apr 25, 2013 at 11:26:38AM +0100, Phil Blundell wrote:
> GDB's configury has a tendency to hard-code the path where it found
> libexpat using "-Wl,--rpath".  This is undesirable and leads to QA warnings.
> 
> Fortunately, the helpful GDB maintainers have provided a "--disable-rpath"
> switch to turn this behaviour off.  Let's use it and profit.
> 
> Signed-off-by: Phil Blundell <philb@gnu.org>
> ---
>  meta/recipes-devtools/gdb/gdb-common.inc |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
> index 9eb6b60..0e542d8 100644
> --- a/meta/recipes-devtools/gdb/gdb-common.inc
> +++ b/meta/recipes-devtools/gdb/gdb-common.inc
> @@ -42,6 +42,7 @@ EXTRA_OECONF = "--disable-gdbtk --disable-tui --disable-x --disable-werror \
>                  --with-curses --disable-multilib --with-system-readline --disable-sim \
>                  ${GDBPROPREFIX} ${EXPAT} \
>                  ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
> +		--disable-rpath \

Please don't mix tabs and spaces for indentation.

>                 "
>  
>  GDBPROPREFIX = "--program-prefix=''"
> -- 
> 1.7.10.4
> 
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/gdb/gdb-common.inc b/meta/recipes-devtools/gdb/gdb-common.inc
index 9eb6b60..0e542d8 100644
--- a/meta/recipes-devtools/gdb/gdb-common.inc
+++ b/meta/recipes-devtools/gdb/gdb-common.inc
@@ -42,6 +42,7 @@  EXTRA_OECONF = "--disable-gdbtk --disable-tui --disable-x --disable-werror \
                 --with-curses --disable-multilib --with-system-readline --disable-sim \
                 ${GDBPROPREFIX} ${EXPAT} \
                 ${@base_contains('DISTRO_FEATURES', 'multiarch', '--enable-64-bit-bfd', '', d)} \
+		--disable-rpath \
                "
 
 GDBPROPREFIX = "--program-prefix=''"