Patchwork sstate: Set umask to 002 before packaging runs

login
register
mail settings
Submitter Phil Blundell
Date April 24, 2013, 12:07 p.m.
Message ID <1366805267.14512.29.camel@phil-desktop.brightsign>
Download mbox | patch
Permalink /patch/48731/
State Accepted
Commit d8c4f442c41bf3ac5e064630657cd3fa1b5c43b1
Headers show

Comments

Phil Blundell - April 24, 2013, 12:07 p.m.
Otherwise we might end up creating directories under sstate-cache with whatever
random umask has been selected for the task that we're trying to package.  This
would be a bad thing since it might result in losing group write access for
newly created dirs, and/or losing group read access for the sstate files 
themselves.

Signed-off-by: Phil Blundell <philb@gnu.org>
---
 meta/classes/sstate.bbclass |    4 ++++
 1 file changed, 4 insertions(+)

Patch

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index 03f083e..380eb66 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -507,7 +507,11 @@  python sstate_task_postfunc () {
     sstate_install(shared_state, d)
     for intercept in shared_state['interceptfuncs']:
         bb.build.exec_func(intercept, d)
+    omask = os.umask(002)
+    if omask != 002:
+       bb.note("Using umask 002 (not %0o) for sstate packaging" % omask)
     sstate_package(shared_state, d)
+    os.umask(omask)
 }