Patchwork support for more kernel image types than just only uImage

login
register
mail settings
Submitter Silvio
Date April 23, 2013, 12:42 p.m.
Message ID <20130423124257.GB27202@sfrouter>
Download mbox | patch
Permalink /patch/48689/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Silvio - April 23, 2013, 12:42 p.m.
---
 classes/image_types_fsl.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
1.8.2.1
Daiane Angolini - April 23, 2013, 12:47 p.m.
On 04/23/2013 09:42 AM, Silvio wrote:
> ---
>   classes/image_types_fsl.bbclass | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Beautiful!

I believe it will work for linux-fslc as well, but, did you tested it?

Which board did you used to test it?
Silvio - April 23, 2013, 12:50 p.m.
Hi,

sorry for no text in the last mail. Please review and/or apply


Cheers,
Silvio


> ---
>  classes/image_types_fsl.bbclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
> index b803aef..b894495 100644
> --- a/classes/image_types_fsl.bbclass
> +++ b/classes/image_types_fsl.bbclass
> @@ -118,7 +118,7 @@ generate_imx_sdcard () {
>         BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDCARD} unit b print \
>                           | awk '/ 1 / { print substr($4, 1, length($4 -1)) / 1024 }')
>         mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
> -       mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/uImage-${MACHINE}.bin ::/uImage
> +       mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}
> 
>         # Copy boot scripts
>         for item in ${BOOT_SCRIPTS}; do
> @@ -221,7 +221,7 @@ generate_mxs_sdcard () {
>                 | awk '/ 2 / { print substr($4, 1, length($4 -1)) / 1024 }')
> 
>                 mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
> -               mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/uImage-${MACHINE}.bin ::/uImage
> +               mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}
>                 if test -n "${KERNEL_DEVICETREE}"; then
>                         for DTS_FILE in ${KERNEL_DEVICETREE}; do
>                                 DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`
> --
> 1.8.2.1
> 
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
Silvio - April 23, 2013, 12:55 p.m.
> Beautiful!
> 
> I believe it will work for linux-fslc as well, but, did you tested it?
> 
> Which board did you used to test it?

I have test it on a 3rd party board, based on a own machine.conf. But on a
sabrelite it works.

Bye,
Silvio
Daiane Angolini - April 23, 2013, 1:06 p.m.
On 04/23/2013 09:55 AM, Silvio F. wrote:
>
>> Beautiful!
>>
>> I believe it will work for linux-fslc as well, but, did you tested it?
>>
>> Which board did you used to test it?
>
> I have test it on a 3rd party board, based on a own machine.conf. But on a
> sabrelite it works.

OK.

I can test it for imx28evk
Daiane Angolini - April 23, 2013, 3:57 p.m.
On 04/23/2013 09:55 AM, Silvio F. wrote:
>
>> Beautiful!
>>
>> I believe it will work for linux-fslc as well, but, did you tested it?
>>
>> Which board did you used to test it?
>
> I have test it on a 3rd party board, based on a own machine.conf. But on a
> sabrelite it works.
>

Could you, please, resend your patch using git send email?

https://github.com/Freescale/fsl-community-bsp-platform

Please, base your changes on master. And make sure your patch is applicable.

When you send v2 I test it for imx28evk.
Otavio Salvador - April 23, 2013, 5:33 p.m.
On Tue, Apr 23, 2013 at 12:57 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/23/2013 09:55 AM, Silvio F. wrote:
>>
>>
>>> Beautiful!
>>>
>>> I believe it will work for linux-fslc as well, but, did you tested it?
>>>
>>> Which board did you used to test it?
>>
>>
>> I have test it on a 3rd party board, based on a own machine.conf. But on a
>> sabrelite it works.
>>
>
> Could you, please, resend your patch using git send email?
>
> https://github.com/Freescale/fsl-community-bsp-platform
>
> Please, base your changes on master. And make sure your patch is applicable.
>
> When you send v2 I test it for imx28evk.

And please follow the Yocto commit message style:

https://wiki.yoctoproject.org/wiki/Contribution_Guidelines#Patch_Headers_and_Commit_Messages

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
index b803aef..b894495 100644
--- a/classes/image_types_fsl.bbclass
+++ b/classes/image_types_fsl.bbclass
@@ -118,7 +118,7 @@  generate_imx_sdcard () {
        BOOT_BLOCKS=$(LC_ALL=C parted -s ${SDCARD} unit b print \
                          | awk '/ 1 / { print substr($4, 1, length($4 -1)) / 1024 }')
        mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
-       mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/uImage-${MACHINE}.bin ::/uImage
+       mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}

        # Copy boot scripts
        for item in ${BOOT_SCRIPTS}; do
@@ -221,7 +221,7 @@  generate_mxs_sdcard () {
                | awk '/ 2 / { print substr($4, 1, length($4 -1)) / 1024 }')

                mkfs.vfat -n "${BOOTDD_VOLUME_ID}" -S 512 -C ${WORKDIR}/boot.img $BOOT_BLOCKS
-               mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/uImage-${MACHINE}.bin ::/uImage
+               mcopy -i ${WORKDIR}/boot.img -s ${DEPLOY_DIR_IMAGE}/${KERNEL_IMAGETYPE}-${MACHINE}.bin ::/${KERNEL_IMAGETYPE}
                if test -n "${KERNEL_DEVICETREE}"; then
                        for DTS_FILE in ${KERNEL_DEVICETREE}; do
                                DTS_BASE_NAME=`basename ${DTS_FILE} | awk -F "." '{print $1}'`