Patchwork [meta-oe] ttf-inconsolata: fix license name

login
register
mail settings
Submitter Paul Barker
Date April 23, 2013, 8:55 a.m.
Message ID <1366707335-53174-1-git-send-email-paul@paulbarker.me.uk>
Download mbox | patch
Permalink /patch/48683/
State Accepted, archived
Commit 4f95cdca5ecf26113c2000f1bef8976df5ac7b07
Headers show

Comments

Paul Barker - April 23, 2013, 8:55 a.m.
We have "SIL Open Font License" 1.1 in common-licenses as OFL-1.1.

Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
---
 meta-oe/recipes-graphics/ttf-fonts/ttf-inconsolata_20100526.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - April 23, 2013, 10:09 a.m.
On Tue, Apr 23, 2013 at 10:00:55AM +0100, Paul Barker wrote:
> On 23 April 2013 09:55, Paul Barker <paul@paulbarker.me.uk> wrote:
> > We have "SIL Open Font License" 1.1 in common-licenses as OFL-1.1.
> >
> 
> There's also a copy of the OFL 1.1 in
> meta-oe/recipes-graphics/ttf-fonts/ttf-inconsolata/OFL.txt as the
> bitbake recipe just downloads a single font file. I don't know how to
> do this as it goes across layers (not sure if relative paths would
> work) but would it be better to replace this with reference to the
> file in common-licenses? I realise this is there to satisfy having
> something in LIC_FILES_CHKSUM but it isn't doing the intended job as
> upstream could update the license and it wouldn't break this checksum.

You can use
LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/OFL-1.1;md5=hash"

it's true, that this does not catch license change in upstream source,
but if there isn't any information about license in SRC_URI, then having
OFL.txt is as bad as ${COMMON_LICENSE_DIR}/OFL-1.1 reference imho.

Cheers,

Patch

diff --git a/meta-oe/recipes-graphics/ttf-fonts/ttf-inconsolata_20100526.bb b/meta-oe/recipes-graphics/ttf-fonts/ttf-inconsolata_20100526.bb
index 129e137..5e86180 100644
--- a/meta-oe/recipes-graphics/ttf-fonts/ttf-inconsolata_20100526.bb
+++ b/meta-oe/recipes-graphics/ttf-fonts/ttf-inconsolata_20100526.bb
@@ -2,7 +2,7 @@  require ttf.inc
 
 DESCRIPTION = "Inconsolata font - TTF Version"
 HOMEPAGE = "http://www.levien.com/type/myfonts/inconsolata.html"
-LICENSE = "SIL Open Font License"
+LICENSE = "OFL-1.1"
 LIC_FILES_CHKSUM = "file://../OFL.txt;md5=969851e3a70122069a4d9ee61dd5a2ed"
 PR = "r0"