Patchwork [meta-fsl-arm] xf86-dri-vivante: add missing dependency on xf86driproto

login
register
mail settings
Submitter Christian Charreyre
Date April 19, 2013, 3:10 p.m.
Message ID <51715E76.7000306@cioinfoindus.fr>
Download mbox | patch
Permalink /patch/48583/
State Rejected
Delegated to: Otavio Salvador
Headers show

Comments

Christian Charreyre - April 19, 2013, 3:10 p.m.
Without this dependency recipe failed to compile (triggered by bitbake 
core-image-x11)


 From 8d371da2536cb985c53908d58a8e68100ed113ba Mon Sep 17 00:00:00 2001
From: Christian Charreyre <christian.charreyre@cioinfoindus.fr>
Date: Fri, 19 Apr 2013 16:41:39 +0200
Subject: [PATCH] xf86-dri-vivante: add missing dependency on xf86driproto

Signed-off-by: Christian Charreyre <christian.charreyre@cioinfoindus.fr>
---
  .../xorg-driver/xf86-dri-vivante_1.1.0.bb          |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

  SRC_URI = "${FSL_MIRROR}/xserver-xorg-video-imx-viv-${PV}.tar.gz \
Otavio Salvador - April 19, 2013, 3:41 p.m.
On Fri, Apr 19, 2013 at 12:10 PM, Christian Charreyre
<christian.charreyre@cioinfoindus.fr> wrote:
> Without this dependency recipe failed to compile (triggered by bitbake
> core-image-x11)

First, thanks for the patch. This explanation would be good to have in
the commit log or something generic if you prefer.

> From 8d371da2536cb985c53908d58a8e68100ed113ba Mon Sep 17 00:00:00 2001
> From: Christian Charreyre <christian.charreyre@cioinfoindus.fr>
> Date: Fri, 19 Apr 2013 16:41:39 +0200
> Subject: [PATCH] xf86-dri-vivante: add missing dependency on xf86driproto
>
> Signed-off-by: Christian Charreyre <christian.charreyre@cioinfoindus.fr>

I am a bit confused as virtual/xserver is provided by xserver-xorg and
this depends on xf86driproto so we'd be safe here.

I started a clean build here to check if I can reproduce it. In any
case, please resend the patch using git send-email so if I can
reproduce it here we can apply it.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Otavio Salvador - April 19, 2013, 6:04 p.m.
On Fri, Apr 19, 2013 at 12:41 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Fri, Apr 19, 2013 at 12:10 PM, Christian Charreyre
> <christian.charreyre@cioinfoindus.fr> wrote:
>> Without this dependency recipe failed to compile (triggered by bitbake
>> core-image-x11)
>
> First, thanks for the patch. This explanation would be good to have in
> the commit log or something generic if you prefer.
>
>> From 8d371da2536cb985c53908d58a8e68100ed113ba Mon Sep 17 00:00:00 2001
>> From: Christian Charreyre <christian.charreyre@cioinfoindus.fr>
>> Date: Fri, 19 Apr 2013 16:41:39 +0200
>> Subject: [PATCH] xf86-dri-vivante: add missing dependency on xf86driproto
>>
>> Signed-off-by: Christian Charreyre <christian.charreyre@cioinfoindus.fr>
>
> I am a bit confused as virtual/xserver is provided by xserver-xorg and
> this depends on xf86driproto so we'd be safe here.
>
> I started a clean build here to check if I can reproduce it. In any
> case, please resend the patch using git send-email so if I can
> reproduce it here we can apply it.

I did a full build from scratch of xf86-dri-vivante (no tmp, no
sstate-cache) and it did work so I think you had other failure.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Christian Charreyre - April 22, 2013, 5:23 p.m.
Le 22/04/2013 15:51, Otavio Salvador a écrit :
> On Mon, Apr 22, 2013 at 10:34 AM, Christian Charreyre
> <christian.charreyre@cioinfoindus.fr> wrote:
>> Le 19/04/2013 20:04, Otavio Salvador a écrit :
>>
>>> On Fri, Apr 19, 2013 at 12:41 PM, Otavio Salvador
>>> <otavio@ossystems.com.br> wrote:
>>>> On Fri, Apr 19, 2013 at 12:10 PM, Christian Charreyre
>>>> <christian.charreyre@cioinfoindus.fr> wrote:
>>>>> Without this dependency recipe failed to compile (triggered by bitbake
>>>>> core-image-x11)
>>>> First, thanks for the patch. This explanation would be good to have in
>>>> the commit log or something generic if you prefer.
>> Sorry for the bad format, it's my first send, and I didn't find an
>> explanation on the good practices for patch submission. Is there one
>> anywhere ?
> https://wiki.yoctoproject.org/wiki/Contribution_Guidelines#Patch_Headers_and_Commit_Messages
>
> But the change does seem not required. I did a full build without it
> and had no issues.
Thanks for the pointer. I do understand that this patch was not necessary.
>
>>> I did a full build from scratch of xf86-dri-vivante (no tmp, no
>>> sstate-cache) and it did work so I think you had other failure.
>> With the patch I succedeed to build xf86-dri-vivante, but I have another
>> problem when building complete image (do_rootfs).
>> After more investigation, it seems that the problem is in DISTRO_FEATURES.
>> As I have not specified DISTRO_FEATURES in my local.conf, and uses the very
>> neutral one from openembedded-core, I do not have glx in my distro features.
>> I will try to add x11 and glx in DISTRO_FEATURES, and report then what
>> happens.
> I've been building using Poky, not OE-Core. If you find out how to
> reproduce the issue let me know and I can check it as well.
Question : do you work with a yocto base, or do you use a poky config on an
openembedded-core base ?

I've first tried generating meta-fsl-arm over yocto (danny), but I got 
errors
(versionning problem between components I guess), so I read the README
of the layer  meta-fsl-arm, and it tells that it depends only on :

openembedded-core
branch master
revision HEAD,

not yocto, so this is the reason why I swapped to OE-core, but I think 
OE-core
is too distribution agnostic for core-x11-image.


>
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
>
Otavio Salvador - April 22, 2013, 5:26 p.m.
On Mon, Apr 22, 2013 at 2:23 PM, Christian Charreyre
<christian.charreyre@cioinfoindus.fr> wrote:
> Le 22/04/2013 15:51, Otavio Salvador a écrit :
>
>> On Mon, Apr 22, 2013 at 10:34 AM, Christian Charreyre
>> I've been building using Poky, not OE-Core. If you find out how to
>> reproduce the issue let me know and I can check it as well.
>
> Question : do you work with a yocto base, or do you use a poky config on an
> openembedded-core base ?
>
> I've first tried generating meta-fsl-arm over yocto (danny), but I got
> errors
> (versionning problem between components I guess), so I read the README
> of the layer  meta-fsl-arm, and it tells that it depends only on :
>
> openembedded-core
> branch master
> revision HEAD,
>
> not yocto, so this is the reason why I swapped to OE-core, but I think
> OE-core
> is too distribution agnostic for core-x11-image.

I usually work on Poky but it depends on the project. The README could
have some love to be clear about it (patches welcome) but you should
be able to run it with oe-core and poky.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb 
b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
index aa2361a..3299955 100644
--- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
@@ -4,7 +4,7 @@ 

  LICENSE = "MIT"
  SECTION = "x11/base"
-DEPENDS = "virtual/xserver xf86-video-imxfb-vivante"
+DEPENDS = "virtual/xserver xf86-video-imxfb-vivante xf86driproto"
  LIC_FILES_CHKSUM = 
"file://src/dri.h;enline=27;md5=1d0d59e1dc96f5197ea3a8b101bf1fcc"