Patchwork user layer problem with udev_173.bbappend

login
register
mail settings
Submitter Lewis, Nick
Date April 19, 2013, 1:11 p.m.
Message ID <AAE0766F5AF36B46BAB7E0EFB927320630E4A540B4@GBTWK10E001.Technology.local>
Download mbox | patch
Permalink /patch/48573/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Lewis, Nick - April 19, 2013, 1:11 p.m.
>Wrong.
>...
>So please fix this.
As a git newbie I appreciate your helpful (if somewhat curt) advice. I hope I have got the hang of it now

>Bad; the disclaimer is still here.
I will apply for an exemption from the corporate prohibition on the use of webmail but unless and until then I regret that the disclaimer will appear



From 9570505b16d11ed194b6b4f90a018fd488330bce Mon Sep 17 00:00:00 2001
From: Nick Lewis <nick.lewis@usa.g4s.com>
Date: Wed, 17 Apr 2013 05:55:05 -0700
Subject: [PATCH] udev: Replaced _prepend operator in SRC_URI

The use of the _prepend and _append operators adversely affects layering by impeding the ability to override its action in another layer. The operators += .= =+ =. do not cause such problems. The _prepend operator is therefore replaced by the =+ operator which also tidies trailing space in the string

Signed-off-by: Nick Lewis <nick.lewis@usa.g4s.com>
---
 recipes-core/udev/udev_173.bbappend |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.7.9.5



--
Nick

The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.
Otavio Salvador - April 19, 2013, 1:21 p.m.
On Fri, Apr 19, 2013 at 10:11 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
>>Wrong.
>>...
>>So please fix this.
> As a git newbie I appreciate your helpful (if somewhat curt) advice. I hope I have got the hang of it now

:-)

>>Bad; the disclaimer is still here.
> I will apply for an exemption from the corporate prohibition on the use of webmail but unless and until then I regret that the disclaimer will appear

Thanks.

> From 9570505b16d11ed194b6b4f90a018fd488330bce Mon Sep 17 00:00:00 2001
> From: Nick Lewis <nick.lewis@usa.g4s.com>
> Date: Wed, 17 Apr 2013 05:55:05 -0700
> Subject: [PATCH] udev: Replaced _prepend operator in SRC_URI
>
> The use of the _prepend and _append operators adversely affects layering by impeding the ability to override its action in another layer. The operators += .= =+ =. do not cause such problems. The _prepend operator is therefore replaced by the =+ operator which also tidies trailing space in the string

Much better. Just a minor issue, please split lines in 80cols.

> Signed-off-by: Nick Lewis <nick.lewis@usa.g4s.com>

I cannot pick the patch from an e-mail so please make the split of
lines and send it attached, until you fix your e-mail setting, so I
can apply it.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-core/udev/udev_173.bbappend b/recipes-core/udev/udev_173.bbappend
index 29b20bd..cc80400 100644
--- a/recipes-core/udev/udev_173.bbappend
+++ b/recipes-core/udev/udev_173.bbappend
@@ -4,5 +4,5 @@  PRINC := "${@int(PRINC) + 2}"
 # 173 tag
 SRCREV = "ad667dff51711fed763a23283d973486de3cd6b5"
 SRC_URI := "${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2', '${SRC_URI}', d)}"
-SRC_URI_prepend = "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git "
+SRC_URI =+ "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git"
 S = "${WORKDIR}/git"