Patchwork user layer problem with udev_173.bbappend

login
register
mail settings
Submitter Lewis, Nick
Date April 19, 2013, 8:54 a.m.
Message ID <AAE0766F5AF36B46BAB7E0EFB927320630E4A540B3@GBTWK10E001.Technology.local>
Download mbox | patch
Permalink /patch/48555/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Lewis, Nick - April 19, 2013, 8:54 a.m.
>The patch:
>
> * lacks author
> * lacks autor e-mail
> * lacks commit log
> * lacks Signed-off-by
>
>The change is right but the information in the patch is not.

Here is the output from "git format-patch -s1 HEAD" after adding my details to "git config":

From 0f99f71ece252a6c89bd366b5e7f3f6e7de7c3c6 Mon Sep 17 00:00:00 2001
From: Nick Lewis <nick.lewis@usa.g4s.com>
Date: Wed, 17 Apr 2013 01:56:18 -0700
Subject: [PATCH] replace _prepend operator


Signed-off-by: Nick Lewis <nick.lewis@usa.g4s.com>
---
 recipes-core/udev/udev_173.bbappend |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
1.7.9.5

--
Nick

The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.
Otavio Salvador - April 19, 2013, 11:57 a.m.
On Fri, Apr 19, 2013 at 5:54 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
>>The patch:
>>
>> * lacks author
>> * lacks autor e-mail
>> * lacks commit log
>> * lacks Signed-off-by
>>
>>The change is right but the information in the patch is not.
>
> Here is the output from "git format-patch -s1 HEAD" after adding my details to "git config":
>
> From 0f99f71ece252a6c89bd366b5e7f3f6e7de7c3c6 Mon Sep 17 00:00:00 2001
> From: Nick Lewis <nick.lewis@usa.g4s.com>

Good.

> Date: Wed, 17 Apr 2013 01:56:18 -0700
> Subject: [PATCH] replace _prepend operator
>

Wrong.

The commit log needs to explain why you did it and what it affects so
something like:

---
udev: Avoid using _prepend operator for SRC_URI

Using _prepend makes override in another layer harder so we replace it
by '=+' operator.
---

So please fix this. You can use the suggested commit log as base but
you can change it as you wish ... but please make it as complete as
possible.

> Signed-off-by: Nick Lewis <nick.lewis@usa.g4s.com>

Good.

> The details of this company are as follows:
> G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.
>
> This communication may contain information which is confidential, personal and/or privileged.
>
> It is for the exclusive use of the intended recipient(s).
> If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.
>
> Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.
>
> Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.
>
> This e-mail has been scanned for all viruses by MessageLabs.

Bad; the disclaimer is still here.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-core/udev/udev_173.bbappend b/recipes-core/udev/udev_173.bbappend
index 29b20bd..cc80400 100644
--- a/recipes-core/udev/udev_173.bbappend
+++ b/recipes-core/udev/udev_173.bbappend
@@ -4,5 +4,5 @@  PRINC := "${@int(PRINC) + 2}"
 # 173 tag
 SRCREV = "ad667dff51711fed763a23283d973486de3cd6b5"
 SRC_URI := "${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2', '${SRC_URI}', d)}"
-SRC_URI_prepend = "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git "
+SRC_URI =+ "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git"
 S = "${WORKDIR}/git"