Patchwork [meta-fsl-arm,3/3] linux-fslc: Use KERNEL_EXTRA_ARGS instead of EXTRA_OEMAKE

login
register
mail settings
Submitter Otavio Salvador
Date April 18, 2013, 1:12 p.m.
Message ID <1366290728-14103-3-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/48485/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 18, 2013, 1:12 p.m.
The use of EXTRA_OEMAKE is not the best variable to be used here so we
should use KERNEL_EXTRA_ARGS instead.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-kernel/linux/linux-fslc_3.8.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Fabio Estevam - April 18, 2013, 3:42 p.m.
On Thu, Apr 18, 2013 at 10:12 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:

>  # We need to pass it as param since kernel might support more then one
>  # machine, with different entry points
> -EXTRA_OEMAKE += "LOADADDR=${UBOOT_ENTRYPOINT}"
> +KERNEL_EXTRA_ARGS += "LOADADDR=${UBOOT_ENTRYPOINT}"

Can't we put KERNEL_EXTRA_ARGS into a more common location?

In 2/3 you placed it in linux-imx.inc, which covers 2.6.35/3.0.35
kernels, but I am was wondering if you could make this applied for all
the kernels generated by meta-fsl-arm.

This way we do not have to add this entry to every newer version of
the kernel recipes.

For example, when linux-fslc_3.9.bb comes out we can rely on
KERNEL_EXTRA_ARGS being set on a common location, instead of having to
add it inside linux-fslc_3.9.bb.
Daiane Angolini - April 18, 2013, 4:23 p.m.
On 04/18/2013 12:42 PM, Fabio Estevam wrote:
> On Thu, Apr 18, 2013 at 10:12 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>
>>   # We need to pass it as param since kernel might support more then one
>>   # machine, with different entry points
>> -EXTRA_OEMAKE += "LOADADDR=${UBOOT_ENTRYPOINT}"
>> +KERNEL_EXTRA_ARGS += "LOADADDR=${UBOOT_ENTRYPOINT}"
>
> Can't we put KERNEL_EXTRA_ARGS into a more common location?
>
> In 2/3 you placed it in linux-imx.inc, which covers 2.6.35/3.0.35
> kernels, but I am was wondering if you could make this applied for all
> the kernels generated by meta-fsl-arm.

Maybe POKY layer.

I'm not complete happy this is being handling by meta-fsl-arm
Otavio Salvador - April 18, 2013, 4:33 p.m.
On Thu, Apr 18, 2013 at 1:23 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/18/2013 12:42 PM, Fabio Estevam wrote:
>>
>> On Thu, Apr 18, 2013 at 10:12 AM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>
>>>   # We need to pass it as param since kernel might support more then one
>>>   # machine, with different entry points
>>> -EXTRA_OEMAKE += "LOADADDR=${UBOOT_ENTRYPOINT}"
>>> +KERNEL_EXTRA_ARGS += "LOADADDR=${UBOOT_ENTRYPOINT}"
>>
>>
>> Can't we put KERNEL_EXTRA_ARGS into a more common location?
>>
>> In 2/3 you placed it in linux-imx.inc, which covers 2.6.35/3.0.35
>> kernels, but I am was wondering if you could make this applied for all
>> the kernels generated by meta-fsl-arm.
>
>
> Maybe POKY layer.
>
> I'm not complete happy this is being handling by meta-fsl-arm

I will propose a v2 for this patchset ... and reuse linux-imx.inc

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-kernel/linux/linux-fslc_3.8.bb b/recipes-kernel/linux/linux-fslc_3.8.bb
index 06f6dfb..d989e6d 100644
--- a/recipes-kernel/linux/linux-fslc_3.8.bb
+++ b/recipes-kernel/linux/linux-fslc_3.8.bb
@@ -30,6 +30,6 @@  do_configure_append () {
 
 # We need to pass it as param since kernel might support more then one
 # machine, with different entry points
-EXTRA_OEMAKE += "LOADADDR=${UBOOT_ENTRYPOINT}"
+KERNEL_EXTRA_ARGS += "LOADADDR=${UBOOT_ENTRYPOINT}"
 
 COMPATIBLE_MACHINE = "(mxs|mx3|mx5|mx6)"