Patchwork [meta-fsl-ppc] xserver-xf86-config_0.1.bbappend: PR_fsl instead of PR

login
register
mail settings
Submitter chunrong guo
Date April 18, 2013, 10:06 a.m.
Message ID <1366279568-21251-1-git-send-email-b40290@freescale.com>
Download mbox | patch
Permalink /patch/48475/
State Rejected
Headers show

Comments

chunrong guo - April 18, 2013, 10:06 a.m.
From: Chunrong Guo <B40290@freescale.com>

      Fix issue was "Release" points to an invalid value

Signed-off-by: Chunrong Guo <B40290@freescale.com>
---
 .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Otavio Salvador - April 18, 2013, 12:24 p.m.
On Thu, Apr 18, 2013 at 7:06 AM,  <b40290@freescale.com> wrote:
> From: Chunrong Guo <B40290@freescale.com>
>
>       Fix issue was "Release" points to an invalid value
>
> Signed-off-by: Chunrong Guo <B40290@freescale.com>
> ---
>  .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> index 0291bb7..b247a5b 100644
> --- a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> +++ b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> @@ -1,3 +1,3 @@
>  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> -PR .= "+${DISTRO}"
> +PR_fsl .= "+${DISTRO}"

You shouldn't use the distro here. Drop this override and use PRINC.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Zhenhua Luo - April 18, 2013, 12:59 p.m.
Agree, the DISTRO reference in PR of other bbappend files should be changed to PRINC way. 


Best Regards,

Zhenhua


> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Otavio Salvador
> Sent: Thursday, April 18, 2013 8:24 PM
> To: Guo Chunrong-B40290
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH] xserver-xf86-
> config_0.1.bbappend: PR_fsl instead of PR
> 
> On Thu, Apr 18, 2013 at 7:06 AM,  <b40290@freescale.com> wrote:
> > From: Chunrong Guo <B40290@freescale.com>
> >
> >       Fix issue was "Release" points to an invalid value
> >
> > Signed-off-by: Chunrong Guo <B40290@freescale.com>
> > ---
> >  .../xorg-xserver/xserver-xf86-config_0.1.bbappend  |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/recipes-graphics/xorg-xserver/xserver-xf86-
> config_0.1.bbappend b/recipes-graphics/xorg-xserver/xserver-xf86-
> config_0.1.bbappend
> > index 0291bb7..b247a5b 100644
> > --- a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> > +++ b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
> > @@ -1,3 +1,3 @@
> >  FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> > -PR .= "+${DISTRO}"
> > +PR_fsl .= "+${DISTRO}"
> 
> You shouldn't use the distro here. Drop this override and use PRINC.
> 
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Patch

diff --git a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
index 0291bb7..b247a5b 100644
--- a/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
+++ b/recipes-graphics/xorg-xserver/xserver-xf86-config_0.1.bbappend
@@ -1,3 +1,3 @@ 
 FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
 
-PR .= "+${DISTRO}"
+PR_fsl .= "+${DISTRO}"