Patchwork [meta-oe] net-snmp: add -systemd packages to PACKAGES list to appease systemd.bbclass

login
register
mail settings
Submitter ml@communistcode.co.uk
Date April 17, 2013, 1:57 p.m.
Message ID <1366207065-3413-1-git-send-email-ml@communistcode.co.uk>
Download mbox | patch
Permalink /patch/48441/
State Superseded
Headers show

Comments

ml@communistcode.co.uk - April 17, 2013, 1:57 p.m.
From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>

ERROR: net-snmp-server-snmpd-systemd does not appear in package list, please add it
ERROR: net-snmp-server-snmptrapd-systemd does not appear in package list, please add it

Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
---
 meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Martin Jansa - April 17, 2013, 2:53 p.m.
On Wed, Apr 17, 2013 at 02:57:45PM +0100, Jack Mitchell wrote:
> From: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> 
> ERROR: net-snmp-server-snmpd-systemd does not appear in package list, please add it
> ERROR: net-snmp-server-snmptrapd-systemd does not appear in package list, please add it
> 
> Signed-off-by: Jack Mitchell <jack.mitchell@dbbroadcast.co.uk>
> ---
>  meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb b/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb
> index 81ad6ff..1e1db6a 100644
> --- a/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb
> +++ b/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb
> @@ -61,7 +61,11 @@ do_install_append() {
>  }
>  
>  PACKAGES = "${PN}-dbg ${PN}-doc ${PN}-dev ${PN}-staticdev ${PN}-static ${PN}-libs \
> -            ${PN}-mibs ${PN}-server ${PN}-client ${PN}-server-snmpd ${PN}-server-snmptrapd"
> +            ${PN}-mibs ${PN}-server ${PN}-client ${PN}-server-snmpd ${PN}-server-snmptrapd \
> +            ${PN}-server-snmpd-systemd ${PN}-server-snmptrapd-systemd "
> +
> +SYSTEMD_PACKAGES = "${PN}-server-snmpd-systemd \
> +                    ${PN}-server-snmptrapd-systemd"

It should be changed to
SYSTEMD_PACKAGES = "${PN}-server-snmpd \
                    ${PN}-server-snmptrapd"
At least to match SYSTEMD_SERVICE, not sure how have we missed that.

>  ALLOW_EMPTY_${PN}-server = "1"
>  
> @@ -91,9 +95,6 @@ INITSCRIPT_PARAMS_${PN}-server = "defaults"
>  
>  EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemd', '--without-systemd', d)}"
>  
> -SYSTEMD_PACKAGES = "${PN}-server-snmpd-systemd \
> -                    ${PN}-server-snmptrapd-systemd"
> -
>  SYSTEMD_SERVICE_${PN}-server-snmpd = "snmpd.service"
>  SYSTEMD_SERVICE_${PN}-server-snmptrapd =  "snmptrapd.service"
>  
> -- 
> 1.8.2
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb b/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb
index 81ad6ff..1e1db6a 100644
--- a/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb
+++ b/meta-oe/recipes-extended/net-snmp/net-snmp_5.7.2.bb
@@ -61,7 +61,11 @@  do_install_append() {
 }
 
 PACKAGES = "${PN}-dbg ${PN}-doc ${PN}-dev ${PN}-staticdev ${PN}-static ${PN}-libs \
-            ${PN}-mibs ${PN}-server ${PN}-client ${PN}-server-snmpd ${PN}-server-snmptrapd"
+            ${PN}-mibs ${PN}-server ${PN}-client ${PN}-server-snmpd ${PN}-server-snmptrapd \
+            ${PN}-server-snmpd-systemd ${PN}-server-snmptrapd-systemd "
+
+SYSTEMD_PACKAGES = "${PN}-server-snmpd-systemd \
+                    ${PN}-server-snmptrapd-systemd"
 
 ALLOW_EMPTY_${PN}-server = "1"
 
@@ -91,9 +95,6 @@  INITSCRIPT_PARAMS_${PN}-server = "defaults"
 
 EXTRA_OECONF += "${@base_contains('DISTRO_FEATURES', 'systemd', '--with-systemd', '--without-systemd', d)}"
 
-SYSTEMD_PACKAGES = "${PN}-server-snmpd-systemd \
-                    ${PN}-server-snmptrapd-systemd"
-
 SYSTEMD_SERVICE_${PN}-server-snmpd = "snmpd.service"
 SYSTEMD_SERVICE_${PN}-server-snmptrapd =  "snmptrapd.service"