Patchwork Patch - udev_173.bbappend

login
register
mail settings
Submitter Lewis, Nick
Date April 17, 2013, 1:18 p.m.
Message ID <AAE0766F5AF36B46BAB7E0EFB927320630E4A540AA@GBTWK10E001.Technology.local>
Download mbox | patch
Permalink /patch/48429/
State Not Applicable
Delegated to: Otavio Salvador
Headers show

Comments

Lewis, Nick - April 17, 2013, 1:18 p.m.
Otavio

May I please request the following patch. It has two purposes - it changes the protocol used by the git fetcher to use the universally available http protocol
and it removes the use of SRC_URI_prepend which is problematic for user layers on top of meta-fsl-arm:




--
Nick

The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.
Otavio Salvador - April 17, 2013, 2:10 p.m.
On Wed, Apr 17, 2013 at 10:18 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
> Otavio
>
> May I please request the following patch. It has two purposes - it changes the protocol used by the git fetcher to use the universally available http protocol

I understand but other recipes also use git:// protocol so this
wouldn't fix it for others. And in fact it is not really a problem but
a network issue.

How you fixed it for the other recipes?

> and it removes the use of SRC_URI_prepend which is problematic for user layers on top of meta-fsl-arm:

What problem you had with the prepend?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Lewis, Nick - April 17, 2013, 3:13 p.m.
>> Otavio
>>
>> May I please request the following patch. It has two purposes - it
>> changes the protocol used by the git fetcher to use the universally
>> available http protocol
>
>I understand but other recipes also use git:// protocol so this wouldn't fix it for others.
>And in fact it is not really a problem but a network issue.
>
>How you fixed it for the other recipes?
>
There are only two other fsl-image-test recipes that fetch from a git repository with the git protocol so at the user layer I do:

$ cat meta-nick/recipes-multimedia/v4l-apps/v4l-utils_0.8.8.bbappend
PRINC := "${@int(PRINC)+1}"
SRC_URI := "${@oe_filter_out('git://linuxtv.org/v4l-utils.git;protocol=git', '${SRC_URI}', d)}"
SRC_URI =+ "git://linuxtv.org/git/v4l-utils.git;protocol=http"

$ cat meta-nick/recipes-benchmark/fio/fio_2.0.5.bbappend
PRINC := "${@int(PRINC)+1}"
SRC_URI .= ";protocol=http"
nicklewis@ubuntu:/data/yocto/rootfs_builder/sources$

>> and it removes the use of SRC_URI_prepend which is problematic for user layers on top of meta-fsl-arm:
>
>What problem you had with the prepend?
>

The problem is the way in which _prepend operates as opposed to =. or =+ (ditto _append vs .= or +=)
The _prepend mechanism operates *whenever* there is an assignment to the variable so a high priority layer that wishes to change the value of the variable is still affected by a _prepend from a lower priority layer. There is apparently no way to _unprepend what a previous layer has _prepended

example:

# fsl layer priority 5
SRC_URI = "fsl-selected-uri"
SRC_URI_prepend = "fsl-selected-prefix "

# user layer priority 6 appended afterwards
SRC_URI_prepend = ""
SRC_URI = "user-selected-uri"

bitbake -e shows SRC_URI is unhelpfully set to "fsl-selected-prefix user-selected-uri"

--
Nick

The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.
Otavio Salvador - April 17, 2013, 5:33 p.m.
On Wed, Apr 17, 2013 at 12:13 PM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
>>> Otavio
>>>
>>> May I please request the following patch. It has two purposes - it
>>> changes the protocol used by the git fetcher to use the universally
>>> available http protocol
>>
>>I understand but other recipes also use git:// protocol so this wouldn't fix it for others.
>>And in fact it is not really a problem but a network issue.
>>
>>How you fixed it for the other recipes?
>>
> There are only two other fsl-image-test recipes that fetch from a git repository with the git protocol so at the user layer I do:
>
> $ cat meta-nick/recipes-multimedia/v4l-apps/v4l-utils_0.8.8.bbappend
> PRINC := "${@int(PRINC)+1}"
> SRC_URI := "${@oe_filter_out('git://linuxtv.org/v4l-utils.git;protocol=git', '${SRC_URI}', d)}"
> SRC_URI =+ "git://linuxtv.org/git/v4l-utils.git;protocol=http"
>
> $ cat meta-nick/recipes-benchmark/fio/fio_2.0.5.bbappend
> PRINC := "${@int(PRINC)+1}"
> SRC_URI .= ";protocol=http"
> nicklewis@ubuntu:/data/yocto/rootfs_builder/sources$

Yes but you're fixing the 'consequence', not the 'cause'. You do need
to fix your network so you can fetch from GIT.

I am sure you looked at the documentation for Yocto project but for
the others who didn't, here goes a

http://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#how-does-the-yocto-project-obtain-source-code-and-will-it-work-behind-my-firewall-or-proxy-server



>>> and it removes the use of SRC_URI_prepend which is problematic for user layers on top of meta-fsl-arm:
>>
>>What problem you had with the prepend?
>>
>
> The problem is the way in which _prepend operates as opposed to =. or =+ (ditto _append vs .= or +=)
> The _prepend mechanism operates *whenever* there is an assignment to the variable so a high priority layer that wishes to change the value of the variable is still affected by a _prepend from a lower priority layer. There is apparently no way to _unprepend what a previous layer has _prepended
>
> example:
>
> # fsl layer priority 5
> SRC_URI = "fsl-selected-uri"
> SRC_URI_prepend = "fsl-selected-prefix "
>
> # user layer priority 6 appended afterwards
> SRC_URI_prepend = ""
> SRC_URI = "user-selected-uri"
>
> bitbake -e shows SRC_URI is unhelpfully set to "fsl-selected-prefix user-selected-uri"
>
> --
> Nick
>
> The details of this company are as follows:
> G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.
>
> This communication may contain information which is confidential, personal and/or privileged.
>
> It is for the exclusive use of the intended recipient(s).
> If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.
>
> Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.
>
> Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.
>
> This e-mail has been scanned for all viruses by MessageLabs.



--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Otavio Salvador - April 17, 2013, 5:35 p.m.
On Wed, Apr 17, 2013 at 2:33 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Wed, Apr 17, 2013 at 12:13 PM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
>>>> Otavio
>>>>
>>>> May I please request the following patch. It has two purposes - it
>>>> changes the protocol used by the git fetcher to use the universally
>>>> available http protocol
>>>
>>>I understand but other recipes also use git:// protocol so this wouldn't fix it for others.
>>>And in fact it is not really a problem but a network issue.
>>>
>>>How you fixed it for the other recipes?
>>>
>> There are only two other fsl-image-test recipes that fetch from a git repository with the git protocol so at the user layer I do:
>>
>> $ cat meta-nick/recipes-multimedia/v4l-apps/v4l-utils_0.8.8.bbappend
>> PRINC := "${@int(PRINC)+1}"
>> SRC_URI := "${@oe_filter_out('git://linuxtv.org/v4l-utils.git;protocol=git', '${SRC_URI}', d)}"
>> SRC_URI =+ "git://linuxtv.org/git/v4l-utils.git;protocol=http"
>>
>> $ cat meta-nick/recipes-benchmark/fio/fio_2.0.5.bbappend
>> PRINC := "${@int(PRINC)+1}"
>> SRC_URI .= ";protocol=http"
>> nicklewis@ubuntu:/data/yocto/rootfs_builder/sources$
>
> Yes but you're fixing the 'consequence', not the 'cause'. You do need
> to fix your network so you can fetch from GIT.
>
> I am sure you looked at the documentation for Yocto project but for
> the others who didn't, here goes a
>
> http://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#how-does-the-yocto-project-obtain-source-code-and-will-it-work-behind-my-firewall-or-proxy-server

Too early 'send button' press ...

Besides the link above, the 'site.conf.sample has also:

# To use git with a proxy, you must use an external git proxy command, such as
# the one provided by scripts/oe-git-proxy.sh. To use this script, copy it to
# your PATH and uncomment the following:
#GIT_PROXY_COMMAND="oe-git-proxy"
#ALL_PROXY="socks://socks.example.com:1080"
#or
#ALL_PROXY="https://proxy.example.com:8080"
# If you wish to use certain hosts without the proxy, specify them in NO_PROXY.
# See the script for details on syntax.

So you can stop overriding the server :-)

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-core/udev/udev_173.bbappend b/recipes-core/udev/udev_173.bbappend
index 29b20bd..23510b7 100644
--- a/recipes-core/udev/udev_173.bbappend
+++ b/recipes-core/udev/udev_173.bbappend
@@ -4,5 +4,5 @@  PRINC := "${@int(PRINC) + 2}"
 # 173 tag
 SRCREV = "ad667dff51711fed763a23283d973486de3cd6b5"
 SRC_URI := "${@oe_filter_out('${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.bz2', '${SRC_URI}', d)}"
-SRC_URI_prepend = "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=git "
+SRC_URI =+ "git://git.kernel.org/pub/scm/linux/hotplug/udev.git;protocol=http"
 S = "${WORKDIR}/git"