Patchwork seperatebuilddir.inc: disable seperate build dir for consolekit

login
register
mail settings
Submitter Koen Kooi
Date April 16, 2013, 11:49 a.m.
Message ID <1366112971-3644-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/48329/
State New
Headers show

Comments

Koen Kooi - April 16, 2013, 11:49 a.m.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/conf/distro/include/seperatebuilddir.inc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Richard Purdie - April 16, 2013, 3:53 p.m.
On Tue, 2013-04-16 at 13:49 +0200, Koen Kooi wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/conf/distro/include/seperatebuilddir.inc | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/conf/distro/include/seperatebuilddir.inc b/meta/conf/distro/include/seperatebuilddir.inc
> index a9ca240..f60dc5c 100644
> --- a/meta/conf/distro/include/seperatebuilddir.inc
> +++ b/meta/conf/distro/include/seperatebuilddir.inc
> @@ -78,7 +78,9 @@ B_pn-compositeproto = "${SEPB}"
>  B_pn-compositeproto-native = "${SEPB}"
>  #B_pn-connman = "${SEPB}"
>  #B_pn-connman-gnome = "${SEPB}"
> -B_pn-consolekit = "${SEPB}"
> +#B_pn-consolekit = "${SEPB}"
> +#| /build/setup-scripts/build/tmp-angstrom_next-eglibc/work/cortexa8hf-vfp-neon-angstrom-linux-gnueabi/consolekit/0.4.5-r10/ConsoleKit-0.4.5/pam-ck-connector/pam-ck-connector.c:64:26: fatal error: ck-connector.h: No such file or directory
> +#| compilation terminated.
>  B_pn-console-tools = "${SEPB}"
>  B_pn-coreutils = "${SEPB}"
>  B_pn-coreutils-native = "${SEPB}"

Neither my local builds or the autobuilder see this. Any idea why some
builds would fail and others would work?

Cheers,

Richard
Koen Kooi - April 16, 2013, 4:29 p.m.
Op 16 apr. 2013, om 17:53 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:

> On Tue, 2013-04-16 at 13:49 +0200, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> meta/conf/distro/include/seperatebuilddir.inc | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/meta/conf/distro/include/seperatebuilddir.inc b/meta/conf/distro/include/seperatebuilddir.inc
>> index a9ca240..f60dc5c 100644
>> --- a/meta/conf/distro/include/seperatebuilddir.inc
>> +++ b/meta/conf/distro/include/seperatebuilddir.inc
>> @@ -78,7 +78,9 @@ B_pn-compositeproto = "${SEPB}"
>> B_pn-compositeproto-native = "${SEPB}"
>> #B_pn-connman = "${SEPB}"
>> #B_pn-connman-gnome = "${SEPB}"
>> -B_pn-consolekit = "${SEPB}"
>> +#B_pn-consolekit = "${SEPB}"
>> +#| /build/setup-scripts/build/tmp-angstrom_next-eglibc/work/cortexa8hf-vfp-neon-angstrom-linux-gnueabi/consolekit/0.4.5-r10/ConsoleKit-0.4.5/pam-ck-connector/pam-ck-connector.c:64:26: fatal error: ck-connector.h: No such file or directory
>> +#| compilation terminated.
>> B_pn-console-tools = "${SEPB}"
>> B_pn-coreutils = "${SEPB}"
>> B_pn-coreutils-native = "${SEPB}"
> 
> Neither my local builds or the autobuilder see this. Any idea why some
> builds would fail and others would work?

No idea, it was building fine, then I enabled seperate-builddir, removed TMPDIR, kicked off a build and ck started failing, so I disabled SEPB, -c clean and it started working again. This is on quadcore i7, make -j8, spinning rust.

So far it's the only recipe failing over here for OE-core and seperate builddir.

regards,

Koen
Richard Purdie - April 16, 2013, 9:08 p.m.
On Tue, 2013-04-16 at 18:29 +0200, Koen Kooi wrote:
> Op 16 apr. 2013, om 17:53 heeft Richard Purdie <richard.purdie@linuxfoundation.org> het volgende geschreven:
> 
> > On Tue, 2013-04-16 at 13:49 +0200, Koen Kooi wrote:
> >> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> >> ---
> >> meta/conf/distro/include/seperatebuilddir.inc | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >> 
> >> diff --git a/meta/conf/distro/include/seperatebuilddir.inc b/meta/conf/distro/include/seperatebuilddir.inc
> >> index a9ca240..f60dc5c 100644
> >> --- a/meta/conf/distro/include/seperatebuilddir.inc
> >> +++ b/meta/conf/distro/include/seperatebuilddir.inc
> >> @@ -78,7 +78,9 @@ B_pn-compositeproto = "${SEPB}"
> >> B_pn-compositeproto-native = "${SEPB}"
> >> #B_pn-connman = "${SEPB}"
> >> #B_pn-connman-gnome = "${SEPB}"
> >> -B_pn-consolekit = "${SEPB}"
> >> +#B_pn-consolekit = "${SEPB}"
> >> +#| /build/setup-scripts/build/tmp-angstrom_next-eglibc/work/cortexa8hf-vfp-neon-angstrom-linux-gnueabi/consolekit/0.4.5-r10/ConsoleKit-0.4.5/pam-ck-connector/pam-ck-connector.c:64:26: fatal error: ck-connector.h: No such file or directory
> >> +#| compilation terminated.
> >> B_pn-console-tools = "${SEPB}"
> >> B_pn-coreutils = "${SEPB}"
> >> B_pn-coreutils-native = "${SEPB}"
> > 
> > Neither my local builds or the autobuilder see this. Any idea why some
> > builds would fail and others would work?
> 
> No idea, it was building fine, then I enabled seperate-builddir,
> removed TMPDIR, kicked off a build and ck started failing, so I
> disabled SEPB, -c clean and it started working again. This is on
> quadcore i7, make -j8, spinning rust.
> 
> So far it's the only recipe failing over here for OE-core and seperate builddir.

The answer would appear to be, you need "pam" in DISTRO_FEATURES, it
works otherwise. Means it should be easy to fix to build properly.

Cheers,

Richard

Patch

diff --git a/meta/conf/distro/include/seperatebuilddir.inc b/meta/conf/distro/include/seperatebuilddir.inc
index a9ca240..f60dc5c 100644
--- a/meta/conf/distro/include/seperatebuilddir.inc
+++ b/meta/conf/distro/include/seperatebuilddir.inc
@@ -78,7 +78,9 @@  B_pn-compositeproto = "${SEPB}"
 B_pn-compositeproto-native = "${SEPB}"
 #B_pn-connman = "${SEPB}"
 #B_pn-connman-gnome = "${SEPB}"
-B_pn-consolekit = "${SEPB}"
+#B_pn-consolekit = "${SEPB}"
+#| /build/setup-scripts/build/tmp-angstrom_next-eglibc/work/cortexa8hf-vfp-neon-angstrom-linux-gnueabi/consolekit/0.4.5-r10/ConsoleKit-0.4.5/pam-ck-connector/pam-ck-connector.c:64:26: fatal error: ck-connector.h: No such file or directory
+#| compilation terminated.
 B_pn-console-tools = "${SEPB}"
 B_pn-coreutils = "${SEPB}"
 B_pn-coreutils-native = "${SEPB}"