Patchwork [0/1] kern-tools: fix custom repository BSP generation

login
register
mail settings
Submitter Bruce Ashfield
Date April 15, 2013, 7:45 p.m.
Message ID <cover.1366054838.git.bruce.ashfield@windriver.com>
Download mbox
Permalink /patch/48265/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib zedd/kernel

Comments

Bruce Ashfield - April 15, 2013, 7:45 p.m.
Richard,

As was reported on the oe-core mailing list earlier today, custom
BSPs (other than the ones generated by the BSP tooling) that relied
on generated BSP descriptions started failing.

I did the following one line patch to fix them.

   Updating the SCRCREV to pick up the following fix

       updateme: use absolute path for generated BSP descriptions

       When a custom BSP is used, a top level BSP is generated by the tools and fed
       to the build system just as a user defined BSP would be located and
       passed. The location of the generated file is placed in the top_tgt file,
       which is used by subsequent stages. A relative path was being placed into
       top_tgt, which binds the build to a particular directory structure and
       working directory.

       The location of parts of the build have changed, and this relative path is
       no longer accurate. Changing it to an absolute path solve the build issues
       related to custom BSPs.

There's no risk to existing kernels, or built binary images. The
only thing that runs this code is BSP generation routines that are
triggered by linux-yocto-custom.

If there's any room in 1.4, this one-line would be a good idea!

Cheers,

Bruce


The following changes since commit 45c8cc1a58e7868f4603be08a86fef178edfc926:

  poky.conf: add Poky 1.4 and CentOS 6.4 to SANITY_TESTED_DISTROS (2013-04-15 17:21:28 +0100)

are available in the git repository at:

  git://git.pokylinux.org/poky-contrib zedd/kernel
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel

Bruce Ashfield (1):
  kern-tools: fix custom repository BSP generation

 meta/recipes-kernel/kern-tools/kern-tools-native_git.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Anders Darander - April 16, 2013, 6:28 a.m.
On Mon, Apr 15, 2013 at 9:45 PM, Bruce Ashfield <
bruce.ashfield@windriver.com> wrote:

> Richard,
>
> As was reported on the oe-core mailing list earlier today, custom
> BSPs (other than the ones generated by the BSP tooling) that relied
> on generated BSP descriptions started failing.
>
> I did the following one line patch to fix them.
>
>    Updating the SCRCREV to pick up the following fix
>
>        updateme: use absolute path for generated BSP descriptions
>
>        When a custom BSP is used, a top level BSP is generated by the
> tools and fed
>        to the build system just as a user defined BSP would be located and
>        passed. The location of the generated file is placed in the top_tgt
> file,
>        which is used by subsequent stages. A relative path was being
> placed into
>        top_tgt, which binds the build to a particular directory structure
> and
>        working directory.
>
>        The location of parts of the build have changed, and this relative
> path is
>        no longer accurate. Changing it to an absolute path solve the build
> issues
>        related to custom BSPs.
>
> There's no risk to existing kernels, or built binary images. The
> only thing that runs this code is BSP generation routines that are
> triggered by linux-yocto-custom.
>
> If there's any room in 1.4, this one-line would be a good idea!
>

As Bruce states that there's no risk for existing kernels, I hope that
you'll take this one, as linux-yocto-custom currently is broken (at least
when using it together with only a defconfig).

Cheers,
Anders