Patchwork [meta-fsl-arm,v3,12/13] xf86-dri-vivante: Fix DRI module name

login
register
mail settings
Submitter Otavio Salvador
Date April 15, 2013, 11:52 a.m.
Message ID <1366026722-31385-13-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/48233/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 15, 2013, 11:52 a.m.
The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
so we need to rename it for full Xorg acceleration to work.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2: None

 recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
 1 file changed, 4 insertions(+)
Daiane Angolini - April 15, 2013, 3:30 p.m.
On 04/15/2013 08:52 AM, Otavio Salvador wrote:
> The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
> so we need to rename it for full Xorg acceleration to work.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v3: None
> Changes in v2: None
>
>   recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
> index 975041d..6e8f8db 100644
> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
> @@ -30,6 +30,10 @@ do_install_append () {
>
>       # FIXME: don't install libtool (*.la) file
>       rm ${D}${libdir}/xorg/modules/extensions/*.la
> +
> +    # FIXME: The Xorg driver has a hardcoded library name
> +    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
> +       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so

I think you can use a symbolic link instead (as someone else has already 
pointed before in the ML).

Daiane
Otavio Salvador - April 15, 2013, 4:15 p.m.
On Mon, Apr 15, 2013 at 12:30 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:52 AM, Otavio Salvador wrote:
>>
>> The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
>> so we need to rename it for full Xorg acceleration to work.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v3: None
>> Changes in v2: None
>>
>>   recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> index 975041d..6e8f8db 100644
>> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>> @@ -30,6 +30,10 @@ do_install_append () {
>>
>>       # FIXME: don't install libtool (*.la) file
>>       rm ${D}${libdir}/xorg/modules/extensions/*.la
>> +
>> +    # FIXME: The Xorg driver has a hardcoded library name
>> +    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
>> +       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so
>
>
> I think you can use a symbolic link instead (as someone else has already
> pointed before in the ML).

This makes it harder to have regular libdri.so packaged in same rootfs
in future. With the support for multiple CPUs in a single kernel (as
done in mainline) this should be started to be considered.


--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Daiane Angolini - April 15, 2013, 4:41 p.m.
On 04/15/2013 01:15 PM, Otavio Salvador wrote:
> On Mon, Apr 15, 2013 at 12:30 PM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 04/15/2013 08:52 AM, Otavio Salvador wrote:
>>>
>>> The Xorg Vivante driver has a hardcoded module name as 'vivante_dri'
>>> so we need to rename it for full Xorg acceleration to work.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---
>>> Changes in v3: None
>>> Changes in v2: None
>>>
>>>    recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> index 975041d..6e8f8db 100644
>>> --- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> +++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
>>> @@ -30,6 +30,10 @@ do_install_append () {
>>>
>>>        # FIXME: don't install libtool (*.la) file
>>>        rm ${D}${libdir}/xorg/modules/extensions/*.la
>>> +
>>> +    # FIXME: The Xorg driver has a hardcoded library name
>>> +    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
>>> +       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so
>>
>>
>> I think you can use a symbolic link instead (as someone else has already
>> pointed before in the ML).
>
> This makes it harder to have regular libdri.so packaged in same rootfs
> in future. With the support for multiple CPUs in a single kernel (as
> done in mainline) this should be started to be considered.

I got that. Agreed


Daiane

Patch

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
index 975041d..6e8f8db 100644
--- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
@@ -30,6 +30,10 @@  do_install_append () {
 
     # FIXME: don't install libtool (*.la) file
     rm ${D}${libdir}/xorg/modules/extensions/*.la
+
+    # FIXME: The Xorg driver has a hardcoded library name
+    mv ${D}${libdir}/xorg/modules/extensions/libdri.so \
+       ${D}${libdir}/xorg/modules/extensions/libvivante_dri.so
 }
 
 FILES_${PN}-dev += "${includedir}/xorg/*.h"