Patchwork [meta-fsl-arm,v3,11/13] xf86-dri-vivante: Ensure install fails if .la cannot be removed

login
register
mail settings
Submitter Otavio Salvador
Date April 15, 2013, 11:52 a.m.
Message ID <1366026722-31385-12-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/48231/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 15, 2013, 11:52 a.m.
To ensure we catch when the makefile stops to install the .la file, we
ensure the install fails in case .la file does not exist.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2: None

 recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Daiane Angolini - April 15, 2013, 3:29 p.m.
On 04/15/2013 08:52 AM, Otavio Salvador wrote:
> To ensure we catch when the makefile stops to install the .la file, we
> ensure the install fails in case .la file does not exist.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---

Please, elaborate the commit log (i did not understand it)

Daiane
Otavio Salvador - April 15, 2013, 4:14 p.m.
On Mon, Apr 15, 2013 at 12:29 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:52 AM, Otavio Salvador wrote:
>>
>> To ensure we catch when the makefile stops to install the .la file, we
>> ensure the install fails in case .la file does not exist.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>
>
> Please, elaborate the commit log (i did not understand it)

rm wrong-filename.la

Makes install to fail so if it is ever fixed in a new BSP we'll find
it out and can remove this change.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
index aa2361a..975041d 100644
--- a/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-dri-vivante_1.1.0.bb
@@ -28,8 +28,8 @@  do_install_append () {
     cp -axr ${S}/src/*.h ${D}${includedir}/xorg
     find ${D}${includedir} -type f -exec chmod 660 {} \;
 
-    # don't install libtool (*.la) archive not usefull, fix Makefile.am
-    find ${D}${libdir}/xorg/modules -regex ".*\.la$" | xargs rm -f --
+    # FIXME: don't install libtool (*.la) file
+    rm ${D}${libdir}/xorg/modules/extensions/*.la
 }
 
 FILES_${PN}-dev += "${includedir}/xorg/*.h"