Patchwork [meta-fsl-arm,v3,09/13] imx-base.inc: Do not assign UBOOT_LOADADDRESS

login
register
mail settings
Submitter Otavio Salvador
Date April 15, 2013, 11:51 a.m.
Message ID <1366026722-31385-10-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/48227/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 15, 2013, 11:51 a.m.
The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
so we don't need to have the variable UBOOT_LOADADDRESS set unless
it's different from UBOOT_ENTRYPOINT.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2:
- Improve commit log

 conf/machine/include/imx-base.inc | 7 -------
 1 file changed, 7 deletions(-)
Daiane Angolini - April 15, 2013, 3:26 p.m.
On 04/15/2013 08:51 AM, Otavio Salvador wrote:
> The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
> so we don't need to have the variable UBOOT_LOADADDRESS set unless
> it's different from UBOOT_ENTRYPOINT.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---

Please, apply this patch *before* patch 8 ([meta-fsl-arm PATCH v3 08/13] 
imx-base.inc: Fix i.MX6SL entry point hex format)

In my point of view you don't need to "fix" a source code that you will 
remove.


Daiane
Otavio Salvador - April 15, 2013, 4:13 p.m.
On Mon, Apr 15, 2013 at 12:26 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>
>> The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
>> so we don't need to have the variable UBOOT_LOADADDRESS set unless
>> it's different from UBOOT_ENTRYPOINT.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>
>
> Please, apply this patch *before* patch 8 ([meta-fsl-arm PATCH v3 08/13]
> imx-base.inc: Fix i.MX6SL entry point hex format)
>
> In my point of view you don't need to "fix" a source code that you will
> remove.

If that is the case, I prefer to merge both fixes in a single patch.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Daiane Angolini - April 15, 2013, 4:42 p.m.
On 04/15/2013 01:13 PM, Otavio Salvador wrote:
> On Mon, Apr 15, 2013 at 12:26 PM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>>
>>> The code uses UBOOT_ENTRYPOINT as default value for UBOOT_LOADADDRESS
>>> so we don't need to have the variable UBOOT_LOADADDRESS set unless
>>> it's different from UBOOT_ENTRYPOINT.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---
>>
>>
>> Please, apply this patch *before* patch 8 ([meta-fsl-arm PATCH v3 08/13]
>> imx-base.inc: Fix i.MX6SL entry point hex format)
>>
>> In my point of view you don't need to "fix" a source code that you will
>> remove.
>
> If that is the case, I prefer to merge both fixes in a single patch.

Well. I think I agree


Daiane

Patch

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index 2cc8b70..c761626 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -14,16 +14,9 @@  UBOOT_MAKE_TARGET = "u-boot.imx"
 UBOOT_SUFFIX ?= "imx"
 
 UBOOT_ENTRYPOINT_mx51  = "0xa0000000"
-UBOOT_LOADADDRESS_mx51 = "0xa0000000"
-
 UBOOT_ENTRYPOINT_mx53  = "0x70800000"
-UBOOT_LOADADDRESS_mx53 = "0x70800000"
-
 UBOOT_ENTRYPOINT_mx6  = "0x10800000"
-UBOOT_LOADADDRESS_mx6 = "0x10800000"
-
 UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
-UBOOT_LOADADDRESS_mx6sl = "0x80800000"
 
 PREFERRED_VERSION_xserver-xorg_mx6 = "2:1.11.4"