Patchwork [meta-fsl-arm,v3,08/13] imx-base.inc: Fix i.MX6SL entry point hex format

login
register
mail settings
Submitter Otavio Salvador
Date April 15, 2013, 11:51 a.m.
Message ID <1366026722-31385-9-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/48225/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 15, 2013, 11:51 a.m.
Trivial change just to make it using same code style as other entry
point values.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3: None
Changes in v2:
- New patch

 conf/machine/include/imx-base.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Daiane Angolini - April 15, 2013, 3:24 p.m.
On 04/15/2013 08:51 AM, Otavio Salvador wrote:
> Trivial change just to make it using same code style as other entry
> point values.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> Changes in v3: None
> Changes in v2:
> - New patch
>
>   conf/machine/include/imx-base.inc | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index 456bbfb..2cc8b70 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -22,8 +22,8 @@ UBOOT_LOADADDRESS_mx53 = "0x70800000"
>   UBOOT_ENTRYPOINT_mx6  = "0x10800000"
>   UBOOT_LOADADDRESS_mx6 = "0x10800000"
>
> -UBOOT_ENTRYPOINT_mx6sl = "0X80800000"
> -UBOOT_LOADADDRESS_mx6sl = "0X80800000"
> +UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
> +UBOOT_LOADADDRESS_mx6sl = "0x80800000"

Are UBOOT_LOADADDRESS already being used? (didn't you remove it 
somewhere else?)

Daiane
Otavio Salvador - April 15, 2013, 4:12 p.m.
On Mon, Apr 15, 2013 at 12:24 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>
>> Trivial change just to make it using same code style as other entry
>> point values.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>> Changes in v3: None
>> Changes in v2:
>> - New patch
>>
>>   conf/machine/include/imx-base.inc | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/conf/machine/include/imx-base.inc
>> b/conf/machine/include/imx-base.inc
>> index 456bbfb..2cc8b70 100644
>> --- a/conf/machine/include/imx-base.inc
>> +++ b/conf/machine/include/imx-base.inc
>> @@ -22,8 +22,8 @@ UBOOT_LOADADDRESS_mx53 = "0x70800000"
>>   UBOOT_ENTRYPOINT_mx6  = "0x10800000"
>>   UBOOT_LOADADDRESS_mx6 = "0x10800000"
>>
>> -UBOOT_ENTRYPOINT_mx6sl = "0X80800000"
>> -UBOOT_LOADADDRESS_mx6sl = "0X80800000"
>> +UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
>> +UBOOT_LOADADDRESS_mx6sl = "0x80800000"
>
>
> Are UBOOT_LOADADDRESS already being used? (didn't you remove it somewhere
> else?)

It is removed in 9/13 but the fix of format should be done before so
we don't mix fixes.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index 456bbfb..2cc8b70 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -22,8 +22,8 @@  UBOOT_LOADADDRESS_mx53 = "0x70800000"
 UBOOT_ENTRYPOINT_mx6  = "0x10800000"
 UBOOT_LOADADDRESS_mx6 = "0x10800000"
 
-UBOOT_ENTRYPOINT_mx6sl = "0X80800000"
-UBOOT_LOADADDRESS_mx6sl = "0X80800000"
+UBOOT_ENTRYPOINT_mx6sl = "0x80800000"
+UBOOT_LOADADDRESS_mx6sl = "0x80800000"
 
 PREFERRED_VERSION_xserver-xorg_mx6 = "2:1.11.4"