Patchwork [meta-fsl-arm,v3,05/13] imx-base.inc: Disable firmware include for not fully supported BSPs

login
register
mail settings
Submitter Otavio Salvador
Date April 15, 2013, 11:51 a.m.
Message ID <1366026722-31385-6-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/48219/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 15, 2013, 11:51 a.m.
The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
don't have the firmware package for them so comment them out so it
doesn't break the build.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
Changes in v3:
- New patch

Changes in v2: None

 conf/machine/include/imx-base.inc | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
Daiane Angolini - April 15, 2013, 2:02 p.m.
On 04/15/2013 08:51 AM, Otavio Salvador wrote:
> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
> don't have the firmware package for them so comment them out so it
> doesn't break the build.

Why to keep this code? I would prefer to remove the lines instead of 
comment them.


Daiane
Otavio Salvador - April 15, 2013, 2:14 p.m.
On Mon, Apr 15, 2013 at 11:02 AM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>
>> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
>> don't have the firmware package for them so comment them out so it
>> doesn't break the build.
>
> Why to keep this code? I would prefer to remove the lines instead of comment
> them.

I can remove it but I kept it as it is the name of the generated files
and makes it easier to add it back (also has the FIXME). So if someone
grep the code looking for firmware for it, it'll find it commented and
with a FIXME on top of it.

What do you think?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Daiane Angolini - April 15, 2013, 4:40 p.m.
On 04/15/2013 11:14 AM, Otavio Salvador wrote:
> On Mon, Apr 15, 2013 at 11:02 AM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>>
>>> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
>>> don't have the firmware package for them so comment them out so it
>>> doesn't break the build.
>>
>> Why to keep this code? I would prefer to remove the lines instead of comment
>> them.
>
> I can remove it but I kept it as it is the name of the generated files
> and makes it easier to add it back (also has the FIXME). So if someone
> grep the code looking for firmware for it, it'll find it commented and
> with a FIXME on top of it.
>
> What do you think?

I prefer to remove the code. But, it's not that hard preference.


Daiane
Otavio Salvador - April 15, 2013, 5:10 p.m.
On Mon, Apr 15, 2013 at 1:40 PM, Daiane Angolini
<daiane.angolini@freescale.com> wrote:
> On 04/15/2013 11:14 AM, Otavio Salvador wrote:
>>
>> On Mon, Apr 15, 2013 at 11:02 AM, Daiane Angolini
>> <daiane.angolini@freescale.com> wrote:
>>>
>>> On 04/15/2013 08:51 AM, Otavio Salvador wrote:
>>>>
>>>>
>>>> The i.MX25, i.MX27, i.MX31 and i.MX35 are not fully supported and we
>>>> don't have the firmware package for them so comment them out so it
>>>> doesn't break the build.
>>>
>>>
>>> Why to keep this code? I would prefer to remove the lines instead of
>>> comment
>>> them.
>>
>>
>> I can remove it but I kept it as it is the name of the generated files
>> and makes it easier to add it back (also has the FIXME). So if someone
>> grep the code looking for firmware for it, it'll find it commented and
>> with a FIXME on top of it.
>>
>> What do you think?
>
>
> I prefer to remove the code. But, it's not that hard preference.

And about the FIXME?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index b421807..de48e98 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -44,10 +44,12 @@  MACHINE_FIRMWARE_mx6d = "firmware-imx-vpu-imx6d"
 MACHINE_FIRMWARE_mx6dl = "firmware-imx-vpu-imx6d"
 MACHINE_FIRMWARE_mx53 = "firmware-imx-vpu-imx53 firmware-imx-sdma-imx53"
 MACHINE_FIRMWARE_mx51 = "firmware-imx-vpu-imx51 firmware-imx-sdma-imx51"
-MACHINE_FIRMWARE_mx35 = "firmware-imx-sdma-imx35"
-MACHINE_FIRMWARE_mx31 = "firmware-imx-sdma-imx31"
-MACHINE_FIRMWARE_mx27 = "firmware-imx-vpu-imx27"
-MACHINE_FIRMWARE_mx25 = "firmware-imx-sdma-imx25"
+
+# FIXME: Needs addition of firmware-imx of official BSPs
+#MACHINE_FIRMWARE_mx35 = "firmware-imx-sdma-imx35"
+#MACHINE_FIRMWARE_mx31 = "firmware-imx-sdma-imx31"
+#MACHINE_FIRMWARE_mx27 = "firmware-imx-vpu-imx27"
+#MACHINE_FIRMWARE_mx25 = "firmware-imx-sdma-imx25"
 
 MACHINE_EXTRA_RRECOMMENDS += "${MACHINE_FIRMWARE}"