Patchwork udev: remove udev-extraconf from RRECOMMENDS

login
register
mail settings
Submitter Koen Kooi
Date April 15, 2013, 10:12 a.m.
Message ID <1366020744-2958-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/48183/
State New
Headers show

Comments

Koen Kooi - April 15, 2013, 10:12 a.m.
In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.

Change it back to opt-in for images/packagegroups.

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/recipes-core/udev/udev.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Ross Burton - April 15, 2013, 10:21 a.m.
On 15 April 2013 11:12, Koen Kooi <koen@dominion.thruhere.net> wrote:
> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.

If/when this merges initramfs-live-boot will potentially (read: will
break in Poky) break, I've just sent a fix for that. Another fix
incoming for Sato images.

Ross
Ross Burton - April 15, 2013, 3:16 p.m.
Hi Koen,

On 15 April 2013 11:12, Koen Kooi <koen@dominion.thruhere.net> wrote:
> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.

What udev updates are you referring to here?  The udev in oe-core has
RRECOMMENDED on udev-extraconf since 2008
(fc128ab1e4fec27d44cebfa690a9bc233eda0caf) and I don't see a udev
override in meta-systemd.

Dropping udev-extraconf from udev is rather invasive for a post-freeze
change considering how much it will effect.

Ross
Koen Kooi - April 15, 2013, 3:21 p.m.
Op 15 apr. 2013, om 17:16 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> Hi Koen,
> 
> On 15 April 2013 11:12, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.
> 
> What udev updates are you referring to here?  The udev in oe-core has
> RRECOMMENDED on udev-extraconf since 2008
> (fc128ab1e4fec27d44cebfa690a9bc233eda0caf) and I don't see a udev
> override in meta-systemd.

The udev in meta-oe, I never used the udev in oe-core, it was very outdated and had all the weird dependencies like extraconf.

> Dropping udev-extraconf from udev is rather invasive for a post-freeze
> change considering how much it will effect.

I don't really care when it gets applied, I can always carry the patch in the angstrom 1.4 tree.
Ross Burton - April 15, 2013, 3:27 p.m.
On 15 April 2013 16:21, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> What udev updates are you referring to here?  The udev in oe-core has
>> RRECOMMENDED on udev-extraconf since 2008
>> (fc128ab1e4fec27d44cebfa690a9bc233eda0caf) and I don't see a udev
>> override in meta-systemd.
>
> The udev in meta-oe, I never used the udev in oe-core, it was very outdated and had all the weird dependencies like extraconf.

Presumably that's been moved to Angstrom as I can't see a udev at all
in meta-oe now.

Ross
Koen Kooi - April 15, 2013, 3:31 p.m.
Op 15 apr. 2013, om 17:27 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 15 April 2013 16:21, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>> What udev updates are you referring to here?  The udev in oe-core has
>>> RRECOMMENDED on udev-extraconf since 2008
>>> (fc128ab1e4fec27d44cebfa690a9bc233eda0caf) and I don't see a udev
>>> override in meta-systemd.
>> 
>> The udev in meta-oe, I never used the udev in oe-core, it was very outdated and had all the weird dependencies like extraconf.
> 
> Presumably that's been moved to Angstrom as I can't see a udev at all
> in meta-oe now.

It was deleted in favour of systemd.bb providing udev, angstrom hasn't udev the standalone udev since it was merged into the systemd repo.
Koen Kooi - April 15, 2013, 3:34 p.m.
Op 15 apr. 2013, om 17:31 heeft Koen Kooi <koen@dominion.thruhere.net> het volgende geschreven:

> 
> Op 15 apr. 2013, om 17:27 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:
> 
>> On 15 April 2013 16:21, Koen Kooi <koen@dominion.thruhere.net> wrote:
>>>> What udev updates are you referring to here?  The udev in oe-core has
>>>> RRECOMMENDED on udev-extraconf since 2008
>>>> (fc128ab1e4fec27d44cebfa690a9bc233eda0caf) and I don't see a udev
>>>> override in meta-systemd.
>>> 
>>> The udev in meta-oe, I never used the udev in oe-core, it was very outdated and had all the weird dependencies like extraconf.
>> 
>> Presumably that's been moved to Angstrom as I can't see a udev at all
>> in meta-oe now.
> 
> It was deleted in favour of systemd.bb providing udev, angstrom hasn't udev the standalone udev since it was merged into the systemd repo.

https://github.com/openembedded/meta-oe/commit/f95109e3e04ee167fd0ceb80e62f7cfec81802de
Ross Burton - April 15, 2013, 3:35 p.m.
On 15 April 2013 16:31, Koen Kooi <koen@dominion.thruhere.net> wrote:
> It was deleted in favour of systemd.bb providing udev, angstrom hasn't udev the standalone udev since it was merged into the systemd repo.

Right, makes sense.

Ross

Patch

diff --git a/meta/recipes-core/udev/udev.inc b/meta/recipes-core/udev/udev.inc
index d025458..b9f479a 100644
--- a/meta/recipes-core/udev/udev.inc
+++ b/meta/recipes-core/udev/udev.inc
@@ -14,7 +14,7 @@  LDFLAGS += "-lrt"
 
 DEPENDS = "acl glib-2.0 libusb usbutils pciutils gperf-native libxslt-native util-linux"
 RPROVIDES_${PN} = "hotplug"
-RRECOMMENDS_${PN} += "udev-extraconf usbutils-ids pciutils-ids"
+RRECOMMENDS_${PN} += "usbutils-ids pciutils-ids"
 RDEPENDS_libudev = "${PN} (= ${EXTENDPKGV})"
 
 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/kernel/hotplug/udev-${PV}.tar.gz \