Patchwork rpm-postinsts: remove erroneous call to /etc/default/rcS

login
register
mail settings
Submitter Paul Eggleton
Date April 14, 2013, 7:43 p.m.
Message ID <1365968582-10662-1-git-send-email-paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/48151/
State Accepted
Commit 6c972598c6da17fbec7a4582eb593c31f4283275
Headers show

Comments

Paul Eggleton - April 14, 2013, 7:43 p.m.
This doesn't work when the initscripts package is not installed (e.g.
when using systemd only) and is not even needed.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 meta/recipes-devtools/rpm/rpm-postinsts.bb |    1 -
 1 file changed, 1 deletion(-)
Khem Raj - April 14, 2013, 10:37 p.m.
Tested-By: Khem Raj <raj.khem@gmail.com>

Now I see that posinsts are running. But they are running forever probably thats a separate problem

On Apr 14, 2013, at 12:43 PM, Paul Eggleton <paul.eggleton@linux.intel.com> wrote:

> This doesn't work when the initscripts package is not installed (e.g.
> when using systemd only) and is not even needed.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> meta/recipes-devtools/rpm/rpm-postinsts.bb |    1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/rpm/rpm-postinsts.bb b/meta/recipes-devtools/rpm/rpm-postinsts.bb
> index a5310b5..3d2d05d 100644
> --- a/meta/recipes-devtools/rpm/rpm-postinsts.bb
> +++ b/meta/recipes-devtools/rpm/rpm-postinsts.bb
> @@ -36,7 +36,6 @@ if [ "x$D" != "x" ] && [ -f $D/var/lib/rpm/Packages ]; then
> 	install -d $D/${sysconfdir}/rcS.d
> 	cat > $D${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts << "EOF"
> #!/bin/sh
> -. /etc/default/rcS
> 
> [ -d /etc/rpm-postinsts ] && for i in `ls /etc/rpm-postinsts/`; do
> 	i=/etc/rpm-postinsts/$i
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/rpm/rpm-postinsts.bb b/meta/recipes-devtools/rpm/rpm-postinsts.bb
index a5310b5..3d2d05d 100644
--- a/meta/recipes-devtools/rpm/rpm-postinsts.bb
+++ b/meta/recipes-devtools/rpm/rpm-postinsts.bb
@@ -36,7 +36,6 @@  if [ "x$D" != "x" ] && [ -f $D/var/lib/rpm/Packages ]; then
 	install -d $D/${sysconfdir}/rcS.d
 	cat > $D${sysconfdir}/rcS.d/S${POSTINSTALL_INITPOSITION}run-postinsts << "EOF"
 #!/bin/sh
-. /etc/default/rcS
 
 [ -d /etc/rpm-postinsts ] && for i in `ls /etc/rpm-postinsts/`; do
 	i=/etc/rpm-postinsts/$i