Patchwork [RFC] systemd: remove udev-extraconf from RRECOMMENDS

login
register
mail settings
Submitter Koen Kooi
Date April 14, 2013, 1:55 p.m.
Message ID <1365947722-16267-1-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/48139/
State New
Headers show

Comments

Koen Kooi - April 14, 2013, 1:55 p.m.
In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.

Change it back to opt-in for images/packagegroups.

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---

Since udev-extraconf is persona non grata in angstrom I have no idea what depends on it, so please tell me what needs to get fixed after removing this.

 meta/recipes-core/systemd/systemd_199.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - April 14, 2013, 2:05 p.m.
On Sun, Apr 14, 2013 at 03:55:22PM +0200, Koen Kooi wrote:
> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.
> 
> Change it back to opt-in for images/packagegroups.

Maybe RSUGGESTS?

Cheers,

> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
> 
> Since udev-extraconf is persona non grata in angstrom I have no idea what depends on it, so please tell me what needs to get fixed after removing this.
> 
>  meta/recipes-core/systemd/systemd_199.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
> index 0d07f85..fbf2a2f 100644
> --- a/meta/recipes-core/systemd/systemd_199.bb
> +++ b/meta/recipes-core/systemd/systemd_199.bb
> @@ -202,7 +202,7 @@ FILES_udev-dbg += "/lib/udev/.debug"
>  
>  RDEPENDS_udev += "udev-utils"
>  RPROVIDES_udev = "hotplug"
> -RRECOMMENDS_udev += "udev-extraconf udev-hwdb"
> +RRECOMMENDS_udev += "udev-hwdb"
>  
>  FILES_udev += "${base_sbindir}/udevd \
>                 ${base_libdir}/systemd/systemd-udevd \
> -- 
> 1.8.1.4
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Koen Kooi - April 14, 2013, 2:21 p.m.
Op 14 apr. 2013, om 16:05 heeft Martin Jansa <martin.jansa@gmail.com> het volgende geschreven:

> On Sun, Apr 14, 2013 at 03:55:22PM +0200, Koen Kooi wrote:
>> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.
>> 
>> Change it back to opt-in for images/packagegroups.
> 
> Maybe RSUGGESTS?

Not sure if that fixes the case where people do want it. I explicitly don't want this ending up in my rootfs (BAD_RRECOMMENDS might work here), but that doesn't work when doing 'opkg upgrade'. 

I'm just trying to fix regressions compared to the meta-oe udev/systemd state in 1.3 :)

regards,

Koen

> 
> Cheers,
> 
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> 
>> Since udev-extraconf is persona non grata in angstrom I have no idea what depends on it, so please tell me what needs to get fixed after removing this.
>> 
>> meta/recipes-core/systemd/systemd_199.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
>> index 0d07f85..fbf2a2f 100644
>> --- a/meta/recipes-core/systemd/systemd_199.bb
>> +++ b/meta/recipes-core/systemd/systemd_199.bb
>> @@ -202,7 +202,7 @@ FILES_udev-dbg += "/lib/udev/.debug"
>> 
>> RDEPENDS_udev += "udev-utils"
>> RPROVIDES_udev = "hotplug"
>> -RRECOMMENDS_udev += "udev-extraconf udev-hwdb"
>> +RRECOMMENDS_udev += "udev-hwdb"
>> 
>> FILES_udev += "${base_sbindir}/udevd \
>>                ${base_libdir}/systemd/systemd-udevd \
>> -- 
>> 1.8.1.4
>> 
>> 
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> 
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
Martin Jansa - April 14, 2013, 2:59 p.m.
On Sun, Apr 14, 2013 at 04:21:15PM +0200, Koen Kooi wrote:
> 
> Op 14 apr. 2013, om 16:05 heeft Martin Jansa <martin.jansa@gmail.com> het volgende geschreven:
> 
> > On Sun, Apr 14, 2013 at 03:55:22PM +0200, Koen Kooi wrote:
> >> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.
> >> 
> >> Change it back to opt-in for images/packagegroups.
> > 
> > Maybe RSUGGESTS?
> 
> Not sure if that fixes the case where people do want it. I explicitly don't want this ending up in my rootfs (BAD_RRECOMMENDS might work here), but that doesn't work when doing 'opkg upgrade'. 

It does not, but it will build udev-extraconf in feed and notify user
that there is "more" in case he decides to install udev-extraconf
manually.

> I'm just trying to fix regressions compared to the meta-oe udev/systemd state in 1.3 :)

I guess we all are :)

> >> ---
> >> 
> >> Since udev-extraconf is persona non grata in angstrom I have no idea what depends on it, so please tell me what needs to get fixed after removing this.
> >> 
> >> meta/recipes-core/systemd/systemd_199.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
> >> index 0d07f85..fbf2a2f 100644
> >> --- a/meta/recipes-core/systemd/systemd_199.bb
> >> +++ b/meta/recipes-core/systemd/systemd_199.bb
> >> @@ -202,7 +202,7 @@ FILES_udev-dbg += "/lib/udev/.debug"
> >> 
> >> RDEPENDS_udev += "udev-utils"
> >> RPROVIDES_udev = "hotplug"
> >> -RRECOMMENDS_udev += "udev-extraconf udev-hwdb"
> >> +RRECOMMENDS_udev += "udev-hwdb"
> >> 
> >> FILES_udev += "${base_sbindir}/udevd \
> >>                ${base_libdir}/systemd/systemd-udevd \
> >> -- 
> >> 1.8.1.4
> >> 
> >> 
> >> _______________________________________________
> >> Openembedded-core mailing list
> >> Openembedded-core@lists.openembedded.org
> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
> > 
> > -- 
> > Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
Ross Burton - April 15, 2013, 10:03 a.m.
On 14 April 2013 14:55, Koen Kooi <koen@dominion.thruhere.net> wrote:
> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.


If this is a concern then you should do it for udev too, as udev.inc has:

RRECOMMENDS_${PN} += "udev-extraconf usbutils-ids pciutils-ids"

Ross
Koen Kooi - April 15, 2013, 10:12 a.m.
Op 15 apr. 2013, om 12:03 heeft "Burton, Ross" <ross.burton@intel.com> het volgende geschreven:

> On 14 April 2013 14:55, Koen Kooi <koen@dominion.thruhere.net> wrote:
>> In the original udev and systemd updates these extra conf rules and scripts where removed and moved to a different recipe to avoid pulling them in by default, making them opt-in. The systemd merge into oe-core regressed this into making it impossible to opt out of it when using package feeds for upgrades.
> 
> 
> If this is a concern then you should do it for udev too, as udev.inc has:
> 
> RRECOMMENDS_${PN} += "udev-extraconf usbutils-ids pciutils-ids"

I haven't run into that, because I don't use standalone udev :) Good catch, seperate patch sent for that.

regards,

Koen

Patch

diff --git a/meta/recipes-core/systemd/systemd_199.bb b/meta/recipes-core/systemd/systemd_199.bb
index 0d07f85..fbf2a2f 100644
--- a/meta/recipes-core/systemd/systemd_199.bb
+++ b/meta/recipes-core/systemd/systemd_199.bb
@@ -202,7 +202,7 @@  FILES_udev-dbg += "/lib/udev/.debug"
 
 RDEPENDS_udev += "udev-utils"
 RPROVIDES_udev = "hotplug"
-RRECOMMENDS_udev += "udev-extraconf udev-hwdb"
+RRECOMMENDS_udev += "udev-hwdb"
 
 FILES_udev += "${base_sbindir}/udevd \
                ${base_libdir}/systemd/systemd-udevd \