Patchwork [1/2] udev-extraconf: Add -o silent to auto mount for mount.util-linux

login
register
mail settings
Submitter Saul Wold
Date April 13, 2013, 7:28 a.m.
Message ID <1365838096-11843-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/48057/
State New
Headers show

Comments

Saul Wold - April 13, 2013, 7:28 a.m.
This will silence some of the noisy output from mount.util-linux and the kernel
when trying to automount filesystems or devices. Busybox does not accept the silent
option, it uses a "loud" option instead.

[YOCTO #3935]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Richard Purdie - April 13, 2013, 10:26 a.m.
On Sat, 2013-04-13 at 00:28 -0700, Saul Wold wrote:
> This will silence some of the noisy output from mount.util-linux and the kernel
> when trying to automount filesystems or devices. Busybox does not accept the silent
> option, it uses a "loud" option instead.
> 
> [YOCTO #3935]
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

As far as I can see this will break with busybox mount. Is there a 2/2
missing?

> diff --git a/meta/recipes-core/udev/udev-extraconf/mount.sh b/meta/recipes-core/udev/udev-extraconf/mount.sh
> index 99c76b2..7b58361 100644
> --- a/meta/recipes-core/udev/udev-extraconf/mount.sh
> +++ b/meta/recipes-core/udev/udev-extraconf/mount.sh
> @@ -22,7 +22,7 @@ automount() {
>  
>  	! test -d "/media/$name" && mkdir -p "/media/$name"
>  	
> -	if ! $MOUNT -t auto $DEVNAME "/media/$name"
> +	if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
>  	then
>  		#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
>  		rm_dir "/media/$name"
Bernhard Reutner-Fischer - April 13, 2013, 1:23 p.m.
On 13 April 2013 12:26:38 Richard Purdie 
<richard.purdie@linuxfoundation.org> wrote:
> On Sat, 2013-04-13 at 00:28 -0700, Saul Wold wrote:
> > This will silence some of the noisy output from mount.util-linux and the 
> kernel
> > when trying to automount filesystems or devices. Busybox does not accept 
> the silent
> > option, it uses a "loud" option instead.
> > [YOCTO #3935]
> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
> > ---
> >  meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> As far as I can see this will break with busybox mount. Is there a 2/2
> missing?

IIRC Busybox defaults to be silent (right?), I will thus add (and ignore) 
silent. I will have a look in the evening.

Thanks for the heads up!
Cheers,
>
> > diff --git a/meta/recipes-core/udev/udev-extraconf/mount.sh 
> b/meta/recipes-core/udev/udev-extraconf/mount.sh
> > index 99c76b2..7b58361 100644
> > --- a/meta/recipes-core/udev/udev-extraconf/mount.sh
> > +++ b/meta/recipes-core/udev/udev-extraconf/mount.sh
> > @@ -22,7 +22,7 @@ automount() {
> >  	! test -d "/media/$name" && mkdir -p "/media/$name"
> >  	
> > -	if ! $MOUNT -t auto $DEVNAME "/media/$name"
> > +	if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
> >  	then
> >  		#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" 
> failed!"
> >  		rm_dir "/media/$name"
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core


Sent with AquaMail for Android
http://www.aqua-mail.com
Saul Wold - April 13, 2013, 4:55 p.m.
On 04/13/2013 06:23 AM, Bernhard Reutner-Fischer wrote:
> On 13 April 2013 12:26:38 Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>> On Sat, 2013-04-13 at 00:28 -0700, Saul Wold wrote:
>> > This will silence some of the noisy output from mount.util-linux and
>> the kernel
>> > when trying to automount filesystems or devices. Busybox does not
>> accept the silent
>> > option, it uses a "loud" option instead.
>> > [YOCTO #3935]
>> > Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> > ---
>> >  meta/recipes-core/udev/udev-extraconf/mount.sh | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> As far as I can see this will break with busybox mount. Is there a 2/2
>> missing?
>
> IIRC Busybox defaults to be silent (right?), I will thus add (and
> ignore) silent. I will have a look in the evening.
>

Dangit, I sent the wrong patch, I have the correct one, will resend.

Sau!

> Thanks for the heads up!
> Cheers,
>>
>> > diff --git a/meta/recipes-core/udev/udev-extraconf/mount.sh
>> b/meta/recipes-core/udev/udev-extraconf/mount.sh
>> > index 99c76b2..7b58361 100644
>> > --- a/meta/recipes-core/udev/udev-extraconf/mount.sh
>> > +++ b/meta/recipes-core/udev/udev-extraconf/mount.sh
>> > @@ -22,7 +22,7 @@ automount() {
>> >      ! test -d "/media/$name" && mkdir -p "/media/$name"
>> >
>> > -    if ! $MOUNT -t auto $DEVNAME "/media/$name"
>> > +    if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
>> >      then
>> >          #logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME
>> \"/media/$name\" failed!"
>> >          rm_dir "/media/$name"
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
> Sent with AquaMail for Android
> http://www.aqua-mail.com
>
>
>
>

Patch

diff --git a/meta/recipes-core/udev/udev-extraconf/mount.sh b/meta/recipes-core/udev/udev-extraconf/mount.sh
index 99c76b2..7b58361 100644
--- a/meta/recipes-core/udev/udev-extraconf/mount.sh
+++ b/meta/recipes-core/udev/udev-extraconf/mount.sh
@@ -22,7 +22,7 @@  automount() {
 
 	! test -d "/media/$name" && mkdir -p "/media/$name"
 	
-	if ! $MOUNT -t auto $DEVNAME "/media/$name"
+	if ! $MOUNT -o silent -t auto $DEVNAME "/media/$name"
 	then
 		#logger "mount.sh/automount" "$MOUNT -t auto $DEVNAME \"/media/$name\" failed!"
 		rm_dir "/media/$name"