Patchwork [meta-oe,PATCHv3,5/5] nodejs 8.8.18: unset RDEPENDS for native builds

login
register
mail settings
Submitter Koen Kooi
Date April 12, 2013, 10:04 a.m.
Message ID <1365761087-1229-5-git-send-email-koen@dominion.thruhere.net>
Download mbox | patch
Permalink /patch/48009/
State Accepted, archived
Commit e8b50616ac9742ee87b76676de9130527e07475d
Headers show

Comments

Koen Kooi - April 12, 2013, 10:04 a.m.
Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb | 1 +
 1 file changed, 1 insertion(+)
Martin Jansa - April 12, 2013, 10:30 a.m.
On Fri, Apr 12, 2013 at 12:04:47PM +0200, Koen Kooi wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb b/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
> index 3ab2ed6..2db9e68 100644
> --- a/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
> @@ -36,6 +36,7 @@ do_install () {
>  }
>  
>  RDEPENDS_${PN} = "curl python-shell python-datetime python-subprocess python-crypt python-textutils python-netclient "
> +RDEPENDS_${PN}_class-native = ""

Sorry if I caused problems by removing it before, why is this needed? 
I haven't seen any issues without it.

Also we have patch to upgrade nodejs to 0.10.0, do you know if other
components using nodejs are compatible with it? We'll also need to add
node-gyp if that's useful for someone else too.

Cheers,
Koen Kooi - April 12, 2013, 10:53 a.m.
Op 12 apr. 2013, om 12:30 heeft Martin Jansa <martin.jansa@gmail.com> het volgende geschreven:

> On Fri, Apr 12, 2013 at 12:04:47PM +0200, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
>> ---
>> meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb b/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
>> index 3ab2ed6..2db9e68 100644
>> --- a/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
>> +++ b/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
>> @@ -36,6 +36,7 @@ do_install () {
>> }
>> 
>> RDEPENDS_${PN} = "curl python-shell python-datetime python-subprocess python-crypt python-textutils python-netclient "
>> +RDEPENDS_${PN}_class-native = ""
> 
> Sorry if I caused problems by removing it before, why is this needed? 
> I haven't seen any issues without it.

You can't do DEPENDS = nodejs-native without this line, since python-shell has non -native variant

> Also we have patch to upgrade nodejs to 0.10.0, do you know if other
> components using nodejs are compatible with it?

Not sure, I haven't used node 0.10.0 yet. Otavio and I need to get serious and start meta-node real soon now :)

> We'll also need to add
> node-gyp if that's useful for someone else too.

Yes, I foresee needing it myself :)

regards,

Koen

> 
> Cheers,
> -- 
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Patch

diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb b/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
index 3ab2ed6..2db9e68 100644
--- a/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
+++ b/meta-oe/recipes-devtools/nodejs/nodejs_0.8.18.bb
@@ -36,6 +36,7 @@  do_install () {
 }
 
 RDEPENDS_${PN} = "curl python-shell python-datetime python-subprocess python-crypt python-textutils python-netclient "
+RDEPENDS_${PN}_class-native = ""
 
 FILES_${PN} += "${libdir}/node/wafadmin ${libdir}/node_modules ${libdir}/dtrace"
 BBCLASSEXTEND = "native"