Patchwork [meta-oe] Add dependencies on Perl and Bash to NTP recipe

login
register
mail settings
Submitter lists@philipp-wagner.com
Date April 11, 2013, 8:04 p.m.
Message ID <1365710654-22327-1-git-send-email-lists@philipp-wagner.com>
Download mbox | patch
Permalink /patch/47983/
State Changes Requested, archived
Headers show

Comments

lists@philipp-wagner.com - April 11, 2013, 8:04 p.m.
From: Philipp Wagner <mail@philipp-wagner.com>

do_rootfs gave errors about bash and perl not being found.
This patch adds the two packages to the runtime dependencies
to fix this problem.

Signed-off-by: Philipp Wagner <mail@philipp-wagner.com>
---
 meta-networking/recipes-support/ntp/ntp.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Koen Kooi - April 12, 2013, 10:07 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 11-04-13 22:04, lists@philipp-wagner.com schreef:
> From: Philipp Wagner <mail@philipp-wagner.com>
> 
> do_rootfs gave errors about bash and perl not being found. This patch
> adds the two packages to the runtime dependencies to fix this problem

The bash dependencies need to get checked and changed to /bin/sh and perl
scripts need to get split out into a seperate packages, dragging in perl and
bash for ntp is unacceptable.




-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFRZ9zXMkyGM64RGpERArXAAJ9o7cBaKCvIxdSzniekV5Hblmzc0wCgsDu3
1d6IKRWK+zMTl55UhyxC1Lg=
=SxZ0
-----END PGP SIGNATURE-----
lists@philipp-wagner.com - April 12, 2013, 3:24 p.m.
Am 12.04.2013 12:07, schrieb Koen Kooi:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Op 11-04-13 22:04, lists@philipp-wagner.com schreef:
>> From: Philipp Wagner <mail@philipp-wagner.com>
>>
>> do_rootfs gave errors about bash and perl not being found. This patch
>> adds the two packages to the runtime dependencies to fix this problem
>
> The bash dependencies need to get checked and changed to /bin/sh and perl
> scripts need to get split out into a seperate packages, dragging in perl and
> bash for ntp is unacceptable.

The bash dependency comes from osd_login (installed at
/sbin/osd_login) and start-statd (installed at /usr/sbin/start-statd).

The first one uses $BASHPID, and I'm not sure why $$ wasn't used.

The latter one (start-statd) uses the following shebang:
#!/bin/bash -p
I don't know if there's any POSIX equivalent that could be used.

All in all, I'm not familiar enough with the scripts (or with the 
differences between bash and POSIX shell behavior) to patch any of the 
scripts, so some help would be required here if the scripts should be 
changed.

As for the perl dependency, I just checked the RPM and it was not in 
there any more ... I'll double-check and come back with more details on 
this one.

Philipp

Patch

diff --git a/meta-networking/recipes-support/ntp/ntp.inc b/meta-networking/recipes-support/ntp/ntp.inc
index d93f22d..a563a08 100644
--- a/meta-networking/recipes-support/ntp/ntp.inc
+++ b/meta-networking/recipes-support/ntp/ntp.inc
@@ -59,7 +59,7 @@  PACKAGES += "ntpdate ${PN}-tickadj ${PN}-utils"
 
 # ntp originally includes tickadj. It's split off for inclusion in small firmware images on platforms
 # with wonky clocks (e.g. OpenSlug)
-RDEPENDS_${PN} = "${PN}-tickadj"
+RDEPENDS_${PN} = "${PN}-tickadj perl bash"
 # Handle move from bin to utils package
 RPROVIDES_${PN}-utils = "${PN}-bin"
 RREPLACES_${PN}-utils = "${PN}-bin"