Patchwork [meta-multimedia,v2,2/2] gupnp: remove dependency on gnome-icon-theme

login
register
mail settings
Submitter Nicolas Dechesne
Date April 11, 2013, 8:57 a.m.
Message ID <1365670626-18585-3-git-send-email-ndec@linaro.org>
Download mbox | patch
Permalink /patch/47899/
State Accepted, archived
Headers show

Comments

Nicolas Dechesne - April 11, 2013, 8:57 a.m.
As discussed in [1], let's remove the dependency on gnome-icon-theme,
since it's not required, and it brings additional unwanted dependency,
such as the whole gtk+...

[1] http://article.gmane.org/gmane.comp.handhelds.openembedded/57483

It is build-tested with
 - core-image-minimal
 - IMAGE_INSTALL += 'gupnp'
 - directfb in DISTRO_FEATURES

The build was failing before (GTK failed to build with directfb, which
is expected).

Signed-off-by: Nicolas Dechesne <ndec@linaro.org>
---
 meta-multimedia/recipes-connectivity/gupnp/gupnp.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Martin Jansa - April 11, 2013, 2:14 p.m.
On Thu, Apr 11, 2013 at 10:57:06AM +0200, Nicolas Dechesne wrote:
> As discussed in [1], let's remove the dependency on gnome-icon-theme,
> since it's not required, and it brings additional unwanted dependency,
> such as the whole gtk+...

Hi, I've already applied first version of this yesterday, I don't think
we need to introduce more INC_PRs now, so for now I'll keep it as is
unless someone has good reasons for INC_PRs.

> [1] http://article.gmane.org/gmane.comp.handhelds.openembedded/57483
> 
> It is build-tested with
>  - core-image-minimal
>  - IMAGE_INSTALL += 'gupnp'
>  - directfb in DISTRO_FEATURES
> 
> The build was failing before (GTK failed to build with directfb, which
> is expected).
> 
> Signed-off-by: Nicolas Dechesne <ndec@linaro.org>
> ---
>  meta-multimedia/recipes-connectivity/gupnp/gupnp.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc b/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
> index 31dd407..99bffc0 100644
> --- a/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
> +++ b/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
> @@ -2,9 +2,9 @@ SUMMARY = "UPnP framework"
>  DESCRIPTION = "GUPnP is an elegant, object-oriented open source framework for creating UPnP  devices and control points, written in C using GObject and libsoup. The GUPnP API is intended to be easy to use, efficient and flexible. It provides the same set of features as libupnp, but shields the developer from most of UPnP's internals."
>  LICENSE = "LGPLv2+"
>  
> -INC_PR = "r0"
> +INC_PR = "r1"
>  
> -DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gnome-icon-theme gobject-introspection-stub"
> +DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gobject-introspection-stub"
>  
>  require no-vala.inc
>  
> -- 
> 1.8.1.2
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Patch

diff --git a/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc b/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
index 31dd407..99bffc0 100644
--- a/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
+++ b/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
@@ -2,9 +2,9 @@  SUMMARY = "UPnP framework"
 DESCRIPTION = "GUPnP is an elegant, object-oriented open source framework for creating UPnP  devices and control points, written in C using GObject and libsoup. The GUPnP API is intended to be easy to use, efficient and flexible. It provides the same set of features as libupnp, but shields the developer from most of UPnP's internals."
 LICENSE = "LGPLv2+"
 
-INC_PR = "r0"
+INC_PR = "r1"
 
-DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gnome-icon-theme gobject-introspection-stub"
+DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gobject-introspection-stub"
 
 require no-vala.inc