Patchwork perf_3.4 do_compile error

login
register
mail settings
Submitter Lewis, Nick
Date April 11, 2013, 7:55 a.m.
Message ID <AAE0766F5AF36B46BAB7E0EFB927320630E4A54093@GBTWK10E001.Technology.local>
Download mbox | patch
Permalink /patch/47893/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Lewis, Nick - April 11, 2013, 7:55 a.m.
>>>> The problem is experienced for bitbake fsl-image-test with
>>>> MACHINE?="imx6qsabrelite"
>>>>
>>>> The host system is Ubuntu 12.04.1 LTS. It also has ubuntu arm cross
>>>> tools which I mention having read that some host system includes get
>>>> used during perf arm cross
>>>>
>>>> http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/34
>>>> 21
>>>> 4
>>>
>>>I see; which branch are you using? danny or master?
>>
>> Are you able to reproduce this or is the problem limited to specific host systems?
>>
>> A variation of the patch by Chunrong Guo resolves the problem for me
>
>I've been working in master but please send your patch and we can review it. Before merging it I will try to reproduce the issue.

Please find patch below







--
Nick


The details of this company are as follows:
G4S Technology Limited, Registered Office: Challenge House, International Drive, Tewkesbury, Gloucestershire GL20 8UQ, Registered in England No. 2382338.

This communication may contain information which is confidential, personal and/or privileged.

It is for the exclusive use of the intended recipient(s).
If you are not the intended recipient(s), please note that any distribution, forwarding, copying or use of this communication or the information in it is strictly prohibited.

Any personal views expressed in this e-mail are those of the individual sender and the company does not endorse or accept responsibility for them.

Prior to taking any action based upon this e-mail message, you should seek appropriate confirmation of its authenticity.

This e-mail has been scanned for all viruses by MessageLabs.
Otavio Salvador - April 11, 2013, 11:34 a.m.
On Thu, Apr 11, 2013 at 4:55 AM, Lewis, Nick <nick.lewis@usa.g4s.com> wrote:
>>>>> The problem is experienced for bitbake fsl-image-test with
>>>>> MACHINE?="imx6qsabrelite"
>>>>>
>>>>> The host system is Ubuntu 12.04.1 LTS. It also has ubuntu arm cross
>>>>> tools which I mention having read that some host system includes get
>>>>> used during perf arm cross
>>>>>
>>>>> http://permalink.gmane.org/gmane.comp.handhelds.openembedded.core/34
>>>>> 21
>>>>> 4
>>>>
>>>>I see; which branch are you using? danny or master?
>>>
>>> Are you able to reproduce this or is the problem limited to specific host systems?
>>>
>>> A variation of the patch by Chunrong Guo resolves the problem for me
>>
>>I've been working in master but please send your patch and we can review it. Before merging it I will try to reproduce the issue.
>
> Please find patch below
>
>
>
>
> diff -urN a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch
> --- a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch       1969-12-31 16:00:00.000000000 -0800
> +++ b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch       2013-04-10 07:18:57.314214319 -0700
> @@ -0,0 +1,12 @@
> +--- a/tools/perf/util/include/linux/compiler.h 2013-04-04 17:55:08.000000000 -0700
> ++++ b/tools/perf/util/include/linux/compiler.h 2013-04-10 07:16:36.711981928 -0700
> +@@ -5,7 +5,9 @@
> + #define __always_inline       inline
> + #endif
> + #define __user
> ++#ifndef __attribute_const__
> + #define __attribute_const__
> ++#endif
> +
> + #define __used                __attribute__((__unused__))
> +
> diff -urN a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend
> --- a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend        1969-12-31 16:00:00.000000000 -0800
> +++ b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend        2013-04-11 00:40:13.615799995 -0700
> @@ -0,0 +1,3 @@
> +PRINC := "${@int(PRINC) + 1}"
> +FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> +SRC_URI_append = "file://define-attribute-const.patch "

Leonardo has sent a patch which fixes this issue. The root cause of it
is the sync patch we did with Boundary Devices and which hadn't
include this fix. Leonardo has removed this patch hunk and it should
fix the issue. The change comes from linux-imx source as the perf is
build using same kernel source so these match.

I hope it is clear but please ask if you missed something.

Regards,

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff -urN a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch
--- a/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch       1969-12-31 16:00:00.000000000 -0800
+++ b/meta-fsl-arm/recipes-kernel/perf/files/define-attribute-const.patch       2013-04-10 07:18:57.314214319 -0700
@@ -0,0 +1,12 @@ 
+--- a/tools/perf/util/include/linux/compiler.h 2013-04-04 17:55:08.000000000 -0700
++++ b/tools/perf/util/include/linux/compiler.h 2013-04-10 07:16:36.711981928 -0700
+@@ -5,7 +5,9 @@
+ #define __always_inline       inline
+ #endif
+ #define __user
++#ifndef __attribute_const__
+ #define __attribute_const__
++#endif
+
+ #define __used                __attribute__((__unused__))
+
diff -urN a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend
--- a/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend        1969-12-31 16:00:00.000000000 -0800
+++ b/meta-fsl-arm/recipes-kernel/perf/perf_3.4.bbappend        2013-04-11 00:40:13.615799995 -0700
@@ -0,0 +1,3 @@ 
+PRINC := "${@int(PRINC) + 1}"
+FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
+SRC_URI_append = "file://define-attribute-const.patch "