Patchwork [meta-multimedia] gupnp: remove dependency on gnome-icon-theme

login
register
mail settings
Submitter Nicolas Dechesne
Date April 10, 2013, 3:14 p.m.
Message ID <CAP71WjwrXC6BAyPred-K+c0kZc4aOaDD6Nd_9WC5kmrTv_Hqog@mail.gmail.com>
Download mbox | patch
Permalink /patch/47829/
State Accepted, archived
Headers show

Comments

Nicolas Dechesne - April 10, 2013, 3:14 p.m.
On Wed, Apr 10, 2013 at 4:54 PM, Burton, Ross <ross.burton@intel.com> wrote:
> You'll want to bump PR (ideally adding some form of pr in the .inc at
> the same time).

ouch.. indeed.

do you mean something along these lines:

"6b437d5711b212292c6080626b97480268310da636a6cf937ad6119291af78a1"

then, what I could do is a patch serie where patch 1/2 introduces the
INC_PR with "r0", and patch 2/2 fixes gupnp and increments INC_PR to
'r1'.

also, is that worthwhile to add the INC_PR in all other recipes in the
gupnp folder ? or just in gupnp recipe for now?
Ross Burton - April 10, 2013, 3:37 p.m.
Hi Nicolas,

On 10 April 2013 16:14, Nicolas Dechesne <ndec@linaro.org> wrote:
> then, what I could do is a patch serie where patch 1/2 introduces the
> INC_PR with "r0", and patch 2/2 fixes gupnp and increments INC_PR to
> 'r1'.

Exactly that.

> also, is that worthwhile to add the INC_PR in all other recipes in the
> gupnp folder ? or just in gupnp recipe for now?

Do them all, might as well.

Ross
Martin Jansa - April 10, 2013, 3:43 p.m.
On Wed, Apr 10, 2013 at 04:37:11PM +0100, Burton, Ross wrote:
> Hi Nicolas,
> 
> On 10 April 2013 16:14, Nicolas Dechesne <ndec@linaro.org> wrote:
> > then, what I could do is a patch serie where patch 1/2 introduces the
> > INC_PR with "r0", and patch 2/2 fixes gupnp and increments INC_PR to
> > 'r1'.
> 
> Exactly that.
> 
> > also, is that worthwhile to add the INC_PR in all other recipes in the
> > gupnp folder ? or just in gupnp recipe for now?
> 
> Do them all, might as well.

Is it important now, when PR bumps are not strictly required?

There were more dangerous changes without PR bumps included in last
months.

Patch

diff --git a/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
b/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
index f793236..f7c382a 100644
--- a/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
+++ b/meta-multimedia/recipes-connectivity/gupnp/gupnp.inc
@@ -2,6 +2,8 @@  SUMMARY = "UPnP framework"
 DESCRIPTION = "GUPnP is an elegant, object-oriented open source
framework for creating UPnP  devices and control points, written in C
using G
 LICENSE = "LGPLv2+"

+INC_PR = "r0"
+
 DEPENDS = "e2fsprogs gssdp libsoup-2.4 libxml2 gobject-introspection-stub"

 require no-vala.inc
diff --git a/meta-multimedia/recipes-connectivity/gupnp/gupnp_0.18.4.bb
b/meta-multimedia/recipes-connectivity/gupnp/gupnp_0.18.4.bb
index 4fb1d05..5e6ea35 100644
--- a/meta-multimedia/recipes-connectivity/gupnp/gupnp_0.18.4.bb
+++ b/meta-multimedia/recipes-connectivity/gupnp/gupnp_0.18.4.bb
@@ -1,5 +1,7 @@ 
 require gupnp.inc

+PR = "${INC_PR}.0"
+
 SRC_URI = "http://download.gnome.org/sources/${BPN}/0.18/${BPN}-${PV}.tar.xz"
 SRC_URI[md5sum] = "0e15fa26be7b1a0255e6dec07c285527"
 SRC_URI[sha256sum] =