Patchwork [meta-fsl-arm-extra,6/6] wandboard-solo: Add machine configuration

login
register
mail settings
Submitter Otavio Salvador
Date April 9, 2013, 5:04 p.m.
Message ID <1365527093-12139-6-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/47757/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 9, 2013, 5:04 p.m.
The kernel configuration is the same for Dual and Solo variants; to
fix it, we move the Dual defconfig to common directory avoiding
duplication.

Change-Id: I5d4b304c9980115318fdda75a6dc623783cb5cf7
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 conf/machine/wandboard-solo.conf                       | 18 ++++++++++++++++++
 .../{wandboard-dual => }/defconfig                     |  0
 2 files changed, 18 insertions(+)
 create mode 100644 conf/machine/wandboard-solo.conf
 rename recipes-kernel/linux/linux-wandboard-3.0.35/{wandboard-dual => }/defconfig (100%)

diff --git a/recipes-kernel/linux/linux-wandboard-3.0.35/wandboard-dual/defconfig b/recipes-kernel/linux/linux-wandboard-3.0.35/defconfig
similarity index 100%
rename from recipes-kernel/linux/linux-wandboard-3.0.35/wandboard-dual/defconfig
rename to recipes-kernel/linux/linux-wandboard-3.0.35/defconfig
Otavio Salvador - April 9, 2013, 5:52 p.m.
[ Adding mailing list and Fabio ]

On Tue, Apr 9, 2013 at 2:37 PM, John Weber <rjohnweber@gmail.com> wrote:
> Hi Otavio - thanks for the doing this!  Some comments below.

You're welcome.

This patch is indeed not yet ready for merging ... read bellow ...

> On Tue Apr  9 12:04:53 2013, Otavio Salvador wrote:
>>
>> The kernel configuration is the same for Dual and Solo variants; to
>> fix it, we move the Dual defconfig to common directory avoiding
>> duplication.
>>
>> Change-Id: I5d4b304c9980115318fdda75a6dc623783cb5cf7
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>>   conf/machine/wandboard-solo.conf                       | 18
>> ++++++++++++++++++
>>   .../{wandboard-dual => }/defconfig                     |  0
>>   2 files changed, 18 insertions(+)
>>   create mode 100644 conf/machine/wandboard-solo.conf
>>   rename recipes-kernel/linux/linux-wandboard-3.0.35/{wandboard-dual =>
>> }/defconfig (100%)
>>
>> diff --git a/conf/machine/wandboard-solo.conf
>> b/conf/machine/wandboard-solo.conf
>> new file mode 100644
>> index 0000000..0816b59
>> --- /dev/null
>> +++ b/conf/machine/wandboard-solo.conf
>> @@ -0,0 +1,18 @@
>> +#@TYPE: Machine
>> +#@NAME: i.MX6 Wandboard Solo
>> +#@DESCRIPTION: Machine configuration for i.MX6 Wandboard Solo
>> +
>> +include conf/machine/include/imx-base.inc
>> +include conf/machine/include/tune-cortexa9.inc
>> +
>> +SOC_FAMILY = "wandboard:mx6s:mx6"
>> +
>> +KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx6s-wandboard.dts"
>
>
> This is just for my information.  I don't think the 3.0.35 kernel makes use
> of device trees and there isn't a dts directory in arch/arm/boot.  So, what
> is the purpose of this line?

For linux-mainline. This is the format being used so it should match
when it is add. As we had it for the dual variant, I did the same for
solo.

Fabio, what do you think? Should we add it now or later?

>> +
>> +PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard"
>> +
>> +UBOOT_MACHINE = "wandboard_solo_config"
>> +
>> +SERIAL_CONSOLE = "115200 ttymxc0"
>> +
>> +MACHINE_FEATURES += " pci wifi bluetooth"
>
>
> The solo module does not include a wifi/bt chip.  If we include wifi, pci,
> and bluetooth then all of the utilities to support them are there, when they
> don't have to be.  Users should probably include them as part of their image
> instead of being part of the machine.

Good catch, I dropped the firmware but forgot about the feature.

>> diff --git
>> a/recipes-kernel/linux/linux-wandboard-3.0.35/wandboard-dual/defconfig
>> b/recipes-kernel/linux/linux-wandboard-3.0.35/defconfig
>> similarity index 100%
>> rename from
>> recipes-kernel/linux/linux-wandboard-3.0.35/wandboard-dual/defconfig
>> rename to recipes-kernel/linux/linux-wandboard-3.0.35/defconfig

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Fabio Estevam - April 9, 2013, 6:10 p.m.
On Tue, Apr 9, 2013 at 2:52 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:

> For linux-mainline. This is the format being used so it should match
> when it is add. As we had it for the dual variant, I did the same for
> solo.
>
> Fabio, what do you think? Should we add it now or later?

imx6dl support will appear in kernel 3.10. Initial patch was already
sent and it is available in the imx arm maintainer's tree.

imx6solo support is not ready yet. It still needs pinctrl support in
the kernel, so it will take a bit of time.

I think we should add dt support for wandboard-dual when kernel 3.10 shows up.

Patch

diff --git a/conf/machine/wandboard-solo.conf b/conf/machine/wandboard-solo.conf
new file mode 100644
index 0000000..0816b59
--- /dev/null
+++ b/conf/machine/wandboard-solo.conf
@@ -0,0 +1,18 @@ 
+#@TYPE: Machine
+#@NAME: i.MX6 Wandboard Solo
+#@DESCRIPTION: Machine configuration for i.MX6 Wandboard Solo
+
+include conf/machine/include/imx-base.inc
+include conf/machine/include/tune-cortexa9.inc
+
+SOC_FAMILY = "wandboard:mx6s:mx6"
+
+KERNEL_DEVICETREE = "${S}/arch/arm/boot/dts/imx6s-wandboard.dts"
+
+PREFERRED_PROVIDER_virtual/kernel = "linux-wandboard"
+
+UBOOT_MACHINE = "wandboard_solo_config"
+
+SERIAL_CONSOLE = "115200 ttymxc0"
+
+MACHINE_FEATURES += " pci wifi bluetooth"