Patchwork udev: changed location of udevd to /sbin/udev/udevd

login
register
mail settings
Submitter Alexandru DAMIAN
Date April 9, 2013, 3:58 p.m.
Message ID <1365523119-27605-1-git-send-email-alexandru.damian@intel.com>
Download mbox | patch
Permalink /patch/47731/
State New
Headers show

Comments

Alexandru DAMIAN - April 9, 2013, 3:58 p.m.
From: Alexandru DAMIAN <alexandru.damian@intel.com>

This ammends the init script after changing the location from
/lib to /sbin.

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
---
 meta/recipes-core/udev/udev/init |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Saul Wold - April 9, 2013, 4:07 p.m.
On 04/09/2013 08:58 AM, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>
> This ammends the init script after changing the location from
> /lib to /sbin.
>
This only fixes one location and does not make it dynamic, I will have a 
patch shortly to fix this.

Sau!

> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
> ---
>   meta/recipes-core/udev/udev/init |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
> index 95d2672..ea87d64 100644
> --- a/meta/recipes-core/udev/udev/init
> +++ b/meta/recipes-core/udev/udev/init
> @@ -15,7 +15,7 @@ export TZ=/etc/localtime
>
>   [ -d /sys/class ] || exit 1
>   [ -r /proc/mounts ] || exit 1
> -[ -x /lib/udev/udevd ] || exit 1
> +[ -x /sbin/udev/udevd ] || exit 1
>   [ -f /etc/default/udev-cache ] && . /etc/default/udev-cache
>   [ -f /etc/udev/udev.conf ] && . /etc/udev/udev.conf
>
> @@ -71,7 +71,7 @@ case "$1" in
>
>       # trigger the sorted events
>       echo -e '\000\000\000\000' > /proc/sys/kernel/hotplug
> -    /lib/udev/udevd -d
> +    /sbin/udev/udevd -d
>
>       /usr/bin/udevadm control --env=STARTUP=1
>       if [ "$not_first_boot" != "" ];then
>
Otavio Salvador - April 9, 2013, 4:35 p.m.
On Tue, Apr 9, 2013 at 1:07 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 04/09/2013 08:58 AM, Alex DAMIAN wrote:
>>
>> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>>
>> This ammends the init script after changing the location from
>> /lib to /sbin.
>>
> This only fixes one location and does not make it dynamic, I will have a
> patch shortly to fix this.

Your fix does not make it dynamic but staticly set at build time.
Please iterate over the possible alternatives, as I did in
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-core/initrdscripts?id=1b99640481882d23dc3ded41d9f2aef906f77e67

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Richard Purdie - April 9, 2013, 5:06 p.m.
On Tue, 2013-04-09 at 13:35 -0300, Otavio Salvador wrote:
> On Tue, Apr 9, 2013 at 1:07 PM, Saul Wold <sgw@linux.intel.com> wrote:
> > On 04/09/2013 08:58 AM, Alex DAMIAN wrote:
> >>
> >> From: Alexandru DAMIAN <alexandru.damian@intel.com>
> >>
> >> This ammends the init script after changing the location from
> >> /lib to /sbin.
> >>
> > This only fixes one location and does not make it dynamic, I will have a
> > patch shortly to fix this.
> 
> Your fix does not make it dynamic but staticly set at build time.
> Please iterate over the possible alternatives, as I did in
> http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-core/initrdscripts?id=1b99640481882d23dc3ded41d9f2aef906f77e67

In the case of udev itself, we don't need to do this since it knows
where it installed the binaries to.

Cheers,

Richard

Patch

diff --git a/meta/recipes-core/udev/udev/init b/meta/recipes-core/udev/udev/init
index 95d2672..ea87d64 100644
--- a/meta/recipes-core/udev/udev/init
+++ b/meta/recipes-core/udev/udev/init
@@ -15,7 +15,7 @@  export TZ=/etc/localtime
 
 [ -d /sys/class ] || exit 1
 [ -r /proc/mounts ] || exit 1
-[ -x /lib/udev/udevd ] || exit 1
+[ -x /sbin/udev/udevd ] || exit 1
 [ -f /etc/default/udev-cache ] && . /etc/default/udev-cache
 [ -f /etc/udev/udev.conf ] && . /etc/udev/udev.conf
 
@@ -71,7 +71,7 @@  case "$1" in
 
     # trigger the sorted events
     echo -e '\000\000\000\000' > /proc/sys/kernel/hotplug
-    /lib/udev/udevd -d
+    /sbin/udev/udevd -d
 
     /usr/bin/udevadm control --env=STARTUP=1
     if [ "$not_first_boot" != "" ];then