Patchwork bluez4: add readline dependency

login
register
mail settings
Submitter Cristian Iorga
Date April 9, 2013, 2:58 p.m.
Message ID <969F26A8BAB325438E7EB80D3C3134FB16220ADC@IRSMSX102.ger.corp.intel.com>
Download mbox | patch
Permalink /patch/47723/
State New
Headers show

Comments

Cristian Iorga - April 9, 2013, 2:58 p.m.
GATT seems to be related only to BT 4.0, Bluetooth Low Energy (LE).

However, it will be useful once Bluez5 will be in place.

I say we should add it.



Regards,

Cristian


From: Damian, Alexandru [mailto:alexandru.damian@intel.com]

Sent: Tuesday, April 09, 2013 5:53 PM
To: Saul Wold
Cc: Paul Eggleton; Khem Raj; Iorga, Cristian; Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH] bluez4: add readline dependency

I guess it's up to the patch maintainer to decide :).

Alex

On Mon, Apr 8, 2013 at 8:57 PM, Saul Wold <sgw@linux.intel.com<mailto:sgw@linux.intel.com>> wrote:
On 04/08/2013 05:56 AM, Alex DAMIAN wrote:
From: Alexandru DAMIAN <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>>


bluez4 uses readline to be build, but the dependency is not listed
This is listed in the configuration log.
So we add it.
As far as I can tell it's needed only for gatttool, is this a tool that we need / want to provide for bluez?

This seems to be a tools for viewing the Generic Attribute Profile (GATT).

It can be disabled by setting "ac_cv_lib_readline_main=no"


Sau!


Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com<mailto:alexandru.damian@intel.com>>

---
  meta/recipes-connectivity/bluez/bluez4.inc |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Ross Burton - April 9, 2013, 3:04 p.m.
On 9 April 2013 15:58, Iorga, Cristian <cristian.iorga@intel.com> wrote:
> GATT seems to be related only to BT 4.0, Bluetooth Low Energy (LE).
>
> However, it will be useful once Bluez5 will be in place.
>
> I say we should add it.

As it's a tool that does introduce extra dependencies, we can easily
packageconfig it to let people chose.

Ross
Saul Wold - April 9, 2013, 3:11 p.m.
On 04/09/2013 08:04 AM, Burton, Ross wrote:
> On 9 April 2013 15:58, Iorga, Cristian <cristian.iorga@intel.com> wrote:
>> GATT seems to be related only to BT 4.0, Bluetooth Low Energy (LE).
>>
>> However, it will be useful once Bluez5 will be in place.
>>
>> I say we should add it.
>
> As it's a tool that does introduce extra dependencies, we can easily
> packageconfig it to let people chose.
>

As Mark also said this, I would agree this should be a PACKAGECONFIG and 
the tool packaged in it's own package.

Sau!

> Ross
>
>

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc

index bff24d3..42d82b0 100644

--- a/meta/recipes-connectivity/bluez/bluez4.inc

+++ b/meta/recipes-connectivity/bluez/bluez4.inc

@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \

                      file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
                      file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
                      file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191<file:///\\COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e%20\%0b %20 %20 %20 %20 %20 %20 %20 %20 %20 %20 %20file:\COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09%20\%0b %20 %20 %20 %20 %20 %20 %20 %20 %20 %20 %20file:\src\main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e%20\%0b %20 %20 %20 %20 %20 %20 %20 %20 %20 %20 %20file:\sbc\sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191>"
-DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck"

+DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline"

  RDEPENDS_${PN}-dev = "bluez-hcidump"

  PACKAGECONFIG ??= "\