Patchwork [meta-fsl-ppc] testfloat: add COMPATIBLE_MACHINE to limit the supported targets

login
register
mail settings
Submitter Ting Liu
Date April 9, 2013, 9:50 a.m.
Message ID <1365501023-26286-1-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/47683/
State Rejected
Delegated to: Zhenhua Luo
Headers show

Comments

Ting Liu - April 9, 2013, 9:50 a.m.
From: Chunrong Guo <B40290@freescale.com>

Signed-off-by: Chunrong Guo <B40290@freescale.com>
Signed-off-by: Ting Liu <b28495@freescale.com>
---
 recipes-test/testfloat/testfloat_2a.bb |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Otavio Salvador - April 9, 2013, 11:18 a.m.
On Tue, Apr 9, 2013 at 6:50 AM,  <b28495@freescale.com> wrote:
...
> +COMPATIBLE_MACHINE = "(p1010|p1020|p1021|p1022|p1023|p1024|p1025|p2020|mpc8536|mpc8544|mpc8548|mpc8572)"
> +
>  S = "${WORKDIR}/TestFloat-2a"
...

From Yocto point of view, the patch is OK. I am a bit concerned /why/
you wish to limit this to these machine?

This float test is not generic? In case it is, this could be allowed
to be used by any machine and maybe be send to meta-oe and shared
among all users.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Matthew McClintock - April 9, 2013, 2:29 p.m.
On Tue, Apr 9, 2013 at 6:18 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Tue, Apr 9, 2013 at 6:50 AM,  <b28495@freescale.com> wrote:
> ...
>> +COMPATIBLE_MACHINE = "(p1010|p1020|p1021|p1022|p1023|p1024|p1025|p2020|mpc8536|mpc8544|mpc8548|mpc8572)"
>> +
>>  S = "${WORKDIR}/TestFloat-2a"
> ...
>
> From Yocto point of view, the patch is OK. I am a bit concerned /why/
> you wish to limit this to these machine?
>
> This float test is not generic? In case it is, this could be allowed
> to be used by any machine and maybe be send to meta-oe and shared
> among all users.

Precisely, I think this patch is wrong. It should also be moved out of
this layer.

-M

Patch

diff --git a/recipes-test/testfloat/testfloat_2a.bb b/recipes-test/testfloat/testfloat_2a.bb
index ece8c18..90427fd 100644
--- a/recipes-test/testfloat/testfloat_2a.bb
+++ b/recipes-test/testfloat/testfloat_2a.bb
@@ -1,6 +1,7 @@ 
 DESCRIPTION = "A program for testing floating-point implementation"
 SECTION = "test"
 LICENSE = "Hauser TestFloat"
+PR = "r1"
 
 LIC_FILES_CHKSUM = "file://testfloat/testfloat.txt;beginline=87;endline=95;md5=bdb2e8111838a48015c29bd97f5b6145"
 
@@ -15,6 +16,8 @@  SRC_URI[TestFloat.sha256sum] = "84d14aa42adefbda2ec9708b42946f7fa59f93689b042684
 SRC_URI[SoftFloat.md5sum] = "b4a58b5c941f1a2317e4c2500086e3fa"
 SRC_URI[SoftFloat.sha256sum] = "89d14b55113a2ba8cbda7011443ba1d298d381c89d939515d56c5f18f2febf81"
 
+COMPATIBLE_MACHINE = "(p1010|p1020|p1021|p1022|p1023|p1024|p1025|p2020|mpc8536|mpc8544|mpc8548|mpc8572)"
+
 S = "${WORKDIR}/TestFloat-2a"
 
 do_unpack2(){