Patchwork bluez4: add readline dependency

login
register
mail settings
Submitter Alexandru DAMIAN
Date April 8, 2013, 12:56 p.m.
Message ID <1365425799-25357-1-git-send-email-alexandru.damian@intel.com>
Download mbox | patch
Permalink /patch/47619/
State Accepted
Commit 90d38aba77d3790dde731a7b18474168da416986
Headers show

Comments

Alexandru DAMIAN - April 8, 2013, 12:56 p.m.
From: Alexandru DAMIAN <alexandru.damian@intel.com>

bluez4 uses readline to be build, but the dependency is not listed
This is listed in the configuration log.
So we add it.

Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
---
 meta/recipes-connectivity/bluez/bluez4.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - April 8, 2013, 5:57 p.m.
On 04/08/2013 05:56 AM, Alex DAMIAN wrote:
> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>
> bluez4 uses readline to be build, but the dependency is not listed
> This is listed in the configuration log.
> So we add it.
>
As far as I can tell it's needed only for gatttool, is this a tool that 
we need / want to provide for bluez?

This seems to be a tools for viewing the Generic Attribute Profile (GATT).

It can be disabled by setting "ac_cv_lib_readline_main=no"


Sau!


> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
> ---
>   meta/recipes-connectivity/bluez/bluez4.inc |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
> index bff24d3..42d82b0 100644
> --- a/meta/recipes-connectivity/bluez/bluez4.inc
> +++ b/meta/recipes-connectivity/bluez/bluez4.inc
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>                       file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>                       file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
>                       file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
> -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck"
> +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline"
>   RDEPENDS_${PN}-dev = "bluez-hcidump"
>
>   PACKAGECONFIG ??= "\
>
Mark Hatle - April 8, 2013, 6:19 p.m.
On 4/8/13 12:57 PM, Saul Wold wrote:
> On 04/08/2013 05:56 AM, Alex DAMIAN wrote:
>> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>>
>> bluez4 uses readline to be build, but the dependency is not listed
>> This is listed in the configuration log.
>> So we add it.
>>
> As far as I can tell it's needed only for gatttool, is this a tool that
> we need / want to provide for bluez?
>
> This seems to be a tools for viewing the Generic Attribute Profile (GATT).
>
> It can be disabled by setting "ac_cv_lib_readline_main=no"

We -really- want to avoid readline if possible, as it brings in GPLv3 
dependencies into the system.

If that tool is generically useful, I'd suggest a PACKAGECONFIG setting then.

--Mark

>
> Sau!
>
>
>> Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
>> ---
>>    meta/recipes-connectivity/bluez/bluez4.inc |    2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
>> index bff24d3..42d82b0 100644
>> --- a/meta/recipes-connectivity/bluez/bluez4.inc
>> +++ b/meta/recipes-connectivity/bluez/bluez4.inc
>> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
>>                        file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
>>                        file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
>>                        file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
>> -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck"
>> +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline"
>>    RDEPENDS_${PN}-dev = "bluez-hcidump"
>>
>>    PACKAGECONFIG ??= "\
>>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Alexandru DAMIAN - April 9, 2013, 2:52 p.m.
I guess it's up to the patch maintainer to decide :).

Alex

On Mon, Apr 8, 2013 at 8:57 PM, Saul Wold <sgw@linux.intel.com> wrote:

> On 04/08/2013 05:56 AM, Alex DAMIAN wrote:
>
>> From: Alexandru DAMIAN <alexandru.damian@intel.com>
>>
>> bluez4 uses readline to be build, but the dependency is not listed
>> This is listed in the configuration log.
>> So we add it.
>>
>>  As far as I can tell it's needed only for gatttool, is this a tool that
> we need / want to provide for bluez?
>
> This seems to be a tools for viewing the Generic Attribute Profile (GATT).
>
> It can be disabled by setting "ac_cv_lib_readline_main=no"
>
>
> Sau!
>
>
>
>  Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
>> ---
>>   meta/recipes-connectivity/**bluez/bluez4.inc |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/**bluez/bluez4.inc
>> b/meta/recipes-connectivity/**bluez/bluez4.inc
>> index bff24d3..42d82b0 100644
>> --- a/meta/recipes-connectivity/**bluez/bluez4.inc
>> +++ b/meta/recipes-connectivity/**bluez/bluez4.inc
>> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=**
>> 12f884d2ae1ff87c09e5b7ccc2c4ca**7e \
>>                       file://COPYING.LIB;md5=**
>> fb504b67c50331fc78734fed90fb0e**09 \
>>                       file://src/main.c;beginline=1;**endline=24;md5=**
>> 9bc54b93cd7e17bf03f52513f39f92**6e \
>>                       file://sbc/sbc.c;beginline=1;**endline=25;md5=**
>> 1a40781ed30d50d8639323a184aeb1**91"
>> -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck"
>> +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline"
>>   RDEPENDS_${PN}-dev = "bluez-hcidump"
>>
>>   PACKAGECONFIG ??= "\
>>
>>
Javier Viguera - April 22, 2013, 5:15 p.m.
Hi all,

On 08/04/13 14:56, Alex DAMIAN wrote:
> -DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck"
> +DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline"

I saw this patch got included in oe-core and poky *master* branch as-is 
(not using PACKAGECONFIG).

I was bitten by this problem using *danny* branches as well.

Any chance that this fix gets also cherry-picked to danny?

-
Javier Viguera
Software Engineer
Digi International® Spain S.A.U.

Patch

diff --git a/meta/recipes-connectivity/bluez/bluez4.inc b/meta/recipes-connectivity/bluez/bluez4.inc
index bff24d3..42d82b0 100644
--- a/meta/recipes-connectivity/bluez/bluez4.inc
+++ b/meta/recipes-connectivity/bluez/bluez4.inc
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
                     file://COPYING.LIB;md5=fb504b67c50331fc78734fed90fb0e09 \
                     file://src/main.c;beginline=1;endline=24;md5=9bc54b93cd7e17bf03f52513f39f926e \
                     file://sbc/sbc.c;beginline=1;endline=25;md5=1a40781ed30d50d8639323a184aeb191"
-DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck"
+DEPENDS = "udev libusb dbus-glib glib-2.0 libcheck readline"
 RDEPENDS_${PN}-dev = "bluez-hcidump"
 
 PACKAGECONFIG ??= "\