Patchwork [meta-handheld,v2,0/1] Pull request 20130407

login
register
mail settings
Submitter Apelete Seketeli
Date April 7, 2013, 9:21 p.m.
Message ID <cover.1365368283.git.apelete@seketeli.net>
Download mbox
Permalink /patch/47593/
State Superseded, archived
Headers show

Pull-request

git://seketeli.fr/~apelete/meta-handheld.git fix-nn-kernel-build

Comments

Apelete Seketeli - April 7, 2013, 9:21 p.m.
Hello,

On Friday 05 April 2013, Apelete Seketeli wrote:
> Following the patches I sent to the meta-handheld layer a few days ago
> to add machine support for the Ben Nanonote, I found out that the
> corresponding kernel recipe fails to build on oe-core (builds fine on
> oe-classic).
> A few settings were missing and, more importantly, the version of gcc
> in oe-core seems to enable the -Wunused-but-set-variable switch, which
> makes it error on many variables that were indeed 'unused but
> set'. After trying to solve this issue the easy way, by setting
> 'CFLAGS=-Wno-error=unused-but-set-variable -Wno-error=unused-but-set-parameter'
> to no avail, I chose to annotate the aforementioned variables in the
> kernel code with __attribute__((__unused__)).
>
> The patches that come as a follow-up of this message are what it's all
> about; sorry for the inconvenience in the first place.

I took the time to fix the patch for the GCC 4.6 build issue. Instead
of just fixing the issue on my own, I looked at how it was done in the
mainline kernel and backported the fixes through a new patch named
fix-gcc-4.6.0-build-errors.patch; this approach seems more logical to
me.
While I was at it, also removed "[PATCH 2/2] ben-nanonote: add
DEFAULTTUNE to machine configuration" from the patchset, following
Paul's advice.

Tested by building linux-jlime-ben-nanonote from scratch on top of
master branch.
Please pull into meta-handheld.

The following changes since commit 913735dce388f660dfbbe288ed736e12ed48c8d8:

  linux-yocto-tiny-kexecboot_3.2: removed unused, non-working MTD-RW patch (2013-04-06 00:25:08 +0100)

are available in the git repository at:

  git://seketeli.fr/~apelete/meta-handheld.git fix-nn-kernel-build

Apelete Seketeli (1):
  linux-jlime-ben-nanonote: fix GCC-4.6 build errors

 .../fix-gcc-4.6.0-build-errors.patch               |  114 ++++++++++++++++++++
 .../linux/linux-jlime-ben-nanonote_2.6.36.bb       |    5 +-
 2 files changed, 118 insertions(+), 1 deletion(-)
 create mode 100644 recipes-kernel/linux/linux-jlime-ben-nanonote-2.6.36/fix-gcc-4.6.0-build-errors.patch