Patchwork [meta-fsl-ppc,1/2] testfloat: add COMPATIBLE_MACHINE to limit the supported targets

login
register
mail settings
Submitter Ting Liu
Date April 7, 2013, 7:39 a.m.
Message ID <1365320392-17227-2-git-send-email-b28495@freescale.com>
Download mbox | patch
Permalink /patch/47585/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Ting Liu - April 7, 2013, 7:39 a.m.
From: Chunrong Guo <B40290@freescale.com>

Signed-off-by: Chunrong Guo <B40290@freescale.com>
---
 recipes-test/testfloat/testfloat_2a.bb |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Otavio Salvador - April 8, 2013, 12:22 p.m.
On Sun, Apr 7, 2013 at 4:39 AM,  <b28495@freescale.com> wrote:
> From: Chunrong Guo <B40290@freescale.com>
>
> Signed-off-by: Chunrong Guo <B40290@freescale.com>
> ---
>  recipes-test/testfloat/testfloat_2a.bb |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/recipes-test/testfloat/testfloat_2a.bb b/recipes-test/testfloat/testfloat_2a.bb
> index ece8c18..e5f9c6e 100644
> --- a/recipes-test/testfloat/testfloat_2a.bb
> +++ b/recipes-test/testfloat/testfloat_2a.bb
> @@ -1,6 +1,7 @@
>  DESCRIPTION = "A program for testing floating-point implementation"
>  SECTION = "test"
>  LICENSE = "Hauser TestFloat"
> +PR = "r1"
>
>  LIC_FILES_CHKSUM = "file://testfloat/testfloat.txt;beginline=87;endline=95;md5=bdb2e8111838a48015c29bd97f5b6145"
>
> @@ -15,6 +16,8 @@ SRC_URI[TestFloat.sha256sum] = "84d14aa42adefbda2ec9708b42946f7fa59f93689b042684
>  SRC_URI[SoftFloat.md5sum] = "b4a58b5c941f1a2317e4c2500086e3fa"
>  SRC_URI[SoftFloat.sha256sum] = "89d14b55113a2ba8cbda7011443ba1d298d381c89d939515d56c5f18f2febf81"
>
> +COMPATIBLE_MACHINE = "(p1023rds|p1020rdb|p1020mbg|p1020utm|p1021rdb|p1022ds|p1024rdb|p1025rdb|p1010rdb|p2020ds|p2020rdb|mpc8536ds|mpc8544ds|mpc8548cds|mpc8572ds)"
> +

Instead of listing every supported board you might have it use
SOC_FAMILY and list the SoC which are supported.

What do you think?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Matthew McClintock - April 8, 2013, 2:20 p.m.
On Mon, Apr 8, 2013 at 7:22 AM, Otavio Salvador <otavio@ossystems.com.br>wrote:

> On Sun, Apr 7, 2013 at 4:39 AM,  <b28495@freescale.com> wrote:
> > From: Chunrong Guo <B40290@freescale.com>
> >
> > Signed-off-by: Chunrong Guo <B40290@freescale.com>
> > ---
> >  recipes-test/testfloat/testfloat_2a.bb |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/recipes-test/testfloat/testfloat_2a.bbb/recipes-test/testfloat/
> testfloat_2a.bb
> > index ece8c18..e5f9c6e 100644
> > --- a/recipes-test/testfloat/testfloat_2a.bb
> > +++ b/recipes-test/testfloat/testfloat_2a.bb
> > @@ -1,6 +1,7 @@
> >  DESCRIPTION = "A program for testing floating-point implementation"
> >  SECTION = "test"
> >  LICENSE = "Hauser TestFloat"
> > +PR = "r1"
> >
> >  LIC_FILES_CHKSUM =
> "file://testfloat/testfloat.txt;beginline=87;endline=95;md5=bdb2e8111838a48015c29bd97f5b6145"
> >
> > @@ -15,6 +16,8 @@ SRC_URI[TestFloat.sha256sum] =
> "84d14aa42adefbda2ec9708b42946f7fa59f93689b042684
> >  SRC_URI[SoftFloat.md5sum] = "b4a58b5c941f1a2317e4c2500086e3fa"
> >  SRC_URI[SoftFloat.sha256sum] =
> "89d14b55113a2ba8cbda7011443ba1d298d381c89d939515d56c5f18f2febf81"
> >
> > +COMPATIBLE_MACHINE =
> "(p1023rds|p1020rdb|p1020mbg|p1020utm|p1021rdb|p1022ds|p1024rdb|p1025rdb|p1010rdb|p2020ds|p2020rdb|mpc8536ds|mpc8544ds|mpc8548cds|mpc8572ds)"
> > +
>
> Instead of listing every supported board you might have it use
> SOC_FAMILY and list the SoC which are supported.
>
> What do you think?


Isn't the point of this to test float on any machine? Why would you even
limit this to specific machines? Is there a compilation error?

-M
Ting Liu - April 9, 2013, 9:11 a.m.
From: Matthew McClintock [mailto:msm-oss@mcclintock.net]
Sent: Monday, April 08, 2013 10:20 PM
To: Otavio Salvador
Cc: Liu Ting-B28495; meta-freescale@yoctoproject.org
Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH 1/2] testfloat: add COMPATIBLE_MACHINE to limit the supported targets

On Mon, Apr 8, 2013 at 7:22 AM, Otavio Salvador <otavio@ossystems.com.br<mailto:otavio@ossystems.com.br>> wrote:
On Sun, Apr 7, 2013 at 4:39 AM,  <b28495@freescale.com<mailto:b28495@freescale.com>> wrote:
> From: Chunrong Guo <B40290@freescale.com<mailto:B40290@freescale.com>>
>
> Signed-off-by: Chunrong Guo <B40290@freescale.com<mailto:B40290@freescale.com>>
> ---
>  recipes-test/testfloat/testfloat_2a.bb<http://testfloat_2a.bb> |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/recipes-test/testfloat/testfloat_2a.bb<http://testfloat_2a.bb> b/recipes-test/testfloat/testfloat_2a.bb<http://testfloat_2a.bb>
> index ece8c18..e5f9c6e 100644
> --- a/recipes-test/testfloat/testfloat_2a.bb<http://testfloat_2a.bb>
> +++ b/recipes-test/testfloat/testfloat_2a.bb<http://testfloat_2a.bb>
> @@ -1,6 +1,7 @@
>  DESCRIPTION = "A program for testing floating-point implementation"
>  SECTION = "test"
>  LICENSE = "Hauser TestFloat"
> +PR = "r1"
>
>  LIC_FILES_CHKSUM = "file://testfloat/testfloat.txt;beginline=87;endline=95;md5=bdb2e8111838a48015c29bd97f5b6145"
>
> @@ -15,6 +16,8 @@ SRC_URI[TestFloat.sha256sum] = "84d14aa42adefbda2ec9708b42946f7fa59f93689b042684
>  SRC_URI[SoftFloat.md5sum] = "b4a58b5c941f1a2317e4c2500086e3fa"
>  SRC_URI[SoftFloat.sha256sum] = "89d14b55113a2ba8cbda7011443ba1d298d381c89d939515d56c5f18f2febf81"
>
> +COMPATIBLE_MACHINE = "(p1023rds|p1020rdb|p1020mbg|p1020utm|p1021rdb|p1022ds|p1024rdb|p1025rdb|p1010rdb|p2020ds|p2020rdb|mpc8536ds|mpc8544ds|mpc8548cds|mpc8572ds)"
> +
Instead of listing every supported board you might have it use
SOC_FAMILY and list the SoC which are supported.

What do you think?

Isn't the point of this to test float on any machine? Why would you even limit this to specific machines? Is there a compilation error?
[Ting] Support for e500mc/e5500/e6500 targets was not added. We want to limit the supported FSL machines to avoid misuse.
-M
Ting Liu - April 9, 2013, 9:37 a.m.
> -----Original Message-----
> From: otavio.salvador@gmail.com [mailto:otavio.salvador@gmail.com] On
> Behalf Of Otavio Salvador
> Sent: Monday, April 08, 2013 8:23 PM
> To: Liu Ting-B28495
> Cc: meta-freescale@yoctoproject.org
> Subject: Re: [meta-freescale] [meta-fsl-ppc][PATCH 1/2] testfloat: add
> COMPATIBLE_MACHINE to limit the supported targets
> 
> On Sun, Apr 7, 2013 at 4:39 AM,  <b28495@freescale.com> wrote:
> > From: Chunrong Guo <B40290@freescale.com>
> >
> > Signed-off-by: Chunrong Guo <B40290@freescale.com>
> > ---
> >  recipes-test/testfloat/testfloat_2a.bb |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> >
> > diff --git a/recipes-test/testfloat/testfloat_2a.bb
> > b/recipes-test/testfloat/testfloat_2a.bb
> > index ece8c18..e5f9c6e 100644
> > --- a/recipes-test/testfloat/testfloat_2a.bb
> > +++ b/recipes-test/testfloat/testfloat_2a.bb
> > @@ -1,6 +1,7 @@
> >  DESCRIPTION = "A program for testing floating-point implementation"
> >  SECTION = "test"
> >  LICENSE = "Hauser TestFloat"
> > +PR = "r1"
> >
> >  LIC_FILES_CHKSUM =
> "file://testfloat/testfloat.txt;beginline=87;endline=95;md5=bdb2e8111838a
> 48015c29bd97f5b6145"
> >
> > @@ -15,6 +16,8 @@ SRC_URI[TestFloat.sha256sum] =
> > "84d14aa42adefbda2ec9708b42946f7fa59f93689b042684
> >  SRC_URI[SoftFloat.md5sum] = "b4a58b5c941f1a2317e4c2500086e3fa"
> >  SRC_URI[SoftFloat.sha256sum] =
> "89d14b55113a2ba8cbda7011443ba1d298d381c89d939515d56c5f18f2febf81"
> >
> > +COMPATIBLE_MACHINE =
> "(p1023rds|p1020rdb|p1020mbg|p1020utm|p1021rdb|p1022ds|p1024rdb|p1025rdb|
> p1010rdb|p2020ds|p2020rdb|mpc8536ds|mpc8544ds|mpc8548cds|mpc8572ds)"
> > +
> 
> Instead of listing every supported board you might have it use SOC_FAMILY
> and list the SoC which are supported.
> 
> What do you think?
> 

Yes, right. The list can be much simpler if we use SOC_FAMILY.
Thanks for your good suggestion. will generate new patch.

-Ting

> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-test/testfloat/testfloat_2a.bb b/recipes-test/testfloat/testfloat_2a.bb
index ece8c18..e5f9c6e 100644
--- a/recipes-test/testfloat/testfloat_2a.bb
+++ b/recipes-test/testfloat/testfloat_2a.bb
@@ -1,6 +1,7 @@ 
 DESCRIPTION = "A program for testing floating-point implementation"
 SECTION = "test"
 LICENSE = "Hauser TestFloat"
+PR = "r1"
 
 LIC_FILES_CHKSUM = "file://testfloat/testfloat.txt;beginline=87;endline=95;md5=bdb2e8111838a48015c29bd97f5b6145"
 
@@ -15,6 +16,8 @@  SRC_URI[TestFloat.sha256sum] = "84d14aa42adefbda2ec9708b42946f7fa59f93689b042684
 SRC_URI[SoftFloat.md5sum] = "b4a58b5c941f1a2317e4c2500086e3fa"
 SRC_URI[SoftFloat.sha256sum] = "89d14b55113a2ba8cbda7011443ba1d298d381c89d939515d56c5f18f2febf81"
 
+COMPATIBLE_MACHINE = "(p1023rds|p1020rdb|p1020mbg|p1020utm|p1021rdb|p1022ds|p1024rdb|p1025rdb|p1010rdb|p2020ds|p2020rdb|mpc8536ds|mpc8544ds|mpc8548cds|mpc8572ds)"
+
 S = "${WORKDIR}/TestFloat-2a"
 
 do_unpack2(){