Patchwork [meta-handheld,2/2] ben-nanonote: add DEFAULTTUNE to machine configuration

login
register
mail settings
Submitter Apelete Seketeli
Date April 5, 2013, 5:37 a.m.
Message ID <001217b18cb77bef28e080695cac129da1800937.1365116038.git.apelete@seketeli.net>
Download mbox | patch
Permalink /patch/47481/
State Rejected, archived
Headers show

Comments

Apelete Seketeli - April 5, 2013, 5:37 a.m.
Add DEFAULTTUNE to machine configuration to ensure that the correct
tune features are selected by default.

Signed-off-by: Apelete Seketeli <apelete@seketeli.net>
---
 conf/machine/ben-nanonote.conf |    1 +
 1 file changed, 1 insertion(+)
Paul Eggleton - April 5, 2013, 6:57 a.m.
Hi Apelete,

On Friday 05 April 2013 07:37:55 Apelete Seketeli wrote:
> Add DEFAULTTUNE to machine configuration to ensure that the correct
> tune features are selected by default.
> 
> Signed-off-by: Apelete Seketeli <apelete@seketeli.net>
> ---
>  conf/machine/ben-nanonote.conf |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/conf/machine/ben-nanonote.conf b/conf/machine/ben-nanonote.conf
> index 1ce5815..275dff9 100644
> --- a/conf/machine/ben-nanonote.conf
> +++ b/conf/machine/ben-nanonote.conf
> @@ -3,6 +3,7 @@
>  #@DESCRIPTION: Machine configuration for the Qi-Hardware's Ben Nanonote
> 
>  require conf/machine/include/tune-mips32.inc
> +DEFAULTTUNE = "mips32el-nf"
> 
>  PREFERRED_PROVIDER_virtual/kernel = "linux-jlime-ben-nanonote"

There was a discussion just the other day on this mailing list; setting 
DEFAULTTUNE is considered the province of distro configuration and thus 
shouldn't be in the machine config:

http://lists.linuxtogo.org/pipermail/openembedded-devel/2013-April/044719.html

Cheers,
Paul

Patch

diff --git a/conf/machine/ben-nanonote.conf b/conf/machine/ben-nanonote.conf
index 1ce5815..275dff9 100644
--- a/conf/machine/ben-nanonote.conf
+++ b/conf/machine/ben-nanonote.conf
@@ -3,6 +3,7 @@ 
 #@DESCRIPTION: Machine configuration for the Qi-Hardware's Ben Nanonote
 
 require conf/machine/include/tune-mips32.inc
+DEFAULTTUNE = "mips32el-nf"
 
 PREFERRED_PROVIDER_virtual/kernel = "linux-jlime-ben-nanonote"