Patchwork [meta-fsl-arm,2/3] xf86-video-imxfb-vivante: Fix build with new Vivante GPU packaging

login
register
mail settings
Submitter Otavio Salvador
Date April 4, 2013, 8:45 p.m.
Message ID <1365108305-17270-2-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/47455/
State Changes Requested
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - April 4, 2013, 8:45 p.m.
The new Vivante GPU packages remove the backend suffix from libraries
so the LDFLAGS ought to be removed for the build to succeed.

Change-Id: I5f75880f6a84f605643a1c70aa5e90a0e7e4c4c8
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
Fabio Estevam - April 4, 2013, 9:10 p.m.
On Thu, Apr 4, 2013 at 5:45 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> The new Vivante GPU packages remove the backend suffix from libraries

What does "new Vivante GPU packages" mean? Could you please be more
specific as to which version you are referring to?
Otavio Salvador - April 4, 2013, 9:17 p.m.
On Thu, Apr 4, 2013 at 6:10 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Apr 4, 2013 at 5:45 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> The new Vivante GPU packages remove the backend suffix from libraries
>
> What does "new Vivante GPU packages" mean? Could you please be more
> specific as to which version you are referring to?

The package split done in previous commit. Do you have a suggestion
how to make it more clear?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Fabio Estevam - April 4, 2013, 9:31 p.m.
On Thu, Apr 4, 2013 at 6:17 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Thu, Apr 4, 2013 at 6:10 PM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Thu, Apr 4, 2013 at 5:45 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> The new Vivante GPU packages remove the backend suffix from libraries
>>
>> What does "new Vivante GPU packages" mean? Could you please be more
>> specific as to which version you are referring to?
>
> The package split done in previous commit. Do you have a suggestion
> how to make it more clear?

Ok, I understand now after your explanation.

Initially I thought you were referring to GPU package version scheme,
like 1.1.0.

If commit (1/3) introduces a build error without this one (2/3),
shouldn't 2/3 be part of 1/3 to avoid the build breakage?
Otavio Salvador - April 4, 2013, 9:47 p.m.
On Thu, Apr 4, 2013 at 6:31 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Apr 4, 2013 at 6:17 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Thu, Apr 4, 2013 at 6:10 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>> On Thu, Apr 4, 2013 at 5:45 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>>> The new Vivante GPU packages remove the backend suffix from libraries
>>>
>>> What does "new Vivante GPU packages" mean? Could you please be more
>>> specific as to which version you are referring to?
>>
>> The package split done in previous commit. Do you have a suggestion
>> how to make it more clear?
>
> Ok, I understand now after your explanation.
>
> Initially I thought you were referring to GPU package version scheme,
> like 1.1.0.
>
> If commit (1/3) introduces a build error without this one (2/3),
> shouldn't 2/3 be part of 1/3 to avoid the build breakage?

Yes; I think it makes sense but not usually done in Yocto as bisect is
not expected to be fully working in Yocto repositories so I am not
sure about how to handle it. I see pros and cons for both approaches.
What your point of view?

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Fabio Estevam - April 4, 2013, 9:54 p.m.
On Thu, Apr 4, 2013 at 6:47 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:

> Yes; I think it makes sense but not usually done in Yocto as bisect is
> not expected to be fully working in Yocto repositories so I am not
> sure about how to handle it. I see pros and cons for both approaches.
> What your point of view?

In the projects I participate it is not allowed to introduce a commit
that builds the breakage, even if it will be fixed in the subsequent
commit and I agree that this is a good practice.

Or at least your commit could be like:

"Since commit xxxxx (gpu-viv-bin-mx6q: Rework package for a single
backend use ) the backend suffix from libraries
was removed, so remove the LDFLAGS to fix the build"

Anyway, I prefer not to break things at the first place.
Otavio Salvador - April 4, 2013, 9:59 p.m.
On Thu, Apr 4, 2013 at 6:54 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Apr 4, 2013 at 6:47 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>
>> Yes; I think it makes sense but not usually done in Yocto as bisect is
>> not expected to be fully working in Yocto repositories so I am not
>> sure about how to handle it. I see pros and cons for both approaches.
>> What your point of view?
>
> In the projects I participate it is not allowed to introduce a commit
> that builds the breakage, even if it will be fixed in the subsequent
> commit and I agree that this is a good practice.
>
> Or at least your commit could be like:
>
> "Since commit xxxxx (gpu-viv-bin-mx6q: Rework package for a single
> backend use ) the backend suffix from libraries
> was removed, so remove the LDFLAGS to fix the build"
>
> Anyway, I prefer not to break things at the first place.

Ok; I agree with you. I will rework the 1/3 patch.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb
index 28491c9..6cd8a5e 100644
--- a/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb
+++ b/recipes-graphics/xorg-driver/xf86-video-imxfb-vivante_1.1.0.bb
@@ -5,7 +5,7 @@ 
 require recipes-graphics/xorg-driver/xorg-driver-video.inc
 
 PE = "3"
-PR = "${INC_PR}.2"
+PR = "${INC_PR}.3"
 
 DEPENDS += "virtual/libx11 virtual/libgal-x11 gpu-viv-bin-mx6q"
 
@@ -18,7 +18,6 @@  SRC_URI[sha256sum] = "d53216d5f9e3f7803983ac1577d83985dfda33145e4711300f4ad5cbbe
 
 EXTRA_OECONF_armv7a = " --enable-neon --disable-static"
 CFLAGS += " -I${STAGING_INCDIR}/xorg -I${STAGING_INCDIR}/drm"
-LDFLAGS += "-lm -ldl -lX11 -lGAL-x11"
 
 S = "${WORKDIR}/xserver-xorg-video-imx-viv-${PV}/EXA/"