Patchwork [meta-oe] fbset: Replace deprecated update-alternatives syntax

login
register
mail settings
Submitter Paul Barker
Date April 3, 2013, 8:11 p.m.
Message ID <1365019873-30178-1-git-send-email-paul@paulbarker.me.uk>
Download mbox | patch
Permalink /patch/47381/
State Accepted, archived
Commit b0fb477a11d24cc64a40f29dfd934b5e78f6cc7d
Headers show

Comments

Paul Barker - April 3, 2013, 8:11 p.m.
Building fbset gave the following warning:

	WARNING: fbset: Use of ALTERNATIVE_NAME is deprecated, see
		update-alternatives.bbclass for more info.

update-alternatives.bbclass states that this warning will eventually become an
error so this is worth fixing.

The use of deprecated syntax is replaced with current syntax to do the same
thing. To test that this works, a .deb package was created and the post-install
script was checked to ensure that update-alternatives would be called with the
exact same arguments as it was by the script generated by the old recipe.

Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
---
 meta-oe/recipes-support/fbset/fbset_2.1.bb |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)
Paul Barker - April 11, 2013, 2:02 p.m.
Is this patch useful?

On 3 April 2013 21:11, Paul Barker <paul@paulbarker.me.uk> wrote:
> Building fbset gave the following warning:
>
>         WARNING: fbset: Use of ALTERNATIVE_NAME is deprecated, see
>                 update-alternatives.bbclass for more info.
>
> update-alternatives.bbclass states that this warning will eventually become an
> error so this is worth fixing.
>
> The use of deprecated syntax is replaced with current syntax to do the same
> thing. To test that this works, a .deb package was created and the post-install
> script was checked to ensure that update-alternatives would be called with the
> exact same arguments as it was by the script generated by the old recipe.
>
> Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> ---
>  meta-oe/recipes-support/fbset/fbset_2.1.bb |   10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/meta-oe/recipes-support/fbset/fbset_2.1.bb b/meta-oe/recipes-support/fbset/fbset_2.1.bb
> index 12c1c94..9fe2728 100644
> --- a/meta-oe/recipes-support/fbset/fbset_2.1.bb
> +++ b/meta-oe/recipes-support/fbset/fbset_2.1.bb
> @@ -27,12 +27,10 @@ do_install() {
>          install -m 0644 ${WORKDIR}/${P}/*.8 ${D}${datadir}/man/man8
>  }
>
> -ALTERNATIVE_NAME = "fbset"
> -ALTERNATIVE_LINK = "${sbindir}/${ALTERNATIVE_NAME}"
> -ALTERNATIVE_PATH = "${sbindir}/fbset.real"
> -ALTERNATIVE_PRIORITY = "55"
> -
> -
> +ALTERNATIVE_fbset = "fbset"
> +ALTERNATIVE_LINK_NAME[fbset] = "${sbindir}/fbset"
> +ALTERNATIVE_TARGET[fbset] = "${sbindir}/fbset.real"
> +ALTERNATIVE_PRIORITY[fbset] = "55"
>
>  SRC_URI[md5sum] = "40ed9608f46d787bfb65fd1269f7f459"
>  SRC_URI[sha256sum] = "517fa062d7b2d367f931a1c6ebb2bef84907077f0ce3f0c899e34490bbea9338"
> --
> 1.7.10.4
>



--
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk
Martin Jansa - April 11, 2013, 2:11 p.m.
On Thu, Apr 11, 2013 at 03:02:44PM +0100, Paul Barker wrote:
> Is this patch useful?

Yes and already applied, thanks!

http://git.openembedded.org/meta-openembedded/commit/?id=b0fb477a11d24cc64a40f29dfd934b5e78f6cc7d

> 
> On 3 April 2013 21:11, Paul Barker <paul@paulbarker.me.uk> wrote:
> > Building fbset gave the following warning:
> >
> >         WARNING: fbset: Use of ALTERNATIVE_NAME is deprecated, see
> >                 update-alternatives.bbclass for more info.
> >
> > update-alternatives.bbclass states that this warning will eventually become an
> > error so this is worth fixing.
> >
> > The use of deprecated syntax is replaced with current syntax to do the same
> > thing. To test that this works, a .deb package was created and the post-install
> > script was checked to ensure that update-alternatives would be called with the
> > exact same arguments as it was by the script generated by the old recipe.
> >
> > Signed-off-by: Paul Barker <paul@paulbarker.me.uk>
> > ---
> >  meta-oe/recipes-support/fbset/fbset_2.1.bb |   10 ++++------
> >  1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/meta-oe/recipes-support/fbset/fbset_2.1.bb b/meta-oe/recipes-support/fbset/fbset_2.1.bb
> > index 12c1c94..9fe2728 100644
> > --- a/meta-oe/recipes-support/fbset/fbset_2.1.bb
> > +++ b/meta-oe/recipes-support/fbset/fbset_2.1.bb
> > @@ -27,12 +27,10 @@ do_install() {
> >          install -m 0644 ${WORKDIR}/${P}/*.8 ${D}${datadir}/man/man8
> >  }
> >
> > -ALTERNATIVE_NAME = "fbset"
> > -ALTERNATIVE_LINK = "${sbindir}/${ALTERNATIVE_NAME}"
> > -ALTERNATIVE_PATH = "${sbindir}/fbset.real"
> > -ALTERNATIVE_PRIORITY = "55"
> > -
> > -
> > +ALTERNATIVE_fbset = "fbset"
> > +ALTERNATIVE_LINK_NAME[fbset] = "${sbindir}/fbset"
> > +ALTERNATIVE_TARGET[fbset] = "${sbindir}/fbset.real"
> > +ALTERNATIVE_PRIORITY[fbset] = "55"
> >
> >  SRC_URI[md5sum] = "40ed9608f46d787bfb65fd1269f7f459"
> >  SRC_URI[sha256sum] = "517fa062d7b2d367f931a1c6ebb2bef84907077f0ce3f0c899e34490bbea9338"
> > --
> > 1.7.10.4
> >
> 
> 
> 
> --
> Paul Barker
> 
> Email: paul@paulbarker.me.uk
> http://www.paulbarker.me.uk
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Paul Barker - April 11, 2013, 2:46 p.m.
On 11 April 2013 15:11, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Thu, Apr 11, 2013 at 03:02:44PM +0100, Paul Barker wrote:
>> Is this patch useful?
>
> Yes and already applied, thanks!
>
> http://git.openembedded.org/meta-openembedded/commit/?id=b0fb477a11d24cc64a40f29dfd934b5e78f6cc7d
>

Apologies, I must have missed that.

--
Paul Barker

Email: paul@paulbarker.me.uk
http://www.paulbarker.me.uk

Patch

diff --git a/meta-oe/recipes-support/fbset/fbset_2.1.bb b/meta-oe/recipes-support/fbset/fbset_2.1.bb
index 12c1c94..9fe2728 100644
--- a/meta-oe/recipes-support/fbset/fbset_2.1.bb
+++ b/meta-oe/recipes-support/fbset/fbset_2.1.bb
@@ -27,12 +27,10 @@  do_install() {
         install -m 0644 ${WORKDIR}/${P}/*.8 ${D}${datadir}/man/man8
 }
 
-ALTERNATIVE_NAME = "fbset"
-ALTERNATIVE_LINK = "${sbindir}/${ALTERNATIVE_NAME}"
-ALTERNATIVE_PATH = "${sbindir}/fbset.real"
-ALTERNATIVE_PRIORITY = "55"
-
-
+ALTERNATIVE_fbset = "fbset"
+ALTERNATIVE_LINK_NAME[fbset] = "${sbindir}/fbset"
+ALTERNATIVE_TARGET[fbset] = "${sbindir}/fbset.real"
+ALTERNATIVE_PRIORITY[fbset] = "55"
 
 SRC_URI[md5sum] = "40ed9608f46d787bfb65fd1269f7f459"
 SRC_URI[sha256sum] = "517fa062d7b2d367f931a1c6ebb2bef84907077f0ce3f0c899e34490bbea9338"