Patchwork [oe] eglinfo: Add recipes for x11 and fb backends

login
register
mail settings
Submitter dv
Date April 3, 2013, 7:26 p.m.
Message ID <1365017211-17183-1-git-send-email-dv@pseudoterminal.org>
Download mbox | patch
Permalink /patch/47367/
State New
Headers show

Comments

dv - April 3, 2013, 7:26 p.m.
eglinfo is a small utility for printing out information about EGL as well
as about its client APIs, OpenGL / OpenGLES 1.x / OpenGLES 2.x / OpenVG.

Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb  | 11 ++++++
 meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb |  6 +++
 meta/recipes-graphics/eglinfo/eglinfo.inc        | 49 ++++++++++++++++++++++++
 3 files changed, 66 insertions(+)
 create mode 100644 meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
 create mode 100644 meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
 create mode 100644 meta/recipes-graphics/eglinfo/eglinfo.inc
Saul Wold - April 4, 2013, 3:41 p.m.
I am going to defer this to 1.5 when it opens up, I still need to review 
the recipe, but wanted to give you a heads up about the deferral.


Thanks
	Sau!


On 04/03/2013 12:26 PM, Carlos Rafael Giani wrote:
> eglinfo is a small utility for printing out information about EGL as well
> as about its client APIs, OpenGL / OpenGLES 1.x / OpenGLES 2.x / OpenVG.
>
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
>   meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb  | 11 ++++++
>   meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb |  6 +++
>   meta/recipes-graphics/eglinfo/eglinfo.inc        | 49 ++++++++++++++++++++++++
>   3 files changed, 66 insertions(+)
>   create mode 100644 meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
>   create mode 100644 meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
>   create mode 100644 meta/recipes-graphics/eglinfo/eglinfo.inc
>
> diff --git a/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb b/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
> new file mode 100644
> index 0000000..65b265f
> --- /dev/null
> +++ b/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
> @@ -0,0 +1,11 @@
> +EGLINFO_PLATFORM ?= "fb"
> +EGLINFO_BINARY_NAME ?= "eglinfo-fb"
> +
> +# .bbappend files in BSP meta layers can add EGLINFO_DEVICE
> +# values if necessary. eglinfo.inc contains default values for
> +# the currently supported devices.
> +# Consult the eglinfo README.md for details
> +
> +include eglinfo.inc
> +
> +SUMMARY += "(Framebuffer version)"
> diff --git a/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
> new file mode 100644
> index 0000000..8793a25
> --- /dev/null
> +++ b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
> @@ -0,0 +1,6 @@
> +EGLINFO_PLATFORM ?= "x11"
> +EGLINFO_BINARY_NAME ?= "eglinfo-x11"
> +
> +include eglinfo.inc
> +
> +SUMMARY += "(X11 version)"
> diff --git a/meta/recipes-graphics/eglinfo/eglinfo.inc b/meta/recipes-graphics/eglinfo/eglinfo.inc
> new file mode 100644
> index 0000000..116435d
> --- /dev/null
> +++ b/meta/recipes-graphics/eglinfo/eglinfo.inc
> @@ -0,0 +1,49 @@
> +SUMMARY = "Utility for printing information EGL and its client APIs (OpenGL, OpenGL ES, OpenVG)"
> +SECTION = "graphics"
> +LICENSE = "Zlib"
> +HOMEPAGE = "https://github.com/dv1/eglinfo"
> +LIC_FILES_CHKSUM = "file://LICENSE;md5=8d4f33bc3add976f7dfae85dab66f03c"
> +
> +DEPENDS = "virtual/egl"
> +
> +SRC_URI = "git://github.com/dv1/eglinfo.git;branch=master"
> +SRCREV = "4a49ff59545d9b6a8222badab64115f89d3a6774"
> +
> +S = "${WORKDIR}/git"
> +
> +
> +# BSP layers should add .bbappend files for the -x11 and -fb .bb recipes,
> +# which append the respective EGL/OpenGLES/OpenVG libraries to DEPENDS
> +# not doing that here, since some platforms might not have OpenGL ES or OpenVG support
> +# (in that case, the eglinfo build scripts automatically disable the relevant code paths)
> +
> +EGLINFO_DEVICE ?= "generic"
> +EGLINFO_DEVICE_raspberrypi ?= "raspberrypi"
> +EGLINFO_DEVICE_beagleboard ?= "beagleboard"
> +EGLINFO_DEVICE_mx6 ?= "imx6"
> +
> +
> +do_clean() {
> +	if [ -x ${S}/waf ]; then
> +		${S}/waf distclean
> +	fi
> +}
> +
> +do_configure() {
> +	${S}/waf configure \
> +		--platform=${EGLINFO_PLATFORM} \
> +		--device=${EGLINFO_DEVICE} \
> +		--sysroot ${STAGING_DIR_TARGET} \
> +		--prefix=${prefix} \
> +		${EXTRA_OECONF}
> +}
> +
> +do_compile() {
> +	${S}/waf
> +}
> +
> +do_install() {
> +	mkdir -p "${D}/${bindir}"
> +	mv "${S}/build/release/eglinfo" "${D}/${bindir}/${EGLINFO_BINARY_NAME}"
> +}
> +
>
Otavio Salvador - April 4, 2013, 5:09 p.m.
On Thu, Apr 4, 2013 at 12:41 PM, Saul Wold <sgw@linux.intel.com> wrote:
>
> I am going to defer this to 1.5 when it opens up, I still need to review the
> recipe, but wanted to give you a heads up about the deferral.

Any reasoning to defer it when it adds a good tool for validation and
test? It also offers very low risk of breaking something.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Richard Purdie - April 4, 2013, 10:36 p.m.
On Thu, 2013-04-04 at 14:09 -0300, Otavio Salvador wrote:
> On Thu, Apr 4, 2013 at 12:41 PM, Saul Wold <sgw@linux.intel.com> wrote:
> >
> > I am going to defer this to 1.5 when it opens up, I still need to review the
> > recipe, but wanted to give you a heads up about the deferral.
> 
> Any reasoning to defer it when it adds a good tool for validation and
> test? It also offers very low risk of breaking something.

We're two weeks before release and meant to be bug fixing now, new
features add risk.

You say this patch is low risk but it will actually break builds. Why?
It has machine specific code but isn't marked as machine specific and it
will not work well in world builds for example. That is just the part I
can spot from looking at it but it means its not been widely tested.

Yes, we can fix these things but I really want to focus on the bugs we
have right now, not fixing new code and adding new build failures.

So Saul is right here in deferring this.

Cheers,

Richard
Martin Jansa - Aug. 28, 2013, 8:29 a.m.
On Thu, Apr 04, 2013 at 08:41:39AM -0700, Saul Wold wrote:
> 
> I am going to defer this to 1.5 when it opens up, I still need to review 
> the recipe, but wanted to give you a heads up about the deferral.

It looks like it was deferred too much or is it applied somewhere else?
I don't see it in oe-core.

> 
> 
> Thanks
> 	Sau!
> 
> 
> On 04/03/2013 12:26 PM, Carlos Rafael Giani wrote:
> > eglinfo is a small utility for printing out information about EGL as well
> > as about its client APIs, OpenGL / OpenGLES 1.x / OpenGLES 2.x / OpenVG.
> >
> > Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> > ---
> >   meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb  | 11 ++++++
> >   meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb |  6 +++
> >   meta/recipes-graphics/eglinfo/eglinfo.inc        | 49 ++++++++++++++++++++++++
> >   3 files changed, 66 insertions(+)
> >   create mode 100644 meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
> >   create mode 100644 meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
> >   create mode 100644 meta/recipes-graphics/eglinfo/eglinfo.inc
> >
> > diff --git a/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb b/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
> > new file mode 100644
> > index 0000000..65b265f
> > --- /dev/null
> > +++ b/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
> > @@ -0,0 +1,11 @@
> > +EGLINFO_PLATFORM ?= "fb"
> > +EGLINFO_BINARY_NAME ?= "eglinfo-fb"
> > +
> > +# .bbappend files in BSP meta layers can add EGLINFO_DEVICE
> > +# values if necessary. eglinfo.inc contains default values for
> > +# the currently supported devices.
> > +# Consult the eglinfo README.md for details
> > +
> > +include eglinfo.inc
> > +
> > +SUMMARY += "(Framebuffer version)"
> > diff --git a/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
> > new file mode 100644
> > index 0000000..8793a25
> > --- /dev/null
> > +++ b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
> > @@ -0,0 +1,6 @@
> > +EGLINFO_PLATFORM ?= "x11"
> > +EGLINFO_BINARY_NAME ?= "eglinfo-x11"
> > +
> > +include eglinfo.inc
> > +
> > +SUMMARY += "(X11 version)"
> > diff --git a/meta/recipes-graphics/eglinfo/eglinfo.inc b/meta/recipes-graphics/eglinfo/eglinfo.inc
> > new file mode 100644
> > index 0000000..116435d
> > --- /dev/null
> > +++ b/meta/recipes-graphics/eglinfo/eglinfo.inc
> > @@ -0,0 +1,49 @@
> > +SUMMARY = "Utility for printing information EGL and its client APIs (OpenGL, OpenGL ES, OpenVG)"
> > +SECTION = "graphics"
> > +LICENSE = "Zlib"
> > +HOMEPAGE = "https://github.com/dv1/eglinfo"
> > +LIC_FILES_CHKSUM = "file://LICENSE;md5=8d4f33bc3add976f7dfae85dab66f03c"
> > +
> > +DEPENDS = "virtual/egl"
> > +
> > +SRC_URI = "git://github.com/dv1/eglinfo.git;branch=master"
> > +SRCREV = "4a49ff59545d9b6a8222badab64115f89d3a6774"
> > +
> > +S = "${WORKDIR}/git"
> > +
> > +
> > +# BSP layers should add .bbappend files for the -x11 and -fb .bb recipes,
> > +# which append the respective EGL/OpenGLES/OpenVG libraries to DEPENDS
> > +# not doing that here, since some platforms might not have OpenGL ES or OpenVG support
> > +# (in that case, the eglinfo build scripts automatically disable the relevant code paths)
> > +
> > +EGLINFO_DEVICE ?= "generic"
> > +EGLINFO_DEVICE_raspberrypi ?= "raspberrypi"
> > +EGLINFO_DEVICE_beagleboard ?= "beagleboard"
> > +EGLINFO_DEVICE_mx6 ?= "imx6"
> > +
> > +
> > +do_clean() {
> > +	if [ -x ${S}/waf ]; then
> > +		${S}/waf distclean
> > +	fi
> > +}
> > +
> > +do_configure() {
> > +	${S}/waf configure \
> > +		--platform=${EGLINFO_PLATFORM} \
> > +		--device=${EGLINFO_DEVICE} \
> > +		--sysroot ${STAGING_DIR_TARGET} \
> > +		--prefix=${prefix} \
> > +		${EXTRA_OECONF}
> > +}
> > +
> > +do_compile() {
> > +	${S}/waf
> > +}
> > +
> > +do_install() {
> > +	mkdir -p "${D}/${bindir}"
> > +	mv "${S}/build/release/eglinfo" "${D}/${bindir}/${EGLINFO_BINARY_NAME}"
> > +}
> > +
> >
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb b/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
new file mode 100644
index 0000000..65b265f
--- /dev/null
+++ b/meta/recipes-graphics/eglinfo/eglinfo-fb_1.0.bb
@@ -0,0 +1,11 @@ 
+EGLINFO_PLATFORM ?= "fb"
+EGLINFO_BINARY_NAME ?= "eglinfo-fb"
+
+# .bbappend files in BSP meta layers can add EGLINFO_DEVICE
+# values if necessary. eglinfo.inc contains default values for
+# the currently supported devices.
+# Consult the eglinfo README.md for details
+
+include eglinfo.inc
+
+SUMMARY += "(Framebuffer version)"
diff --git a/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
new file mode 100644
index 0000000..8793a25
--- /dev/null
+++ b/meta/recipes-graphics/eglinfo/eglinfo-x11_1.0.bb
@@ -0,0 +1,6 @@ 
+EGLINFO_PLATFORM ?= "x11"
+EGLINFO_BINARY_NAME ?= "eglinfo-x11"
+
+include eglinfo.inc
+
+SUMMARY += "(X11 version)"
diff --git a/meta/recipes-graphics/eglinfo/eglinfo.inc b/meta/recipes-graphics/eglinfo/eglinfo.inc
new file mode 100644
index 0000000..116435d
--- /dev/null
+++ b/meta/recipes-graphics/eglinfo/eglinfo.inc
@@ -0,0 +1,49 @@ 
+SUMMARY = "Utility for printing information EGL and its client APIs (OpenGL, OpenGL ES, OpenVG)"
+SECTION = "graphics"
+LICENSE = "Zlib"
+HOMEPAGE = "https://github.com/dv1/eglinfo"
+LIC_FILES_CHKSUM = "file://LICENSE;md5=8d4f33bc3add976f7dfae85dab66f03c"
+
+DEPENDS = "virtual/egl"
+
+SRC_URI = "git://github.com/dv1/eglinfo.git;branch=master"
+SRCREV = "4a49ff59545d9b6a8222badab64115f89d3a6774"
+
+S = "${WORKDIR}/git"
+
+
+# BSP layers should add .bbappend files for the -x11 and -fb .bb recipes,
+# which append the respective EGL/OpenGLES/OpenVG libraries to DEPENDS
+# not doing that here, since some platforms might not have OpenGL ES or OpenVG support
+# (in that case, the eglinfo build scripts automatically disable the relevant code paths)
+
+EGLINFO_DEVICE ?= "generic"
+EGLINFO_DEVICE_raspberrypi ?= "raspberrypi"
+EGLINFO_DEVICE_beagleboard ?= "beagleboard"
+EGLINFO_DEVICE_mx6 ?= "imx6"
+
+
+do_clean() {
+	if [ -x ${S}/waf ]; then
+		${S}/waf distclean
+	fi
+}
+
+do_configure() {
+	${S}/waf configure \
+		--platform=${EGLINFO_PLATFORM} \
+		--device=${EGLINFO_DEVICE} \
+		--sysroot ${STAGING_DIR_TARGET} \
+		--prefix=${prefix} \
+		${EXTRA_OECONF}
+}
+
+do_compile() {
+	${S}/waf
+}
+
+do_install() {
+	mkdir -p "${D}/${bindir}"
+	mv "${S}/build/release/eglinfo" "${D}/${bindir}/${EGLINFO_BINARY_NAME}"
+}
+