Patchwork eglibc: Let eglibc-extra-nss-dev exist as empty package

login
register
mail settings
Submitter Khem Raj
Date April 2, 2013, 3:18 a.m.
Message ID <1364872704-14812-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/47247/
State New
Headers show

Comments

Khem Raj - April 2, 2013, 3:18 a.m.
eglibc-extra-nss-dev is a dependency for libc6-dev but
the package is empty and is not created as a result target
install of libc6-dev fails. This will create an empty package

[Yocto Bug #4168]

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/eglibc/eglibc-package.inc |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Richard Purdie - April 2, 2013, 4:46 p.m.
On Mon, 2013-04-01 at 20:18 -0700, Khem Raj wrote:
> eglibc-extra-nss-dev is a dependency for libc6-dev but
> the package is empty and is not created as a result target
> install of libc6-dev fails. This will create an empty package
> 
> [Yocto Bug #4168]
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-core/eglibc/eglibc-package.inc |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
> index 88a00a4..ca0cc4c 100644
> --- a/meta/recipes-core/eglibc/eglibc-package.inc
> +++ b/meta/recipes-core/eglibc/eglibc-package.inc
> @@ -17,7 +17,9 @@ python __anonymous () {
>  # Set this to zero if you don't want ldconfig in the output package
>  USE_LDCONFIG ?= "1"
>  
> -PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
> +PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc eglibc-extra-nss-dev"
> +
> +ALLOW_EMPTY_eglibc-extra-nss-dev  = "1"

As discussed in the bug, I think this is an issue with smart erroring on
recommends which it shouldn't do. More investigation/discussion
therefore needed as this patch just fixes one issue and there will be
others.

Cheers,

Richard
Khem Raj - April 2, 2013, 7:27 p.m.
On Apr 2, 2013, at 9:46 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:

> On Mon, 2013-04-01 at 20:18 -0700, Khem Raj wrote:
>> eglibc-extra-nss-dev is a dependency for libc6-dev but
>> the package is empty and is not created as a result target
>> install of libc6-dev fails. This will create an empty package
>> 
>> [Yocto Bug #4168]
>> 
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-core/eglibc/eglibc-package.inc |    4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
>> index 88a00a4..ca0cc4c 100644
>> --- a/meta/recipes-core/eglibc/eglibc-package.inc
>> +++ b/meta/recipes-core/eglibc/eglibc-package.inc
>> @@ -17,7 +17,9 @@ python __anonymous () {
>> # Set this to zero if you don't want ldconfig in the output package
>> USE_LDCONFIG ?= "1"
>> 
>> -PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
>> +PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc eglibc-extra-nss-dev"
>> +
>> +ALLOW_EMPTY_eglibc-extra-nss-dev  = "1"
> 
> As discussed in the bug, I think this is an issue with smart erroring on
> recommends which it shouldn't do. More investigation/discussion
> therefore needed as this patch just fixes one issue and there will be
> others.
> 

I agree. If its smart issue lets fix smart instead.

> Cheers,
> 
> Richard
>
Mark Hatle - April 2, 2013, 7:41 p.m.
On 4/2/13 2:27 PM, Khem Raj wrote:
>
> On Apr 2, 2013, at 9:46 AM, Richard Purdie <richard.purdie@linuxfoundation.org> wrote:
>
>> On Mon, 2013-04-01 at 20:18 -0700, Khem Raj wrote:
>>> eglibc-extra-nss-dev is a dependency for libc6-dev but
>>> the package is empty and is not created as a result target
>>> install of libc6-dev fails. This will create an empty package
>>>
>>> [Yocto Bug #4168]
>>>
>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>> ---
>>> meta/recipes-core/eglibc/eglibc-package.inc |    4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
>>> index 88a00a4..ca0cc4c 100644
>>> --- a/meta/recipes-core/eglibc/eglibc-package.inc
>>> +++ b/meta/recipes-core/eglibc/eglibc-package.inc
>>> @@ -17,7 +17,9 @@ python __anonymous () {
>>> # Set this to zero if you don't want ldconfig in the output package
>>> USE_LDCONFIG ?= "1"
>>>
>>> -PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
>>> +PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc eglibc-extra-nss-dev"
>>> +
>>> +ALLOW_EMPTY_eglibc-extra-nss-dev  = "1"
>>
>> As discussed in the bug, I think this is an issue with smart erroring on
>> recommends which it shouldn't do. More investigation/discussion
>> therefore needed as this patch just fixes one issue and there will be
>> others.
>>
>
> I agree. If its smart issue lets fix smart instead.

Bug 3723 - smart: Performance enhancement for attemptonly and complementary installs

The purpose of this bug is to fix recommends processing to deal with failures 
gracefully.  It should simply detect the failure and then back off the one item, 
but continue the install progress.

--Mark

>> Cheers,
>>
>> Richard
>>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-core/eglibc/eglibc-package.inc b/meta/recipes-core/eglibc/eglibc-package.inc
index 88a00a4..ca0cc4c 100644
--- a/meta/recipes-core/eglibc/eglibc-package.inc
+++ b/meta/recipes-core/eglibc/eglibc-package.inc
@@ -17,7 +17,9 @@  python __anonymous () {
 # Set this to zero if you don't want ldconfig in the output package
 USE_LDCONFIG ?= "1"
 
-PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc"
+PACKAGES = "${PN}-dbg catchsegv sln nscd ldd ${PN}-utils eglibc-thread-db ${PN}-pic libcidn libmemusage libsegfault ${PN}-pcprofile libsotruss ${PN} eglibc-extra-nss ${PN}-dev ${PN}-staticdev ${PN}-doc eglibc-extra-nss-dev"
+
+ALLOW_EMPTY_eglibc-extra-nss-dev  = "1"
 
 # The ld.so in this eglibc supports the GNU_HASH
 RPROVIDES_${PN} = "glibc rtld(GNU_HASH)"