Patchwork [1/1] core-image-sato.bb: increase free space size

login
register
mail settings
Submitter Qi.Chen@windriver.com
Date April 2, 2013, 2:30 a.m.
Message ID <be55160b84e74f803f6dce4ba755225538a76651.1364793033.git.Qi.Chen@windriver.com>
Download mbox | patch
Permalink /patch/47241/
State New
Headers show

Comments

Qi.Chen@windriver.com - April 2, 2013, 2:30 a.m.
From: Chen Qi <Qi.Chen@windriver.com>

Sato images, by default, have about 100M free space. This is not enough
and it blocks automatic testing.

This patch fixes this problem by overriding the IMAGE_OVERHEAD_FACTOR
in the sato image recipe.

[YOCTO #4109]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta/recipes-sato/images/core-image-sato.bb |    3 +++
 1 file changed, 3 insertions(+)
Khem Raj - April 2, 2013, 2:59 a.m.
On Apr 1, 2013, at 7:30 PM, Qi.Chen@windriver.com wrote:

> +
> +# Override IMAGE_OVERHEAD_FACTOR to increase the free space size on sato images.
> +IMAGE_OVERHEAD_FACTOR = "2.0"

what is the size of image before and after ?
Qi.Chen@windriver.com - April 2, 2013, 3:04 a.m.
On 04/02/2013 10:59 AM, Khem Raj wrote:
> On Apr 1, 2013, at 7:30 PM, Qi.Chen@windriver.com wrote:
>
>> +
>> +# Override IMAGE_OVERHEAD_FACTOR to increase the free space size on sato images.
>> +IMAGE_OVERHEAD_FACTOR = "2.0"
> what is the size of image before and after ?
>
roughly 100M -> 300M.
smart automatic testing will use over 90M. see 
https://bugzilla.yoctoproject.org/show_bug.cgi?id=4109 for more details.

IMAGE_OVERHEAD_FACTOR defaults to 1.3.

Thanks,
Chen Qi
Gary Thomas - April 2, 2013, 10:15 a.m.
On 2013-04-01 20:30, Qi.Chen@windriver.com wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Sato images, by default, have about 100M free space. This is not enough
> and it blocks automatic testing.
>
> This patch fixes this problem by overriding the IMAGE_OVERHEAD_FACTOR
> in the sato image recipe.
>
> [YOCTO #4109]
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>   meta/recipes-sato/images/core-image-sato.bb |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
> index e3246d2..8df1d08 100644
> --- a/meta/recipes-sato/images/core-image-sato.bb
> +++ b/meta/recipes-sato/images/core-image-sato.bb
> @@ -9,3 +9,6 @@ LICENSE = "MIT"
>   inherit core-image
>
>   IMAGE_INSTALL += "packagegroup-core-x11-sato-games"
> +
> +# Override IMAGE_OVERHEAD_FACTOR to increase the free space size on sato images.
> +IMAGE_OVERHEAD_FACTOR = "2.0"
>

You should make this overridable by the user:
   IMAGE_OVERHEAD_FACTOR ?= "2.0"
Qi.Chen@windriver.com - April 3, 2013, 6:16 a.m.
On 04/02/2013 06:15 PM, Gary Thomas wrote:
> On 2013-04-01 20:30, Qi.Chen@windriver.com wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Sato images, by default, have about 100M free space. This is not enough
>> and it blocks automatic testing.
>>
>> This patch fixes this problem by overriding the IMAGE_OVERHEAD_FACTOR
>> in the sato image recipe.
>>
>> [YOCTO #4109]
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   meta/recipes-sato/images/core-image-sato.bb |    3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/meta/recipes-sato/images/core-image-sato.bb 
>> b/meta/recipes-sato/images/core-image-sato.bb
>> index e3246d2..8df1d08 100644
>> --- a/meta/recipes-sato/images/core-image-sato.bb
>> +++ b/meta/recipes-sato/images/core-image-sato.bb
>> @@ -9,3 +9,6 @@ LICENSE = "MIT"
>>   inherit core-image
>>
>>   IMAGE_INSTALL += "packagegroup-core-x11-sato-games"
>> +
>> +# Override IMAGE_OVERHEAD_FACTOR to increase the free space size on 
>> sato images.
>> +IMAGE_OVERHEAD_FACTOR = "2.0"
>>
>
> You should make this overridable by the user:
>   IMAGE_OVERHEAD_FACTOR ?= "2.0"
>
Yes. You're right.
And we can use "??=" in bitbake.conf.
A new patch set has been sent out.

Thanks,
Chen Qi
Ross Burton - April 3, 2013, 10:38 a.m.
On 2 April 2013 03:30,  <Qi.Chen@windriver.com> wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Sato images, by default, have about 100M free space. This is not enough
> and it blocks automatic testing.
>
> This patch fixes this problem by overriding the IMAGE_OVERHEAD_FACTOR
> in the sato image recipe.

If a particular build needs more disk space, you can also use
IMAGE_ROOTFS_EXTRA_SPACE in local.conf, i.e.:

IMAGE_ROOTFS_EXTRA_SPACE = "524288"

(that's add 500MB)

Ross
Otavio Salvador - April 3, 2013, 11:59 a.m.
On Wed, Apr 3, 2013 at 7:38 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 2 April 2013 03:30,  <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Sato images, by default, have about 100M free space. This is not enough
>> and it blocks automatic testing.
>>
>> This patch fixes this problem by overriding the IMAGE_OVERHEAD_FACTOR
>> in the sato image recipe.
>
> If a particular build needs more disk space, you can also use
> IMAGE_ROOTFS_EXTRA_SPACE in local.conf, i.e.:
>
> IMAGE_ROOTFS_EXTRA_SPACE = "524288"
>
> (that's add 500MB)

I think Chen wants a more permanent solution so automatic testing can
work out of box. Maybe a fixed extra size would be better for this
case but needs to be done in the image in either case.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Patch

diff --git a/meta/recipes-sato/images/core-image-sato.bb b/meta/recipes-sato/images/core-image-sato.bb
index e3246d2..8df1d08 100644
--- a/meta/recipes-sato/images/core-image-sato.bb
+++ b/meta/recipes-sato/images/core-image-sato.bb
@@ -9,3 +9,6 @@  LICENSE = "MIT"
 inherit core-image
 
 IMAGE_INSTALL += "packagegroup-core-x11-sato-games"
+
+# Override IMAGE_OVERHEAD_FACTOR to increase the free space size on sato images.
+IMAGE_OVERHEAD_FACTOR = "2.0"