Patchwork pcmciautils: fix segmentation fault of pccardctl command

login
register
mail settings
Submitter Takeshi Hamasaki
Date April 1, 2013, 9:10 a.m.
Message ID <1364807444-20977-1-git-send-email-hmatrjp@users.sourceforge.jp>
Download mbox | patch
Permalink /patch/47187/
State Accepted
Commit aee67a229304827a12b7776a82fb1c320da9a3c4
Headers show

Comments

Takeshi Hamasaki - April 1, 2013, 9:10 a.m.
This changes difinition of PCMCIAUTILS_VERSION to string from a multichacter constant to avoid segmentation fault of pccardctl command.

Signed-off-by: Takeshi Hamasaki <hmatrjp@users.sourceforge.jp>
---
 meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Henning Heinold - April 1, 2013, 11:17 a.m.
On Mon, Apr 01, 2013 at 06:10:44PM +0900, Takeshi Hamasaki wrote:
> 
Hi,

nitpicking about spelling.

> This changes difinition of PCMCIAUTILS_VERSION to string from a multichacter constant to avoid segmentation fault of pccardctl command. 
               ^^^ 

> Signed-off-by: Takeshi Hamasaki <hmatrjp@users.sourceforge.jp>
> ---
>  meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/pcmciautils/pcmciautils.inc b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> index 80271d6..0651236 100644
> --- a/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> +++ b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> @@ -21,7 +21,7 @@ export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
>  export UDEV = "1"
>  LD = "${CC}"
>  CFLAGS =+ "-I${S}/src"
> -CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
> +CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
>  
>  PARALLEL_MAKE = ""
>  EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"
> -- 
> 1.7.10.4

Bye Henning

Patch

diff --git a/meta/recipes-bsp/pcmciautils/pcmciautils.inc b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
index 80271d6..0651236 100644
--- a/meta/recipes-bsp/pcmciautils/pcmciautils.inc
+++ b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
@@ -21,7 +21,7 @@  export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
 export UDEV = "1"
 LD = "${CC}"
 CFLAGS =+ "-I${S}/src"
-CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
+CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
 
 PARALLEL_MAKE = ""
 EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"