Patchwork [oe-core] pcmciautils: Correct definition of PCMCIAUTILS_VERSION to avoid segmentation fault

login
register
mail settings
Submitter Takeshi Hamasaki
Date March 31, 2013, 3:32 a.m.
Message ID <1364700773-32662-1-git-send-email-hmatrjp@users.sourceforge.jp>
Download mbox | patch
Permalink /patch/47179/
State Not Applicable, archived
Headers show

Comments

Takeshi Hamasaki - March 31, 2013, 3:32 a.m.
This is to fix segmentation fault from pccardctl command.
-DPCMCIAUTILS_VERSION=\'${PV}\' passes PCMCIAUILTS_VERSION to compiler as a 
multi-character constant, not a string.

---
 meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Martin Jansa - March 31, 2013, 7:25 a.m.
On Sun, Mar 31, 2013 at 12:32:53PM +0900, Takeshi Hamasaki wrote:
> This is to fix segmentation fault from pccardctl command.
> -DPCMCIAUTILS_VERSION=\'${PV}\' passes PCMCIAUILTS_VERSION to compiler as a 
> multi-character constant, not a string.

oe-core patches need to go to
openembedded-core@lists.openembedded.org

please resend

> 
> ---
>  meta/recipes-bsp/pcmciautils/pcmciautils.inc |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-bsp/pcmciautils/pcmciautils.inc b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> index 80271d6..0651236 100644
> --- a/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> +++ b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
> @@ -21,7 +21,7 @@ export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
>  export UDEV = "1"
>  LD = "${CC}"
>  CFLAGS =+ "-I${S}/src"
> -CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
> +CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
>  
>  PARALLEL_MAKE = ""
>  EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"
> -- 
> 1.7.10.4
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Takeshi Hamasaki - April 1, 2013, 10:54 a.m.
2013/3/31 Martin Jansa <martin.jansa@gmail.com>:
> oe-core patches need to go to
> openembedded-core@lists.openembedded.org
>
> please resend

I subscribed the list and sent it there.
Thanks,

Patch

diff --git a/meta/recipes-bsp/pcmciautils/pcmciautils.inc b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
index 80271d6..0651236 100644
--- a/meta/recipes-bsp/pcmciautils/pcmciautils.inc
+++ b/meta/recipes-bsp/pcmciautils/pcmciautils.inc
@@ -21,7 +21,7 @@  export udevrulesdir = "${nonarch_base_libdir}/udev/rules.d"
 export UDEV = "1"
 LD = "${CC}"
 CFLAGS =+ "-I${S}/src"
-CFLAGS =+ "-DPCMCIAUTILS_VERSION=\'${PV}\'"
+CFLAGS =+ "-DPCMCIAUTILS_VERSION=\\"${PV}\\""
 
 PARALLEL_MAKE = ""
 EXTRA_OEMAKE = "-e 'STRIP=echo' 'LIB_OBJS=-lc -lsysfs' 'LEX=flex'"