Patchwork [bitbake-devel] Removed popup when including a package

login
register
mail settings
Submitter Andrei Dinu
Date March 28, 2013, 11:43 a.m.
Message ID <1364471013-6273-1-git-send-email-andrei.adrianx.dinu@intel.com>
Download mbox | patch
Permalink /patch/47075/
State New
Headers show

Comments

Andrei Dinu - March 28, 2013, 11:43 a.m.
Fixed the functionality which made an information
dialog pop up when including any package.

[HOB #4138]

Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
---
 bitbake/lib/bb/ui/crumbs/packageselectionpage.py |    2 +-
 bitbake/lib/bb/ui/crumbs/recipeselectionpage.py  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Richard Purdie - March 29, 2013, 10:47 a.m.
On Thu, 2013-03-28 at 13:43 +0200, Andrei Dinu wrote:
> Fixed the functionality which made an information
> dialog pop up when including any package.
> 
> [HOB #4138]
> 
> Signed-off-by: Andrei Dinu <andrei.adrianx.dinu@intel.com>
> ---
>  bitbake/lib/bb/ui/crumbs/packageselectionpage.py |    2 +-
>  bitbake/lib/bb/ui/crumbs/recipeselectionpage.py  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Please rebase this on master and your other patch set.

I'd also like to suggest you and Cristiana jointly start generating pull
requests based on a git tree alongside the patches, based on the bitbake
repository. This will make is easier and faster for me to merge changes.

Cheers,

Richard

Patch

diff --git a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
index ce2deab..70d45ef 100755
--- a/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
+++ b/bitbake/lib/bb/ui/crumbs/packageselectionpage.py
@@ -202,7 +202,7 @@  class PackageSelectionPage (HobPage):
     def button_click_cb(self, widget, event):
         path, col = widget.table_tree.get_cursor()
         tree_model = widget.table_tree.get_model()
-        if path: # else activation is likely a removal
+        if path and col.get_title() != 'Included': # else activation is likely a removal
             properties = {'binb': '' , 'name': '', 'size':'', 'recipe':''}
             properties['binb'] = tree_model.get_value(tree_model.get_iter(path), PackageListModel.COL_BINB)
             properties['name'] = tree_model.get_value(tree_model.get_iter(path), PackageListModel.COL_NAME)
diff --git a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
index aa0cd60..e102b29 100755
--- a/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
+++ b/bitbake/lib/bb/ui/crumbs/recipeselectionpage.py
@@ -217,7 +217,7 @@  class RecipeSelectionPage (HobPage):
     def button_click_cb(self, widget, event):
         path, col = widget.table_tree.get_cursor()
         tree_model = widget.table_tree.get_model()
-        if path: # else activation is likely a removal
+        if path and col.get_title() != 'Included': # else activation is likely a removal
             properties = {'summary': '', 'name': '', 'version': '', 'revision': '', 'binb': '', 'group': '', 'license': '', 'homepage': '', 'bugtracker': '', 'description': ''}
             properties['summary'] = tree_model.get_value(tree_model.get_iter(path), RecipeListModel.COL_SUMMARY)
             properties['name'] = tree_model.get_value(tree_model.get_iter(path), RecipeListModel.COL_NAME)