Patchwork [V2,2/2] eglibc.inc: Transfer PARALLEL_MAKE to PARALLELMFLAGS

login
register
mail settings
Submitter Khem Raj
Date May 24, 2011, 7:18 p.m.
Message ID <0ee71fe45ec1b664287c1c277238263e3ff277ef.1306264437.git.raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/4707/
State New, archived
Headers show

Comments

Khem Raj - May 24, 2011, 7:18 p.m.
* Currently we are passing -jN or -j N flags to eglibc makefiles
  however eglibc uses a make variable called PARALLELMFLAGS
  to pass information about parallel build to sub-makes

* Currently make install ran without parallelism but now
  it should have parallel building flags passed to do_install
  correctly which inturn should improve build time of
  eglibc on systems using parallel build -j with values > 1

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta/recipes-core/eglibc/eglibc.inc |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Khem Raj - May 24, 2011, 8:41 p.m.
On (24/05/11 12:18), Khem Raj wrote:
> * Currently we are passing -jN or -j N flags to eglibc makefiles
>   however eglibc uses a make variable called PARALLELMFLAGS
>   to pass information about parallel build to sub-makes
> 
> * Currently make install ran without parallelism but now
>   it should have parallel building flags passed to do_install
>   correctly which inturn should improve build time of
>   eglibc on systems using parallel build -j with values > 1

I forgot to attach the times of do_compile+do_install using -j 2

with patch

real    11m11.557s
user    11m27.270s
sys     2m54.000s

without patch

real    12m39.788s
user    11m36.850s
sys     3m14.310s

> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  meta/recipes-core/eglibc/eglibc.inc |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc
> index 8314cb1..46ffa82 100644
> --- a/meta/recipes-core/eglibc/eglibc.inc
> +++ b/meta/recipes-core/eglibc/eglibc.inc
> @@ -36,4 +36,10 @@ INHIBIT_DEFAULT_DEPS = "1"
>  
>  ARM_INSTRUCTION_SET = "arm"
>  
> +# eglibc uses PARALLELMFLAGS variable to pass parallel build info so transfer
> +# PARALLEL_MAKE into PARALLELMFLAGS and empty out PARALLEL_MAKE
> +EGLIBCPARALLELISM := "PARALLELMFLAGS="${PARALLEL_MAKE}""
> +EXTRA_OEMAKE += ${EGLIBCPARALLELISM}
> +PARALLEL_MAKE = ""
> +
>  PACKAGES = "glibc catchsegv sln nscd ldd localedef glibc-utils glibc-dev glibc-doc glibc-locale libsegfault glibc-extra-nss glibc-thread-db glibc-pcprofile"
> -- 
> 1.7.4.1
>

Patch

diff --git a/meta/recipes-core/eglibc/eglibc.inc b/meta/recipes-core/eglibc/eglibc.inc
index 8314cb1..46ffa82 100644
--- a/meta/recipes-core/eglibc/eglibc.inc
+++ b/meta/recipes-core/eglibc/eglibc.inc
@@ -36,4 +36,10 @@  INHIBIT_DEFAULT_DEPS = "1"
 
 ARM_INSTRUCTION_SET = "arm"
 
+# eglibc uses PARALLELMFLAGS variable to pass parallel build info so transfer
+# PARALLEL_MAKE into PARALLELMFLAGS and empty out PARALLEL_MAKE
+EGLIBCPARALLELISM := "PARALLELMFLAGS="${PARALLEL_MAKE}""
+EXTRA_OEMAKE += ${EGLIBCPARALLELISM}
+PARALLEL_MAKE = ""
+
 PACKAGES = "glibc catchsegv sln nscd ldd localedef glibc-utils glibc-dev glibc-doc glibc-locale libsegfault glibc-extra-nss glibc-thread-db glibc-pcprofile"