Patchwork initscripts: RDEPENDS sed to remove "sed: command not found".

login
register
mail settings
Submitter anders.roxell@gmail.com
Date March 26, 2013, 8:20 a.m.
Message ID <1364286013-25970-1-git-send-email-anders.roxell@gmail.com>
Download mbox | patch
Permalink /patch/46911/
State New
Headers show

Comments

anders.roxell@gmail.com - March 26, 2013, 8:20 a.m.
From: Anders Roxell <anders.roxell@enea.com>

Log:
/etc/rcS.d/S37populate-volatile.sh: line 13: sed: command not found
/etc/rcS.d/S37populate-volatile.sh: line 152: sed: command not found
/etc/rcS.d/S37populate-volatile.sh: line 152: sed: command not found

Signed-off-by: Anders Roxell <anders.roxell@enea.com>
---
 meta/recipes-core/initscripts/initscripts_1.0.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Qi.Chen@windriver.com - March 26, 2013, 9:17 a.m.
On 03/26/2013 04:20 PM, anders.roxell@gmail.com wrote:
> From: Anders Roxell <anders.roxell@enea.com>
>
> Log:
> /etc/rcS.d/S37populate-volatile.sh: line 13: sed: command not found
> /etc/rcS.d/S37populate-volatile.sh: line 152: sed: command not found
> /etc/rcS.d/S37populate-volatile.sh: line 152: sed: command not found
>
> Signed-off-by: Anders Roxell <anders.roxell@enea.com>
> ---
>   meta/recipes-core/initscripts/initscripts_1.0.bb |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
> index 649e182..bfd3d28 100644
> --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
> +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
> @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system startup initialization scrip
>   SECTION = "base"
>   LICENSE = "GPLv2"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
> -PR = "r140"
> +PR = "r141"
>   
>   INHIBIT_DEFAULT_DEPS = "1"
>   
> @@ -39,6 +39,7 @@ KERNEL_VERSION = ""
>   
>   inherit update-alternatives
>   DEPENDS_append = " update-rc.d-native"
> +RDEPENDS_${PN} = " sed"
>   
>   ALTERNATIVE_PRIORITY = "90"
>   ALTERNATIVE_${PN} = "functions"

busybox also provides sed if CONFIG_SED is enabled.
I'm wondering whether it's necessary to insert dependency here.
If so, then I think other packages which provide init scripts may also 
rdepend on 'busybox' or 'coreutils' which provide basic commands like 
'chown' or 'sed'.

Best Regards,
Chen Qi
anders.roxell@gmail.com - March 27, 2013, 5:15 p.m.
On Tue, Mar 26, 2013 at 10:17 AM, ChenQi <Qi.Chen@windriver.com> wrote:

> On 03/26/2013 04:20 PM, anders.roxell@gmail.com wrote:
>
>> From: Anders Roxell <anders.roxell@enea.com>
>>
>> Log:
>> /etc/rcS.d/S37populate-**volatile.sh: line 13: sed: command not found
>> /etc/rcS.d/S37populate-**volatile.sh: line 152: sed: command not found
>> /etc/rcS.d/S37populate-**volatile.sh: line 152: sed: command not found
>>
>> Signed-off-by: Anders Roxell <anders.roxell@enea.com>
>> ---
>>   meta/recipes-core/initscripts/**initscripts_1.0.bb<http://initscripts_1.0.bb>|    3 ++-
>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-core/**initscripts/initscripts_1.0.bbb/meta/recipes-core/
>> **initscripts/initscripts_1.0.bb
>> index 649e182..bfd3d28 100644
>> --- a/meta/recipes-core/**initscripts/initscripts_1.0.bb
>> +++ b/meta/recipes-core/**initscripts/initscripts_1.0.bb
>> @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic system
>> startup initialization scrip
>>   SECTION = "base"
>>   LICENSE = "GPLv2"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=**751419260aa954499f7abaabaa882b
>> **be"
>> -PR = "r140"
>> +PR = "r141"
>>     INHIBIT_DEFAULT_DEPS = "1"
>>   @@ -39,6 +39,7 @@ KERNEL_VERSION = ""
>>     inherit update-alternatives
>>   DEPENDS_append = " update-rc.d-native"
>> +RDEPENDS_${PN} = " sed"
>>     ALTERNATIVE_PRIORITY = "90"
>>   ALTERNATIVE_${PN} = "functions"
>>
>
> busybox also provides sed if CONFIG_SED is enabled.
> I'm wondering whether it's necessary to insert dependency here.
> If so, then I think other packages which provide init scripts may also
> rdepend on 'busybox' or 'coreutils' which provide basic commands like
> 'chown' or 'sed'.
>

aha... I missed that busybox could provide sed... I would like to do some
sort of rdepends on busybox or sed (because coreutils does not provide the
sed command).
However, I only want sed if busybox isn't present and vice versa is there a
way to do this?

With kind regards,
Anders

>
> Best Regards,
> Chen Qi
>
>
> ______________________________**_________________
> Openembedded-core mailing list
> Openembedded-core@lists.**openembedded.org<Openembedded-core@lists.openembedded.org>
> http://lists.linuxtogo.org/**cgi-bin/mailman/listinfo/**openembedded-core<http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core>
>
Qi.Chen@windriver.com - March 28, 2013, 2:42 a.m.
On 03/28/2013 01:15 AM, Anders Roxell wrote:
>
>
>
> On Tue, Mar 26, 2013 at 10:17 AM, ChenQi <Qi.Chen@windriver.com 
> <mailto:Qi.Chen@windriver.com>> wrote:
>
>     On 03/26/2013 04:20 PM, anders.roxell@gmail.com
>     <mailto:anders.roxell@gmail.com> wrote:
>
>         From: Anders Roxell <anders.roxell@enea.com
>         <mailto:anders.roxell@enea.com>>
>
>         Log:
>         /etc/rcS.d/S37populate-volatile.sh: line 13: sed: command not
>         found
>         /etc/rcS.d/S37populate-volatile.sh: line 152: sed: command not
>         found
>         /etc/rcS.d/S37populate-volatile.sh: line 152: sed: command not
>         found
>
>         Signed-off-by: Anders Roxell <anders.roxell@enea.com
>         <mailto:anders.roxell@enea.com>>
>         ---
>           meta/recipes-core/initscripts/initscripts_1.0.bb
>         <http://initscripts_1.0.bb> |    3 ++-
>           1 files changed, 2 insertions(+), 1 deletions(-)
>
>         diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb
>         <http://initscripts_1.0.bb>
>         b/meta/recipes-core/initscripts/initscripts_1.0.bb
>         <http://initscripts_1.0.bb>
>         index 649e182..bfd3d28 100644
>         --- a/meta/recipes-core/initscripts/initscripts_1.0.bb
>         <http://initscripts_1.0.bb>
>         +++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
>         <http://initscripts_1.0.bb>
>         @@ -3,7 +3,7 @@ DESCRIPTION = "Initscripts provide the basic
>         system startup initialization scrip
>           SECTION = "base"
>           LICENSE = "GPLv2"
>           LIC_FILES_CHKSUM =
>         "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
>         -PR = "r140"
>         +PR = "r141"
>             INHIBIT_DEFAULT_DEPS = "1"
>           @@ -39,6 +39,7 @@ KERNEL_VERSION = ""
>             inherit update-alternatives
>           DEPENDS_append = " update-rc.d-native"
>         +RDEPENDS_${PN} = " sed"
>             ALTERNATIVE_PRIORITY = "90"
>           ALTERNATIVE_${PN} = "functions"
>
>
>     busybox also provides sed if CONFIG_SED is enabled.
>     I'm wondering whether it's necessary to insert dependency here.
>     If so, then I think other packages which provide init scripts may
>     also rdepend on 'busybox' or 'coreutils' which provide basic
>     commands like 'chown' or 'sed'.
>
>
> aha... I missed that busybox could provide sed... I would like to do 
> some sort of rdepends on busybox or sed (because coreutils does not 
> provide the sed command).
> However, I only want sed if busybox isn't present and vice versa is 
> there a way to do this?
>
In this recipe? Maybe we could, but I don't know how.

Maybe you could look at the packagegroup 
concept(meta/recipes-core/packagegroups/packagegroup-core-boot.bb, for 
example, groups busybox and initscripts together).

Best Regards,
Chen Qi

> With kind regards,
> Anders
>
>
>     Best Regards,
>     Chen Qi
>
>
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/recipes-core/initscripts/initscripts_1.0.bb b/meta/recipes-core/initscripts/initscripts_1.0.bb
index 649e182..bfd3d28 100644
--- a/meta/recipes-core/initscripts/initscripts_1.0.bb
+++ b/meta/recipes-core/initscripts/initscripts_1.0.bb
@@ -3,7 +3,7 @@  DESCRIPTION = "Initscripts provide the basic system startup initialization scrip
 SECTION = "base"
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
-PR = "r140"
+PR = "r141"
 
 INHIBIT_DEFAULT_DEPS = "1"
 
@@ -39,6 +39,7 @@  KERNEL_VERSION = ""
 
 inherit update-alternatives
 DEPENDS_append = " update-rc.d-native"
+RDEPENDS_${PN} = " sed"
 
 ALTERNATIVE_PRIORITY = "90"
 ALTERNATIVE_${PN} = "functions"