Patchwork [meta-fsl-arm-extra] broadcom-nvram-config: Add compatible machine setting

login
register
mail settings
Submitter Otavio Salvador
Date March 25, 2013, 12:51 p.m.
Message ID <1364215919-13865-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/46845/
State Accepted
Delegated to: Otavio Salvador
Headers show

Comments

Otavio Salvador - March 25, 2013, 12:51 p.m.
This avoid a warning, during recipe parsing of bitbake, due an
incompatible machine as the nvram.txt is not available as no know
default one is suitable for every board so a specific one is need.

Change-Id: I409a1310c6f37975a46d79cdbd84665daa381e0d
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb | 1 +
 1 file changed, 1 insertion(+)
John Weber - March 25, 2013, 3:34 p.m.
Otavio -

I thought the point of setting:

BROADCOM_FIRMWARE = "INVALID"

was to throw an error on purpose in case someone added the package to their 
machine and did not modify the recipe to provide a corresponding nvram file for 
their machine?

Doesn't adding COMPATIBLE_MACHINE remove that error?

John

On 3/25/13 7:51 AM, Otavio Salvador wrote:
> This avoid a warning, during recipe parsing of bitbake, due an
> incompatible machine as the nvram.txt is not available as no know
> default one is suitable for every board so a specific one is need.
>
> Change-Id: I409a1310c6f37975a46d79cdbd84665daa381e0d
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>   recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
> index 0afd374..85f56d2 100644
> --- a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
> +++ b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
> @@ -26,3 +26,4 @@ BROADCOM_FIRMWARE_wandboard-dual = "bcm4329"
>
>   RDEPENDS_${PN} = "linux-firmware-${BROADCOM_FIRMWARE}"
>
> +COMPATIBLE_MACHINE = "(wandboard-dual)"
>
Otavio Salvador - March 25, 2013, 5:31 p.m.
On Mon, Mar 25, 2013 at 12:34 PM, John Weber <rjohnweber@gmail.com> wrote:
> Otavio -
>
> I thought the point of setting:
>
> BROADCOM_FIRMWARE = "INVALID"
>
> was to throw an error on purpose in case someone added the package to their
> machine and did not modify the recipe to provide a corresponding nvram file
> for their machine?

It will do in rootfs generation as linux-firmware-INVALID won't be instalable.

> Doesn't adding COMPATIBLE_MACHINE remove that error?

Yes but the reason I added it is because bitbake try to checksum a
nvram.txt file which does not exist to other machines and then do a
warning during recipe parsing.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
John Weber - March 25, 2013, 6:27 p.m.
OK.  I understand now.  Sounds good.

On 3/25/13 12:31 PM, Otavio Salvador wrote:
> On Mon, Mar 25, 2013 at 12:34 PM, John Weber <rjohnweber@gmail.com> wrote:
>> Otavio -
>>
>> I thought the point of setting:
>>
>> BROADCOM_FIRMWARE = "INVALID"
>>
>> was to throw an error on purpose in case someone added the package to their
>> machine and did not modify the recipe to provide a corresponding nvram file
>> for their machine?
>
> It will do in rootfs generation as linux-firmware-INVALID won't be instalable.
>
>> Doesn't adding COMPATIBLE_MACHINE remove that error?
>
> Yes but the reason I added it is because bitbake try to checksum a
> nvram.txt file which does not exist to other machines and then do a
> warning during recipe parsing.
>
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>

Patch

diff --git a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
index 0afd374..85f56d2 100644
--- a/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
+++ b/recipes-bsp/broadcom-nvram-config/broadcom-nvram-config.bb
@@ -26,3 +26,4 @@  BROADCOM_FIRMWARE_wandboard-dual = "bcm4329"
 
 RDEPENDS_${PN} = "linux-firmware-${BROADCOM_FIRMWARE}"
 
+COMPATIBLE_MACHINE = "(wandboard-dual)"