Patchwork [2/4] linux-firmware: Do not deploy license files in packages

login
register
mail settings
Submitter Otavio Salvador
Date March 23, 2013, 8:30 p.m.
Message ID <1364070660-13157-2-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/46799/
State New
Headers show

Comments

Otavio Salvador - March 23, 2013, 8:30 p.m.
We don't ship license files with packages and firmware packages are no
different; drop them.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 9 ---------
 1 file changed, 9 deletions(-)
Khem Raj - March 23, 2013, 9:23 p.m.
Should they be packaged elsewhere

On Saturday, March 23, 2013, Otavio Salvador <otavio@ossystems.com.br>
wrote:
> We don't ship license files with packages and firmware packages are no
> different; drop them.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>  meta/recipes-kernel/linux-firmware/linux-firmware_git.bb | 9 ---------
>  1 file changed, 9 deletions(-)
>
> diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bbb/meta/recipes-kernel/linux-firmware/
linux-firmware_git.bb
> index 6842738..99c226c 100644
> --- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> +++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
> @@ -42,9 +42,6 @@ do_install() {
>         ln -sf libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
>         ln -sf libertas/sd8686_v9_helper.bin
${D}/lib/firmware/sd8686_helper.bin
>
> -       # Realtek rtl8192*
> -       install -m 0644 LICENCE.rtlwifi_firmware.txt
${D}/lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt
> -
>         # fixup wl12xx location, after 2.6.37 the kernel searches a
different location for it
>         ( cd ${D}/lib/firmware ; ln -sf ti-connectivity/* . )
>  }
> @@ -56,20 +53,17 @@ PACKAGES =+ "${PN}-ralink ${PN}-sd8686
${PN}-rtl8192cu \
>  LICENSE_${PN}-ralink = "Firmware-ralink"
>  FILES_${PN}-ralink = " \
>    /lib/firmware/rt*.bin \
> -  /lib/firmware/LICENSE.ralink_firmware.txt \
>  "
>
>  LICENSE_${PN}-sd8686 = "Firmware-libertas"
>  FILES_${PN}-sd8686 = " \
>    /lib/firmware/libertas/sd8686_v9* \
>    /lib/firmware/sd8686* \
> -  /lib/firmware/LICENCE.libertas \
>  "
>
>  LICENSE_${PN}-rtl8192cu = "Firmware-rtlwifi"
>  FILES_${PN}-rtl8192cu = " \
>    /lib/firmware/rtlwifi/rtl8192cufw.bin \
> -  /lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt \
>  "
>
>  LICENSE_${PN}-rtl8192ce = "Firmware-rtlwifi"
> @@ -97,7 +91,6 @@ ALTERNATIVE_LINK_NAME[brcmfmac-sdio.bin] =
"/lib/firmware/brcm/brcmfmac-sdio.bin
>  LICENSE_${PN}-bcm4329 = "Firmware-bcm4329"
>  FILES_${PN}-bcm4329 = " \
>    /lib/firmware/brcm/brcmfmac4329.bin \
> -  /lib/firmware/LICENCE.broadcom_bcm43xx \
>  "
>  ALTERNATIVE_linux-firmware-bcm4329 = "brcmfmac-sdio.bin"
>  ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] =
"/lib/firmware/brcm/brcmfmac4329.bin"
> @@ -105,7 +98,6 @@
ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] =
"/lib/firmware/br
>  LICENSE_${PN}-bcm4330 = "Firmware-bcm4330"
>  FILES_${PN}-bcm4330 = " \
>    /lib/firmware/brcm/brcmfmac4330.bin \
> -  /lib/firmware/LICENCE.broadcom_bcm43xx \
>  "
>
>  ALTERNATIVE_linux-firmware-bcm4330 = "brcmfmac-sdio.bin"
> @@ -114,7 +106,6 @@
ALTERNATIVE_TARGET_linux-firmware-bcm4330[brcmfmac-sdio.bin] =
"/lib/firmware/br
>  LICENSE_${PN}-bcm4334 = "Firmware-bcm4334"
>  FILES_${PN}-bcm4334 = " \
>    /lib/firmware/brcm/brcmfmac4334.bin \
> -  /lib/firmware/LICENCE.broadcom_bcm43xx \
>  "
>
>  ALTERNATIVE_linux-firmware-bcm4334 = "brcmfmac-sdio.bin"
> --
> 1.8.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Otavio Salvador - March 23, 2013, 10:13 p.m.
On Sat, Mar 23, 2013 at 6:23 PM, Khem Raj <raj.khem@gmail.com> wrote:
> Should they be packaged elsewhere

It may come in the package license but this not at my control and I
think it is being done already. Not in binaries for rootfs.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Eric BENARD - March 24, 2013, 3:01 p.m.
Hi Otavio,

Le Sat, 23 Mar 2013 17:30:58 -0300,
Otavio Salvador <otavio@ossystems.com.br> a écrit :
> We don't ship license files with packages and firmware packages are no
> different; drop them.
> 
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

there may be a good reason to distribute the license files together with
the firmware's binairies : it's often requested by the firmware's
license.

For example in bcm43xx
2.	Restrictions. Licensee shall distribute Software with a copy
of this Agreement. 

Best regards,
Eric
Otavio Salvador - March 24, 2013, 3:42 p.m.
On Sun, Mar 24, 2013 at 12:01 PM, Eric Bénard <eric@eukrea.com> wrote:
> Hi Otavio,
>
> Le Sat, 23 Mar 2013 17:30:58 -0300,
> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>> We don't ship license files with packages and firmware packages are no
>> different; drop them.
>>
>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> there may be a good reason to distribute the license files together with
> the firmware's binairies : it's often requested by the firmware's
> license.
>
> For example in bcm43xx
> 2.      Restrictions. Licensee shall distribute Software with a copy
> of this Agreement.

In this case we'll need to have a -license package for each license as
we often have more than one fw covered by same license. I'd like to
someone to comment on this so I can send a patch to fix it.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
John Weber - March 24, 2013, 4:55 p.m.
Showing my ignorance here, but is a manifest created with all of the packaged 
licenses?  Is it possible for the developer to ship that if they see fit?

I think what Otavio was trying to do was to keep /lib/firmware from being 
cluttered with license files.  At least, that is the benefit as I see it.


On 3/24/13 10:42 AM, Otavio Salvador wrote:
> On Sun, Mar 24, 2013 at 12:01 PM, Eric Bénard <eric@eukrea.com> wrote:
>> Hi Otavio,
>>
>> Le Sat, 23 Mar 2013 17:30:58 -0300,
>> Otavio Salvador <otavio@ossystems.com.br> a écrit :
>>> We don't ship license files with packages and firmware packages are no
>>> different; drop them.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>
>> there may be a good reason to distribute the license files together with
>> the firmware's binairies : it's often requested by the firmware's
>> license.
>>
>> For example in bcm43xx
>> 2.      Restrictions. Licensee shall distribute Software with a copy
>> of this Agreement.
>
> In this case we'll need to have a -license package for each license as
> we often have more than one fw covered by same license. I'd like to
> someone to comment on this so I can send a patch to fix it.
>
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Eric BENARD - March 24, 2013, 5:52 p.m.
Le Sun, 24 Mar 2013 11:55:09 -0500,
John Weber <rjohnweber@gmail.com> a écrit :

> Showing my ignorance here, but is a manifest created with all of the packaged 
> licenses?  Is it possible for the developer to ship that if they see fit?
> 
> I think what Otavio was trying to do was to keep /lib/firmware from being 
> cluttered with license files.  At least, that is the benefit as I see it.
> 
I see the benefit, I was just giving a reason why the initial recipe
writer may have wanted to include the license files in the packages
together with the binaries of the firmwares.

Eric

Patch

diff --git a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
index 6842738..99c226c 100644
--- a/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
+++ b/meta/recipes-kernel/linux-firmware/linux-firmware_git.bb
@@ -42,9 +42,6 @@  do_install() {
 	ln -sf libertas/sd8686_v9.bin ${D}/lib/firmware/sd8686.bin
 	ln -sf libertas/sd8686_v9_helper.bin ${D}/lib/firmware/sd8686_helper.bin
 
-	# Realtek rtl8192* 
-	install -m 0644 LICENCE.rtlwifi_firmware.txt ${D}/lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt
-
 	# fixup wl12xx location, after 2.6.37 the kernel searches a different location for it
 	( cd ${D}/lib/firmware ; ln -sf ti-connectivity/* . )
 }
@@ -56,20 +53,17 @@  PACKAGES =+ "${PN}-ralink ${PN}-sd8686 ${PN}-rtl8192cu \
 LICENSE_${PN}-ralink = "Firmware-ralink"
 FILES_${PN}-ralink = " \
   /lib/firmware/rt*.bin \
-  /lib/firmware/LICENSE.ralink_firmware.txt \
 "
 
 LICENSE_${PN}-sd8686 = "Firmware-libertas"
 FILES_${PN}-sd8686 = " \
   /lib/firmware/libertas/sd8686_v9* \
   /lib/firmware/sd8686* \
-  /lib/firmware/LICENCE.libertas \
 "
 
 LICENSE_${PN}-rtl8192cu = "Firmware-rtlwifi"
 FILES_${PN}-rtl8192cu = " \
   /lib/firmware/rtlwifi/rtl8192cufw.bin \
-  /lib/firmware/rtlwifi/LICENCE.rtlwifi_firmware.txt \
 "
 
 LICENSE_${PN}-rtl8192ce = "Firmware-rtlwifi"
@@ -97,7 +91,6 @@  ALTERNATIVE_LINK_NAME[brcmfmac-sdio.bin] = "/lib/firmware/brcm/brcmfmac-sdio.bin
 LICENSE_${PN}-bcm4329 = "Firmware-bcm4329"
 FILES_${PN}-bcm4329 = " \
   /lib/firmware/brcm/brcmfmac4329.bin \
-  /lib/firmware/LICENCE.broadcom_bcm43xx \
 "
 ALTERNATIVE_linux-firmware-bcm4329 = "brcmfmac-sdio.bin"
 ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] = "/lib/firmware/brcm/brcmfmac4329.bin"
@@ -105,7 +98,6 @@  ALTERNATIVE_TARGET_linux-firmware-bcm4329[brcmfmac-sdio.bin] = "/lib/firmware/br
 LICENSE_${PN}-bcm4330 = "Firmware-bcm4330"
 FILES_${PN}-bcm4330 = " \
   /lib/firmware/brcm/brcmfmac4330.bin \
-  /lib/firmware/LICENCE.broadcom_bcm43xx \
 "
 
 ALTERNATIVE_linux-firmware-bcm4330 = "brcmfmac-sdio.bin"
@@ -114,7 +106,6 @@  ALTERNATIVE_TARGET_linux-firmware-bcm4330[brcmfmac-sdio.bin] = "/lib/firmware/br
 LICENSE_${PN}-bcm4334 = "Firmware-bcm4334"
 FILES_${PN}-bcm4334 = " \
   /lib/firmware/brcm/brcmfmac4334.bin \
-  /lib/firmware/LICENCE.broadcom_bcm43xx \
 "
 
 ALTERNATIVE_linux-firmware-bcm4334 = "brcmfmac-sdio.bin"